| Message ID | 20220608211207.2058487-2-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | 7d321ab297c9ea88f6ceab122e3ccc034b304ca1 |
| Headers | show |
| Series | dt-bindings: input: Common property clean-ups and adc-keys conversion | expand |
Hi Rob, On Wed, Jun 08, 2022 at 03:12:03PM -0600, Rob Herring wrote: > The maximum keycode value for Linux is 0x2ff, not 0xff. There's already > users and examples with values greater than 0xff, but the schema is not > yet applied in those cases. > > Signed-off-by: Rob Herring <robh@kernel.org> As the creator of a few said examples: Reviewed-by: Jeff LaBundy <jeff@labundy.com> > --- > Documentation/devicetree/bindings/input/input.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml > index d41d8743aad4..43d2f299c332 100644 > --- a/Documentation/devicetree/bindings/input/input.yaml > +++ b/Documentation/devicetree/bindings/input/input.yaml > @@ -21,7 +21,7 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32-array > items: > minimum: 0 > - maximum: 0xff > + maximum: 0x2ff > > poll-interval: > description: Poll interval time in milliseconds. > -- > 2.34.1 > Thank you for driving this series. Kind regards, Jeff LaBundy
On Thu, Jun 09, 2022 at 07:46:51AM +0200, Heinrich Schuchardt wrote: > On 6/8/22 23:12, Rob Herring wrote: > > The maximum keycode value for Linux is 0x2ff, not 0xff. There's already > > users and examples with values greater than 0xff, but the schema is not > > yet applied in those cases. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/input/input.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml > > index d41d8743aad4..43d2f299c332 100644 > > --- a/Documentation/devicetree/bindings/input/input.yaml > > +++ b/Documentation/devicetree/bindings/input/input.yaml > > @@ -21,7 +21,7 @@ properties: > > $ref: /schemas/types.yaml#/definitions/uint32-array > > items: > > minimum: 0 > > - maximum: 0xff > > + maximum: 0x2ff > > Can this value of 0x2ff be make exportable such that we can use it as a > reference in devicetree/bindings/input/adc-keys.yaml. E.g. define a type > that only take values in the 0-0x2ff range? There's no need. The $ref to input.yaml in does that effectively already. That's why 'linux,code' doesn't need any schema constraints unless it has additional constraints. max77650-onkey.yaml in patch 2 has an example of that. If you wanted to add a new, custom property with those constraints, then we could do something like this: $defs: input-codes: minimum: 0 maximum: 0x2ff ... And then have: $ref: input.yaml#/$defs/input-codes Rob
diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml index d41d8743aad4..43d2f299c332 100644 --- a/Documentation/devicetree/bindings/input/input.yaml +++ b/Documentation/devicetree/bindings/input/input.yaml @@ -21,7 +21,7 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32-array items: minimum: 0 - maximum: 0xff + maximum: 0x2ff poll-interval: description: Poll interval time in milliseconds.
The maximum keycode value for Linux is 0x2ff, not 0xff. There's already users and examples with values greater than 0xff, but the schema is not yet applied in those cases. Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/input/input.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)