| Message ID | 20220504135214.28901-1-yang.lee@linux.alibaba.com |
|---|---|
| State | Accepted |
| Commit | b770583ba6028e8cbd2d49dad9eff63cba3d6fef |
| Headers | show |
| Series | [-next] power: supply: Remove unnecessary print function dev_err() | expand |
Hi, On Wed, May 04, 2022 at 09:52:14PM +0800, Yang Li wrote: > The print function dev_err() is redundant because > platform_get_irq() already prints an error. > > Eliminate the follow coccicheck warning: > ./drivers/power/supply/goldfish_battery.c:225:2-9: line 225 is > redundant because platform_get_irq() already prints an error > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- Thanks, queued. -- Sebastian > drivers/power/supply/goldfish_battery.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/power/supply/goldfish_battery.c b/drivers/power/supply/goldfish_battery.c > index bf1754355c9f..a58d713d75ce 100644 > --- a/drivers/power/supply/goldfish_battery.c > +++ b/drivers/power/supply/goldfish_battery.c > @@ -221,10 +221,8 @@ static int goldfish_battery_probe(struct platform_device *pdev) > } > > data->irq = platform_get_irq(pdev, 0); > - if (data->irq < 0) { > - dev_err(&pdev->dev, "platform_get_irq failed\n"); > + if (data->irq < 0) > return -ENODEV; > - } > > ret = devm_request_irq(&pdev->dev, data->irq, > goldfish_battery_interrupt, > -- > 2.20.1.7.g153144c >
diff --git a/drivers/power/supply/goldfish_battery.c b/drivers/power/supply/goldfish_battery.c index bf1754355c9f..a58d713d75ce 100644 --- a/drivers/power/supply/goldfish_battery.c +++ b/drivers/power/supply/goldfish_battery.c @@ -221,10 +221,8 @@ static int goldfish_battery_probe(struct platform_device *pdev) } data->irq = platform_get_irq(pdev, 0); - if (data->irq < 0) { - dev_err(&pdev->dev, "platform_get_irq failed\n"); + if (data->irq < 0) return -ENODEV; - } ret = devm_request_irq(&pdev->dev, data->irq, goldfish_battery_interrupt,
The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/power/supply/goldfish_battery.c:225:2-9: line 225 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/power/supply/goldfish_battery.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)