mbox series

[v4,0/3] target/m68k: semihosting cleanup

Message ID 20220607222616.717435-1-richard.henderson@linaro.org
Headers show
Series target/m68k: semihosting cleanup | expand

Message

Richard Henderson June 7, 2022, 10:26 p.m. UTC
Based-on: <20220607204557.658541-1-richard.henderson@linaro.org>
("[PATCH v4 00/53] semihosting cleanup")

Changes for v4:
  * Split out of v2.
  * Convert host errno to gdb errno, which for m68k is guest errno.


r~


Richard Henderson (3):
  target/m68k: Eliminate m68k_semi_is_fseek
  target/m68k: Make semihosting system only
  target/m68k: Use semihosting/syscalls.h

 linux-user/m68k/cpu_loop.c |   5 -
 target/m68k/m68k-semi.c    | 375 +++++++++----------------------------
 target/m68k/meson.build    |   6 +-
 3 files changed, 92 insertions(+), 294 deletions(-)

Comments

Laurent Vivier June 8, 2022, 9:36 a.m. UTC | #1
Le 08/06/2022 à 00:26, Richard Henderson a écrit :
> Based-on: <20220607204557.658541-1-richard.henderson@linaro.org>
> ("[PATCH v4 00/53] semihosting cleanup")
> 
> Changes for v4:
>    * Split out of v2.
>    * Convert host errno to gdb errno, which for m68k is guest errno.
> 

How do you test semihosting on m68k?

Thanks,
Laurent
Richard Henderson June 8, 2022, 2:53 p.m. UTC | #2
On 6/8/22 02:36, Laurent Vivier wrote:
> Le 08/06/2022 à 00:26, Richard Henderson a écrit :
>> Based-on: <20220607204557.658541-1-richard.henderson@linaro.org>
>> ("[PATCH v4 00/53] semihosting cleanup")
>>
>> Changes for v4:
>>    * Split out of v2.
>>    * Convert host errno to gdb errno, which for m68k is guest errno.
>>
> 
> How do you test semihosting on m68k?

I have only compiled this.  I had been working on adding something to tests/tcg/m68k/, 
which is where those halt patches came from, but haven't finished.


r~
Laurent Vivier June 8, 2022, 6:08 p.m. UTC | #3
Le 08/06/2022 à 16:53, Richard Henderson a écrit :
> On 6/8/22 02:36, Laurent Vivier wrote:
>> Le 08/06/2022 à 00:26, Richard Henderson a écrit :
>>> Based-on: <20220607204557.658541-1-richard.henderson@linaro.org>
>>> ("[PATCH v4 00/53] semihosting cleanup")
>>>
>>> Changes for v4:
>>>    * Split out of v2.
>>>    * Convert host errno to gdb errno, which for m68k is guest errno.
>>>
>>
>> How do you test semihosting on m68k?
> 
> I have only compiled this.  I had been working on adding something to tests/tcg/m68k/, which is 
> where those halt patches came from, but haven't finished.
> 

But what is the use case of semihosting on m68k?
Is there a kernel implementation available for that?

Thanks,
Laurent
Richard Henderson June 8, 2022, 7:05 p.m. UTC | #4
On 6/8/22 11:08, Laurent Vivier wrote:
> Le 08/06/2022 à 16:53, Richard Henderson a écrit :
>> On 6/8/22 02:36, Laurent Vivier wrote:
>>> Le 08/06/2022 à 00:26, Richard Henderson a écrit :
>>>> Based-on: <20220607204557.658541-1-richard.henderson@linaro.org>
>>>> ("[PATCH v4 00/53] semihosting cleanup")
>>>>
>>>> Changes for v4:
>>>>    * Split out of v2.
>>>>    * Convert host errno to gdb errno, which for m68k is guest errno.
>>>>
>>>
>>> How do you test semihosting on m68k?
>>
>> I have only compiled this.  I had been working on adding something to tests/tcg/m68k/, 
>> which is where those halt patches came from, but haven't finished.
>>
> 
> But what is the use case of semihosting on m68k?
> Is there a kernel implementation available for that?

Not that I'm aware of.  Do you want to remove it entirely instead?
Leaving it as-is should not be an option...


r~
Richard Henderson June 8, 2022, 8:36 p.m. UTC | #5
On 6/8/22 12:05, Richard Henderson wrote:
>> But what is the use case of semihosting on m68k?
>> Is there a kernel implementation available for that?
> 
> Not that I'm aware of.  Do you want to remove it entirely instead?
> Leaving it as-is should not be an option...

Oh, duh.  The "kernel" implementation is libgloss itself.
The use-case is running the gcc testsuite for coldfire under qemu.


r~
Laurent Vivier June 8, 2022, 9:51 p.m. UTC | #6
Le 08/06/2022 à 21:05, Richard Henderson a écrit :
> On 6/8/22 11:08, Laurent Vivier wrote:
>> Le 08/06/2022 à 16:53, Richard Henderson a écrit :
>>> On 6/8/22 02:36, Laurent Vivier wrote:
>>>> Le 08/06/2022 à 00:26, Richard Henderson a écrit :
>>>>> Based-on: <20220607204557.658541-1-richard.henderson@linaro.org>
>>>>> ("[PATCH v4 00/53] semihosting cleanup")
>>>>>
>>>>> Changes for v4:
>>>>>    * Split out of v2.
>>>>>    * Convert host errno to gdb errno, which for m68k is guest errno.
>>>>>
>>>>
>>>> How do you test semihosting on m68k?
>>>
>>> I have only compiled this.  I had been working on adding something to tests/tcg/m68k/, which is 
>>> where those halt patches came from, but haven't finished.
>>>
>>
>> But what is the use case of semihosting on m68k?
>> Is there a kernel implementation available for that?
> 
> Not that I'm aware of.  Do you want to remove it entirely instead?

No, while you fix it I have no problem to keep it.

Thanks,
Laurent