mbox series

[0/3] ARM: s3c: Kconfig: Style cleanups

Message ID 20220523064252.11938-1-juergh@canonical.com
Headers show
Series ARM: s3c: Kconfig: Style cleanups | expand

Message

Juerg Haefliger May 23, 2022, 6:42 a.m. UTC 
The majority of the Kconfig files use a single tab for basic indentation
and a single tab followed by two whitespaces for help text indentation.
Fix the lines that don't follow this convention.

While at it, add missing trailing comments to endif statements and replace
tabs before comments with whitespaces (which seems to be more common).

Juerg Haefliger (3):
  ARM: s3c: Kconfig: Fix indentation
  ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
  ARM: s3c: Kconfig.s3c64xx: Fix indentation

 arch/arm/mach-s3c/Kconfig         | 14 +++++++-------
 arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++--------------
 arch/arm/mach-s3c/Kconfig.s3c64xx | 16 ++++++++--------
 3 files changed, 27 insertions(+), 29 deletions(-)

Comments

Krzysztof Kozlowski June 6, 2022, 9:13 a.m. UTC | #1 
On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:
> The majority of the Kconfig files use a single tab for basic indentation
> and a single tab followed by two whitespaces for help text indentation.
> Fix the lines that don't follow this convention.
> 
> While at it, add missing trailing comments to endif statements and replace
> tabs before comments with whitespaces (which seems to be more common).
> 
> [...]

Applied, thanks!

[1/3] ARM: s3c: Kconfig: Fix indentation
      https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
[3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
      (no commit info)

Best regards,
Krzysztof Kozlowski June 6, 2022, 9:14 a.m. UTC | #2 
On 06/06/2022 11:13, Krzysztof Kozlowski wrote:
> On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:
>> The majority of the Kconfig files use a single tab for basic indentation
>> and a single tab followed by two whitespaces for help text indentation.
>> Fix the lines that don't follow this convention.
>>
>> While at it, add missing trailing comments to endif statements and replace
>> tabs before comments with whitespaces (which seems to be more common).
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/3] ARM: s3c: Kconfig: Fix indentation
>       https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
> [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
>       (no commit info)

...And dropped. This does not pass checkpatch. Please be sure you run
scripts/checkpatch on your contributions.

WARNING: From:/Signed-off-by: email address mismatch: 'From: Juerg
Haefliger <juerg.haefliger@canonical.com>' != 'Signed-off-by: Juerg
Haefliger <juergh@canonical.com>'


Best regards,
Krzysztof
Juerg Haefliger June 7, 2022, 6:59 a.m. UTC | #3 
On Mon, 6 Jun 2022 11:14:28 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 06/06/2022 11:13, Krzysztof Kozlowski wrote:
> > On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:  
> >> The majority of the Kconfig files use a single tab for basic indentation
> >> and a single tab followed by two whitespaces for help text indentation.
> >> Fix the lines that don't follow this convention.
> >>
> >> While at it, add missing trailing comments to endif statements and replace
> >> tabs before comments with whitespaces (which seems to be more common).
> >>
> >> [...]  
> > 
> > Applied, thanks!
> > 
> > [1/3] ARM: s3c: Kconfig: Fix indentation
> >       https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
> > [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
> >       (no commit info)  
> 
> ...And dropped. This does not pass checkpatch. Please be sure you run
> scripts/checkpatch on your contributions.

I did and the check passed but email aliases don't work well in this scenario.
Will fix and resubmit.

...Juerg


> WARNING: From:/Signed-off-by: email address mismatch: 'From: Juerg
> Haefliger <juerg.haefliger@canonical.com>' != 'Signed-off-by: Juerg
> Haefliger <juergh@canonical.com>'
> 
> 
> Best regards,
> Krzysztof