mbox series

[V4,0/6] Preparations to support SD UHS-II cards

Message ID 20220418115833.10738-1-jasonlai.genesyslogic@gmail.com
Headers show
Series Preparations to support SD UHS-II cards | expand

Message

Lai Jason April 18, 2022, 11:58 a.m. UTC
Series [1] that has been posted by Ulf Hansson which provided some
 guidance and an overall structure.

Series [2] focused on UHS-II card control side to address Ulf's intention
 regarding to "modularising" sd_uhs2.c.

Series [3] is based on series [2] and adopt most of Ulf's comments.

Series [4] is based on series [3] and refined by Ulf Hanssion.

This series is the successor version of post [4], which is base on Ulf's
 "wip_uhs_v3" branch:
  1. Implement call back functions in sd_uhs2_ops.
  2. Adopt Ulf's comments for V3.

[1]
https://patchwork.kernel.org/project/linux-mmc/list/?series=438509

[2]
https://patchwork.kernel.org/project/linux-mmc/list/?series=589827

[3]
https://patchwork.kernel.org/project/linux-mmc/list/?series=606241

[4]
https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/log/?h=
wip_uhs_v3

Jason Lai (2):
  mmc: core: Add definitions for SD UHS-II cards
  mmc:core: Support UHS-II card control and access

Ulf Hansson (4):
  mmc: core: Cleanup printing of speed mode at card insertion
  mmc: core: Prepare to support SD UHS-II cards
  mmc: core: Announce successful insertion of an SD UHS-II card
  mmc: core: Extend support for mmc regulators with a vqmmc2

 drivers/mmc/core/Makefile    |    2 +-
 drivers/mmc/core/block.c     |    5 +-
 drivers/mmc/core/bus.c       |   38 +-
 drivers/mmc/core/core.c      |   33 +-
 drivers/mmc/core/core.h      |    1 +
 drivers/mmc/core/host.h      |    4 +
 drivers/mmc/core/mmc_ops.c   |   24 +-
 drivers/mmc/core/mmc_ops.h   |    1 +
 drivers/mmc/core/regulator.c |   34 +
 drivers/mmc/core/sd.c        |   11 +-
 drivers/mmc/core/sd.h        |    3 +
 drivers/mmc/core/sd_ops.c    |    9 +
 drivers/mmc/core/sd_ops.h    |    3 +
 drivers/mmc/core/sd_uhs2.c   | 1377 ++++++++++++++++++++++++++++++++++
 include/linux/mmc/card.h     |   47 ++
 include/linux/mmc/core.h     |   13 +
 include/linux/mmc/host.h     |   83 ++
 include/linux/mmc/sd_uhs2.h  |  263 +++++++
 18 files changed, 1916 insertions(+), 35 deletions(-)
 create mode 100644 drivers/mmc/core/sd_uhs2.c
 create mode 100644 include/linux/mmc/sd_uhs2.h

Comments

Lai Jason June 6, 2022, 7:25 a.m. UTC | #1
Hi Ulf,

Do you have any comments for this patch set?
If you think this patch set is ok, we will proceed to integrate UHS2 host part
of code with this patch set.

kind regards,
Jason Lai

On Mon, Apr 18, 2022 at 7:58 PM Jason Lai
<jasonlai.genesyslogic@gmail.com> wrote:
>
> Series [1] that has been posted by Ulf Hansson which provided some
>  guidance and an overall structure.
>
> Series [2] focused on UHS-II card control side to address Ulf's intention
>  regarding to "modularising" sd_uhs2.c.
>
> Series [3] is based on series [2] and adopt most of Ulf's comments.
>
> Series [4] is based on series [3] and refined by Ulf Hanssion.
>
> This series is the successor version of post [4], which is base on Ulf's
>  "wip_uhs_v3" branch:
>   1. Implement call back functions in sd_uhs2_ops.
>   2. Adopt Ulf's comments for V3.
>
> [1]
> https://patchwork.kernel.org/project/linux-mmc/list/?series=438509
>
> [2]
> https://patchwork.kernel.org/project/linux-mmc/list/?series=589827
>
> [3]
> https://patchwork.kernel.org/project/linux-mmc/list/?series=606241
>
> [4]
> https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/log/?h=
> wip_uhs_v3
>
> Jason Lai (2):
>   mmc: core: Add definitions for SD UHS-II cards
>   mmc:core: Support UHS-II card control and access
>
> Ulf Hansson (4):
>   mmc: core: Cleanup printing of speed mode at card insertion
>   mmc: core: Prepare to support SD UHS-II cards
>   mmc: core: Announce successful insertion of an SD UHS-II card
>   mmc: core: Extend support for mmc regulators with a vqmmc2
>
>  drivers/mmc/core/Makefile    |    2 +-
>  drivers/mmc/core/block.c     |    5 +-
>  drivers/mmc/core/bus.c       |   38 +-
>  drivers/mmc/core/core.c      |   33 +-
>  drivers/mmc/core/core.h      |    1 +
>  drivers/mmc/core/host.h      |    4 +
>  drivers/mmc/core/mmc_ops.c   |   24 +-
>  drivers/mmc/core/mmc_ops.h   |    1 +
>  drivers/mmc/core/regulator.c |   34 +
>  drivers/mmc/core/sd.c        |   11 +-
>  drivers/mmc/core/sd.h        |    3 +
>  drivers/mmc/core/sd_ops.c    |    9 +
>  drivers/mmc/core/sd_ops.h    |    3 +
>  drivers/mmc/core/sd_uhs2.c   | 1377 ++++++++++++++++++++++++++++++++++
>  include/linux/mmc/card.h     |   47 ++
>  include/linux/mmc/core.h     |   13 +
>  include/linux/mmc/host.h     |   83 ++
>  include/linux/mmc/sd_uhs2.h  |  263 +++++++
>  18 files changed, 1916 insertions(+), 35 deletions(-)
>  create mode 100644 drivers/mmc/core/sd_uhs2.c
>  create mode 100644 include/linux/mmc/sd_uhs2.h
>
> --
> 2.35.1
>
Ulf Hansson June 16, 2022, 10:57 p.m. UTC | #2
On Mon, 6 Jun 2022 at 00:25, Lai Jason <jasonlai.genesyslogic@gmail.com> wrote:
>
> Hi Ulf,
>
> Do you have any comments for this patch set?
> If you think this patch set is ok, we will proceed to integrate UHS2 host part
> of code with this patch set.
>
> kind regards,
> Jason Lai

Hi Jason,

My apologies for the delays. Unfortunately I need some additional time
to review this, it has been a busy time for me lately.

Note that, as I said during the earlier review, it looks like it's
time to rebase the host series and thus include that as a part of a
complete series. The reason is simply that I would like to get a
better understanding of how the host driver deployment would look like
too.

I plan to complete the review of the $subject series next week,
although please don't wait for my review if you already have a
complete series ready to be posted, as I would rather review that
instead.

[...]

Kind regards
Uffe