Message ID | 20220523121836.27442-1-ulf.hansson@linaro.org |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] MMC updates for v5.19 | expand |
On Mon, May 23, 2022 at 5:18 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git tags/mmc-v5.19 Please stop doing the horrible undocumented merges. You have three merge commits that have *no* documentation. They say "Merge branch 'fixes' into next", and that's it. If you can't be bothered to explain why and what a merge does, then just don't do it. It really is that simple. I've pulled this, but I really want to stop seeing bad merges. Linus
The pull request you sent on Mon, 23 May 2022 14:18:36 +0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git tags/mmc-v5.19
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/638971b77f1c4fb9997c674ad66d1b96f7931c2b
Thank you!
On Wed, 25 May 2022 at 00:00, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > On Mon, May 23, 2022 at 5:18 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git tags/mmc-v5.19 > > Please stop doing the horrible undocumented merges. > > You have three merge commits that have *no* documentation. They say > "Merge branch 'fixes' into next", and that's it. My bad, I have simply forgotten about them lately. Earlier I was more often doing a re-base of my next branch against some later rc, which makes the merges to disappear from the history. > > If you can't be bothered to explain why and what a merge does, then > just don't do it. > > It really is that simple. > > I've pulled this, but I really want to stop seeing bad merges. Thanks, I will make sure this doesn't happen again, sorry for the inconvenience. > > Linus Kind regards Uffe