| Message ID | 20220503163330.509-1-shameerali.kolothum.thodi@huawei.com |
|---|---|
| Headers | show |
| Series | ACPI/IORT: Support for IORT RMR node | expand |
On 5/3/2022 7:33 PM, Shameer Kolothum wrote: > Hi > > v11 --> v12 > -Minor fix in patch #4 to address the issue reported by the kernel test robot. > -Added R-by tags by Christoph(patch #1) and Lorenzo(patch #4). > -Added T-by from Steve to all relevant patches. Many thanks!. Tested on a NXP LX2160A with SMMUv2, so: Tested-by: Laurentiu Tudor <laurentiu.tudor@nxp.com> --- Thanks & Best Regards, Laurentiu > Please note, this series has a dependency on the ACPICA header patch > here[1]. > > Please take a look and let me know. > > Thanks, > Shameer > [1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F44610361.fMDQidcC6G%40kreacher%2F&data=05%7C01%7Claurentiu.tudor%40nxp.com%7C8157d32925724ac9bf7908da2d22c1ab%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637871924543316157%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=DdYCpg%2B7NW%2Fb8FBYOEsmlYV88kwN0K75AF9Y7%2Fg2BEo%3D&reserved=0 > > From old: > We have faced issues with 3408iMR RAID controller cards which > fail to boot when SMMU is enabled. This is because these > controllers make use of host memory for various caching related > purposes and when SMMU is enabled the iMR firmware fails to > access these memory regions as there is no mapping for them. > IORT RMR provides a way for UEFI to describe and report these > memory regions so that the kernel can make a unity mapping for > these in SMMU. > > Change History: > > v10 --> v11 > -Addressed Christoph's comments. We now have a callback to > struct iommu_resv_region to free all related memory and also dropped > the FW specific union and now has a container struct iommu_iort_rmr_data. > See patches #1 & #4 > -Added R-by from Christoph. > -Dropped R-by from Lorenzo for patches #4 & #5 due to the above changes. > -Also dropped T-by from Steve and Laurentiu. Many thanks for your test > efforts. I have done basic sanity testing on my platform but please > do it again at your end. > > v9 --> v10 > - Dropped patch #1 ("Add temporary RMR node flag definitions") since > the ACPICA header updates patch is now in the mailing list > - Based on the suggestion from Christoph, introduced a > resv_region_free_fw_data() callback in struct iommu_resv_region and > used that to free RMR specific memory allocations. > > v8 --> v9 > - Adressed comments from Robin on interfaces. > - Addressed comments from Lorenzo. > > v7 --> v8 > - Patch #1 has temp definitions for RMR related changes till > the ACPICA header changes are part of kernel. > - No early parsing of RMR node info and is only parsed at the > time of use. > - Changes to the RMR get/put API format compared to the > previous version. > - Support for RMR descriptor shared by multiple stream IDs. > > v6 --> v7 > -fix pointed out by Steve to the SMMUv2 SMR bypass install in patch #8. > > v5 --> v6 > - Addressed comments from Robin & Lorenzo. > : Moved iort_parse_rmr() to acpi_iort_init() from > iort_init_platform_devices(). > : Removed use of struct iort_rmr_entry during the initial > parse. Using struct iommu_resv_region instead. > : Report RMR address alignment and overlap errors, but continue. > : Reworked arm_smmu_init_bypass_stes() (patch # 6). > - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8). > - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based > on Type of RMR region. Suggested by Jon N. > > v4 --> v5 > -Added a fw_data union to struct iommu_resv_region and removed > struct iommu_rmr (Based on comments from Joerg/Robin). > -Added iommu_put_rmrs() to release mem. > -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by > yet because of the above changes. > > v3 -->v4 > -Included the SMMUv2 SMR bypass install changes suggested by > Steve(patch #7) > -As per Robin's comments, RMR reserve implementation is now > more generic (patch #8) and dropped v3 patches 8 and 10. > -Rebase to 5.13-rc1 > > RFC v2 --> v3 > -Dropped RFC tag as the ACPICA header changes are now ready to be > part of 5.13[0]. But this series still has a dependency on that patch. > -Added IORT E.b related changes(node flags, _DSM function 5 checks for > PCIe). > -Changed RMR to stream id mapping from M:N to M:1 as per the spec and > discussion here[1]. > -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!) > > Jon Nettleton (1): > iommu/arm-smmu: Get associated RMR info and install bypass SMR > > Shameer Kolothum (8): > iommu: Introduce a callback to struct iommu_resv_region > ACPI/IORT: Make iort_iommu_msi_get_resv_regions() return void > ACPI/IORT: Provide a generic helper to retrieve reserve regions > ACPI/IORT: Add support to retrieve IORT RMR reserved regions > ACPI/IORT: Add a helper to retrieve RMR info directly > iommu/arm-smmu-v3: Introduce strtab init helper > iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force > bypass > iommu/arm-smmu-v3: Get associated RMR info and install bypass STE > > drivers/acpi/arm64/iort.c | 360 ++++++++++++++++++-- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 78 ++++- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 52 +++ > drivers/iommu/dma-iommu.c | 2 +- > drivers/iommu/iommu.c | 16 +- > include/linux/acpi_iort.h | 14 +- > include/linux/iommu.h | 10 + > 7 files changed, 486 insertions(+), 46 deletions(-) >
On 2022/5/4 0:33, Shameer Kolothum wrote: > Hi > > v11 --> v12 > -Minor fix in patch #4 to address the issue reported by the kernel test robot. > -Added R-by tags by Christoph(patch #1) and Lorenzo(patch #4). > -Added T-by from Steve to all relevant patches. Many thanks!. > > Please note, this series has a dependency on the ACPICA header patch > here[1]. Tested on a Kunpeng920 server machine with SMMUv3, the 3408iMR RAID controller card works as expected, Tested-by: Hanjun Guo <guohanjun@huawei.com> Thanks Hanjun
Hi Joerg/Robin, I think this series is now ready to be merged. Could you please let me know if there is anything missing. Thanks, Shameer > -----Original Message----- > From: Guohanjun (Hanjun Guo) > Sent: 05 May 2022 02:24 > To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>; > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > iommu@lists.linux-foundation.org > Cc: Linuxarm <linuxarm@huawei.com>; lorenzo.pieralisi@arm.com; > joro@8bytes.org; robin.murphy@arm.com; will@kernel.org; wanghuiqiang > <wanghuiqiang@huawei.com>; steven.price@arm.com; > Sami.Mujawar@arm.com; jon@solid-run.com; eric.auger@redhat.com; > laurentiu.tudor@nxp.com; hch@infradead.org > Subject: Re: [PATCH v12 0/9] ACPI/IORT: Support for IORT RMR node > > On 2022/5/4 0:33, Shameer Kolothum wrote: > > Hi > > > > v11 --> v12 > > -Minor fix in patch #4 to address the issue reported by the kernel test > robot. > > -Added R-by tags by Christoph(patch #1) and Lorenzo(patch #4). > > -Added T-by from Steve to all relevant patches. Many thanks!. > > > > Please note, this series has a dependency on the ACPICA header patch > > here[1]. > > Tested on a Kunpeng920 server machine with SMMUv3, the 3408iMR RAID > controller card works as expected, > > Tested-by: Hanjun Guo <guohanjun@huawei.com> > > Thanks > Hanjun
On 2022-05-10 08:23, Shameerali Kolothum Thodi wrote: > Hi Joerg/Robin, > > I think this series is now ready to be merged. Could you please let > me know if there is anything missing. Fine by me - these patches have had enough review and testing now that even if anything else did come up, I think it would be better done as follow-up work on the merged code. Cheers, Robin. > > Thanks, > Shameer > >> -----Original Message----- >> From: Guohanjun (Hanjun Guo) >> Sent: 05 May 2022 02:24 >> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>; >> linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; >> iommu@lists.linux-foundation.org >> Cc: Linuxarm <linuxarm@huawei.com>; lorenzo.pieralisi@arm.com; >> joro@8bytes.org; robin.murphy@arm.com; will@kernel.org; wanghuiqiang >> <wanghuiqiang@huawei.com>; steven.price@arm.com; >> Sami.Mujawar@arm.com; jon@solid-run.com; eric.auger@redhat.com; >> laurentiu.tudor@nxp.com; hch@infradead.org >> Subject: Re: [PATCH v12 0/9] ACPI/IORT: Support for IORT RMR node >> >> On 2022/5/4 0:33, Shameer Kolothum wrote: >>> Hi >>> >>> v11 --> v12 >>> -Minor fix in patch #4 to address the issue reported by the kernel test >> robot. >>> -Added R-by tags by Christoph(patch #1) and Lorenzo(patch #4). >>> -Added T-by from Steve to all relevant patches. Many thanks!. >>> >>> Please note, this series has a dependency on the ACPICA header patch >>> here[1]. >> >> Tested on a Kunpeng920 server machine with SMMUv3, the 3408iMR RAID >> controller card works as expected, >> >> Tested-by: Hanjun Guo <guohanjun@huawei.com> >> >> Thanks >> Hanjun
On Tue, May 10, 2022 at 09:07:00AM +0100, Robin Murphy wrote: > On 2022-05-10 08:23, Shameerali Kolothum Thodi wrote: > > Hi Joerg/Robin, > > > > I think this series is now ready to be merged. Could you please let > > me know if there is anything missing. > > Fine by me - these patches have had enough review and testing now that > even if anything else did come up, I think it would be better done as > follow-up work on the merged code. Given the ACPICA dependency I believe it is best for this series to go via the ACPI tree, right ? I assume there are all the required ACKs for that to happen. Thanks, Lorenzo > Cheers, > Robin. > > > > > Thanks, > > Shameer > > > > > -----Original Message----- > > > From: Guohanjun (Hanjun Guo) > > > Sent: 05 May 2022 02:24 > > > To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>; > > > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > > > iommu@lists.linux-foundation.org > > > Cc: Linuxarm <linuxarm@huawei.com>; lorenzo.pieralisi@arm.com; > > > joro@8bytes.org; robin.murphy@arm.com; will@kernel.org; wanghuiqiang > > > <wanghuiqiang@huawei.com>; steven.price@arm.com; > > > Sami.Mujawar@arm.com; jon@solid-run.com; eric.auger@redhat.com; > > > laurentiu.tudor@nxp.com; hch@infradead.org > > > Subject: Re: [PATCH v12 0/9] ACPI/IORT: Support for IORT RMR node > > > > > > On 2022/5/4 0:33, Shameer Kolothum wrote: > > > > Hi > > > > > > > > v11 --> v12 > > > > -Minor fix in patch #4 to address the issue reported by the kernel test > > > robot. > > > > -Added R-by tags by Christoph(patch #1) and Lorenzo(patch #4). > > > > -Added T-by from Steve to all relevant patches. Many thanks!. > > > > > > > > Please note, this series has a dependency on the ACPICA header patch > > > > here[1]. > > > > > > Tested on a Kunpeng920 server machine with SMMUv3, the 3408iMR RAID > > > controller card works as expected, > > > > > > Tested-by: Hanjun Guo <guohanjun@huawei.com> > > > > > > Thanks > > > Hanjun
[with Christoph's correct email address] On Tue, May 10, 2022 at 09:07:00AM +0100, Robin Murphy wrote: > On 2022-05-10 08:23, Shameerali Kolothum Thodi wrote: > > Hi Joerg/Robin, > > > > I think this series is now ready to be merged. Could you please let > > me know if there is anything missing. > > Fine by me - these patches have had enough review and testing now that > even if anything else did come up, I think it would be better done as > follow-up work on the merged code. Given the ACPICA dependency I believe it is best for this series to go via the ACPI tree, right ? I assume there are all the required ACKs for that to happen. Thanks, Lorenzo > Cheers, > Robin. > > > > > Thanks, > > Shameer > > > > > -----Original Message----- > > > From: Guohanjun (Hanjun Guo) > > > Sent: 05 May 2022 02:24 > > > To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>; > > > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > > > iommu@lists.linux-foundation.org > > > Cc: Linuxarm <linuxarm@huawei.com>; lorenzo.pieralisi@arm.com; > > > joro@8bytes.org; robin.murphy@arm.com; will@kernel.org; wanghuiqiang > > > <wanghuiqiang@huawei.com>; steven.price@arm.com; > > > Sami.Mujawar@arm.com; jon@solid-run.com; eric.auger@redhat.com; > > > laurentiu.tudor@nxp.com; hch@infradead.org > > > Subject: Re: [PATCH v12 0/9] ACPI/IORT: Support for IORT RMR node > > > > > > On 2022/5/4 0:33, Shameer Kolothum wrote: > > > > Hi > > > > > > > > v11 --> v12 > > > > -Minor fix in patch #4 to address the issue reported by the kernel test > > > robot. > > > > -Added R-by tags by Christoph(patch #1) and Lorenzo(patch #4). > > > > -Added T-by from Steve to all relevant patches. Many thanks!. > > > > > > > > Please note, this series has a dependency on the ACPICA header patch > > > > here[1]. > > > > > > Tested on a Kunpeng920 server machine with SMMUv3, the 3408iMR RAID > > > controller card works as expected, > > > > > > Tested-by: Hanjun Guo <guohanjun@huawei.com> > > > > > > Thanks > > > Hanjun
> -----Original Message----- > From: Shameerali Kolothum Thodi > Sent: 17 May 2022 08:18 > To: 'Lorenzo Pieralisi' <lorenzo.pieralisi@arm.com>; Robin Murphy > <robin.murphy@arm.com>; rafael@kernel.org; joro@8bytes.org > Cc: Guohanjun (Hanjun Guo) <guohanjun@huawei.com>; > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > iommu@lists.linux-foundation.org; Linuxarm <linuxarm@huawei.com>; > will@kernel.org; wanghuiqiang <wanghuiqiang@huawei.com>; > steven.price@arm.com; Sami.Mujawar@arm.com; jon@solid-run.com; > eric.auger@redhat.com; laurentiu.tudor@nxp.com; hch@infradead.org > Subject: RE: [PATCH v12 0/9] ACPI/IORT: Support for IORT RMR node > > > > -----Original Message----- > > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] > > Sent: 13 May 2022 10:50 > > To: Robin Murphy <robin.murphy@arm.com>; Shameerali Kolothum Thodi > > <shameerali.kolothum.thodi@huawei.com>; rafael@kernel.org; > > joro@8bytes.org > > Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>; > > Guohanjun (Hanjun Guo) <guohanjun@huawei.com>; > > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > > iommu@lists.linux-foundation.org; Linuxarm <linuxarm@huawei.com>; > > will@kernel.org; wanghuiqiang <wanghuiqiang@huawei.com>; > > steven.price@arm.com; Sami.Mujawar@arm.com; jon@solid-run.com; > > eric.auger@redhat.com; laurentiu.tudor@nxp.com; hch@infradead.org > > Subject: Re: [PATCH v12 0/9] ACPI/IORT: Support for IORT RMR node > > > > [with Christoph's correct email address] > > > > On Tue, May 10, 2022 at 09:07:00AM +0100, Robin Murphy wrote: > > > On 2022-05-10 08:23, Shameerali Kolothum Thodi wrote: > > > > Hi Joerg/Robin, > > > > > > > > I think this series is now ready to be merged. Could you please let > > > > me know if there is anything missing. > > > > > > Fine by me - these patches have had enough review and testing now that > > > even if anything else did come up, I think it would be better done as > > > follow-up work on the merged code. > > > > Given the ACPICA dependency I believe it is best for this series > > to go via the ACPI tree, right ? > > > > I assume there are all the required ACKs for that to happen. > > The SMMUv3/SMMU related changes (patches 6 - 9) still doesn't have > explicit ACK from maintainers other than the go ahead above from Robin. > > Just thought of highlighting it as not sure that will be an issue or not. > All, Just a gentle ping on this series again. Any chance this can make into 5.19? Please consider. Thanks, Shameer