mbox series

[v6,0/4] arm: qcom: qcom-apq8064: add separate device node for tsens

Message ID 20220521151437.1489111-1-dmitry.baryshkov@linaro.org
Headers show
Series arm: qcom: qcom-apq8064: add separate device node for tsens | expand

Message

Dmitry Baryshkov May 21, 2022, 3:14 p.m. UTC
Currently gcc-msm8960 driver manually creates tsens device. Instantiate
the device using DT node instead. This makes the APQ8064 follow the
IPQ8064 device tree schema (which is also closer to the way tsens
devices are described on newer Qualcomm platforms).

Compatibility with the previous devices trees is kept intact.

Changes since v5:
- Inherited the gcc-msm8960 patch from another patchseries.
- Marked old nvmem/thermal sensor properties as deprecated (Krzyshtof).

Changes since v4:
- Added thermal-sensor description to the qcom,gcc-apq8064 schema

Changes since v3:
- Fix a typo qcom,gcc-msm8060 -> qcom,gcc-msm8960 (noted by Krzyshtof)
- Fixed indentation in the example (also noted by Krzyshtof)

Changes since v2:
- Remove patches merged by Daniel
- Rephrase commit messages to emphasize that these changes make apq8064
  follow ipq8064

Changes since v1:
- populate child devices in gcc-msm8960
- add syscon to the gcc device tree node

Dmitry Baryshkov (4):
  dt-bindings: clock: qcom,gcc-apq8064: move msm8960 compat from
    gcc-other.yaml
  dt-bindings: clock: qcom,gcc-apq8064: split tsens to the child node
  clk: qcom: gcc-msm8960: create tsens device if there are no child
    nodes
  arm: dts: qcom-apq8064: create tsens device node

 .../bindings/clock/qcom,gcc-apq8064.yaml      | 40 ++++++++++++++-----
 .../bindings/clock/qcom,gcc-other.yaml        |  5 +--
 arch/arm/boot/dts/qcom-apq8064.dtsi           | 25 ++++++++----
 drivers/clk/qcom/gcc-msm8960.c                |  6 ++-
 4 files changed, 55 insertions(+), 21 deletions(-)

Comments

Krzysztof Kozlowski May 21, 2022, 3:24 p.m. UTC | #1
On 21/05/2022 17:14, Dmitry Baryshkov wrote:
> Split tsens properties to the child node of the gcc. This follows the
> lead of ipq8064 (which also uses a separate node for tsens) and makes
> device tree closer to other platforms, where tsens is a completely
> separate device.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Bjorn Andersson July 7, 2022, 2:31 a.m. UTC | #2
On Sat, 21 May 2022 18:14:33 +0300, Dmitry Baryshkov wrote:
> Currently gcc-msm8960 driver manually creates tsens device. Instantiate
> the device using DT node instead. This makes the APQ8064 follow the
> IPQ8064 device tree schema (which is also closer to the way tsens
> devices are described on newer Qualcomm platforms).
> 
> Compatibility with the previous devices trees is kept intact.
> 
> [...]

Applied, thanks!

[1/4] dt-bindings: clock: qcom,gcc-apq8064: move msm8960 compat from gcc-other.yaml
      commit: 91a4cbf93326f2d27dda7361c43a5bb24cfd93c3
[2/4] dt-bindings: clock: qcom,gcc-apq8064: split tsens to the child node
      commit: 621f984840928f0bd14b20c86b70a15590ed2d3e
[3/4] clk: qcom: gcc-msm8960: create tsens device if there are no child nodes
      commit: 93b793d88da8b2c7afd63c64772666ec4274efad

Best regards,
Dmitry Baryshkov July 15, 2022, 3:12 p.m. UTC | #3
On 07/07/2022 05:31, Bjorn Andersson wrote:
> On Sat, 21 May 2022 18:14:33 +0300, Dmitry Baryshkov wrote:
>> Currently gcc-msm8960 driver manually creates tsens device. Instantiate
>> the device using DT node instead. This makes the APQ8064 follow the
>> IPQ8064 device tree schema (which is also closer to the way tsens
>> devices are described on newer Qualcomm platforms).
>>
>> Compatibility with the previous devices trees is kept intact.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/4] dt-bindings: clock: qcom,gcc-apq8064: move msm8960 compat from gcc-other.yaml
>        commit: 91a4cbf93326f2d27dda7361c43a5bb24cfd93c3
> [2/4] dt-bindings: clock: qcom,gcc-apq8064: split tsens to the child node
>        commit: 621f984840928f0bd14b20c86b70a15590ed2d3e
> [3/4] clk: qcom: gcc-msm8960: create tsens device if there are no child nodes
>        commit: 93b793d88da8b2c7afd63c64772666ec4274efad

I hope to see patch 4/4 to be also picked up at some point...