| Message ID | 20220517133450.2266243-1-yangyingliang@huawei.com |
|---|---|
| State | Accepted |
| Commit | 72d67d6b3447303a441a8cedc34f7224b75f64b5 |
| Headers | show |
| Series | [-next] cpufreq: mediatek: fix error return code in mtk_cpu_dvfs_info_init() | expand |
On Tue, 2022-05-17 at 21:34 +0800, Yang Yingliang wrote: > If regulator_get_voltage() fails, it should return the error code in > mtk_cpu_dvfs_info_init(). > > Fixes: 0daa47325bae ("cpufreq: mediatek: Link CCI device to CPU") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/cpufreq/mediatek-cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/mediatek-cpufreq.c > b/drivers/cpufreq/mediatek-cpufreq.c > index 37a1eb20f5ba..3a2be4552020 100644 > --- a/drivers/cpufreq/mediatek-cpufreq.c > +++ b/drivers/cpufreq/mediatek-cpufreq.c > @@ -474,6 +474,7 @@ static int mtk_cpu_dvfs_info_init(struct > mtk_cpu_dvfs_info *info, int cpu) > if (info->soc_data->ccifreq_supported) { > info->vproc_on_boot = regulator_get_voltage(info- > >proc_reg); > if (info->vproc_on_boot < 0) { > + ret = info->vproc_on_boot; > dev_err(info->cpu_dev, > "invalid Vproc value: %d\n", info- > >vproc_on_boot); > goto out_disable_inter_clock; Thanks for fix this! Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c index 37a1eb20f5ba..3a2be4552020 100644 --- a/drivers/cpufreq/mediatek-cpufreq.c +++ b/drivers/cpufreq/mediatek-cpufreq.c @@ -474,6 +474,7 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu) if (info->soc_data->ccifreq_supported) { info->vproc_on_boot = regulator_get_voltage(info->proc_reg); if (info->vproc_on_boot < 0) { + ret = info->vproc_on_boot; dev_err(info->cpu_dev, "invalid Vproc value: %d\n", info->vproc_on_boot); goto out_disable_inter_clock;
If regulator_get_voltage() fails, it should return the error code in mtk_cpu_dvfs_info_init(). Fixes: 0daa47325bae ("cpufreq: mediatek: Link CCI device to CPU") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/cpufreq/mediatek-cpufreq.c | 1 + 1 file changed, 1 insertion(+)