| Message ID | 20220512090429.2.I1318c1ae2ce55ade1d092fc21df846360b15c560@changeid |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings | expand |
On Thu, 12 May 2022 09:04:46 -0700, Douglas Anderson wrote: > This copy-pastes compatibles from sc7280-based boards from the device > trees to the yaml file. It also fixes the CRD/IDP bindings which had > gotten stale. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > .../devicetree/bindings/arm/qcom.yaml | 40 +++++++++++++++---- > 1 file changed, 33 insertions(+), 7 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ /: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dtb arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dtb arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dtb arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dtb arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dtb arch/arm64/boot/dts/qcom/msm8916-mtp.dtb arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dtb arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dtb arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dtb arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dtb arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dtb arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dtb arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dtb arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dtb arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dtb arch/arm64/boot/dts/qcom/sc7280-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dtb arch/arm64/boot/dts/qcom/sm8150-hdk.dtb arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dtb arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dtb arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dtb arch/arm64/boot/dts/qcom/sm8250-hdk.dtb arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dtb arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dtb arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dtb arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dtb arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dtb arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dtb
Hi, On Fri, May 13, 2022 at 5:33 AM Rob Herring <robh@kernel.org> wrote: > > On Thu, 12 May 2022 09:04:46 -0700, Douglas Anderson wrote: > > This copy-pastes compatibles from sc7280-based boards from the device > > trees to the yaml file. It also fixes the CRD/IDP bindings which had > > gotten stale. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > .../devicetree/bindings/arm/qcom.yaml | 40 +++++++++++++++---- > > 1 file changed, 33 insertions(+), 7 deletions(-) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > /: compatible: 'oneOf' conditional failed, one must be fixed: [...] > arch/arm64/boot/dts/qcom/sc7280-crd.dtb > arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dtb Looking explicitly at these, since sc7280 boards were supposed to have been fixed. Ah, I see. herobrine-r0 was removed recently, and the crd compatibles were rejiggered. ...so this makes sense. I'll expect that it will be resolved when the current Qualcomm tree makes it to mainline. -Doug
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 399be67eb5d2..c7ab028d54a0 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -399,14 +399,40 @@ properties: - const: google,trogdor-sku0 - const: qcom,sc7180 + # Qualcomm Technologies, Inc. sc7280 CRD platform (rev3 - 4) - items: - - enum: - - qcom,sc7280-crd - - qcom,sc7280-idp - - qcom,sc7280-idp2 - - google,hoglin - - google,piglin - - google,senor + - const: qcom,sc7280-crd + - const: google,hoglin-rev3 + - const: google,hoglin-rev4 + - const: google,piglin-rev3 + - const: google,piglin-rev4 + - const: qcom,sc7280 + + # Qualcomm Technologies, Inc. sc7280 CRD platform (newest rev) + - items: + - const: google,hoglin + - const: qcom,sc7280 + + # Qualcomm Technologies, Inc. sc7280 IDP SKU1 platform + - items: + - const: qcom,sc7280-idp + - const: google,senor + - const: qcom,sc7280 + + # Qualcomm Technologies, Inc. sc7280 IDP SKU2 platform + - items: + - const: qcom,sc7280-idp2 + - const: google,piglin + - const: qcom,sc7280 + + # Google Herobrine (newest rev) + - items: + - const: google,herobrine + - const: qcom,sc7280 + + # Google Villager (newest rev) + - items: + - const: google,villager - const: qcom,sc7280 - items:
This copy-pastes compatibles from sc7280-based boards from the device trees to the yaml file. It also fixes the CRD/IDP bindings which had gotten stale. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- .../devicetree/bindings/arm/qcom.yaml | 40 +++++++++++++++---- 1 file changed, 33 insertions(+), 7 deletions(-)