| Message ID | 20220510114852.1719018-1-zheyuma97@gmail.com |
|---|---|
| State | Accepted |
| Commit | 9bc92332cc3f06fda3c6e2423995ca2da0a7ec9a |
| Headers | show |
| Series | media: imx214: Fix the error handling in imx214_probe() | expand |
On Wed, May 11, 2022 at 8:19 PM Ricardo Ribalda Delgado <ribalda@kernel.org> wrote: > > Hi Zheyu > > Do you have seen this issue in a real hardware? The device enters > idle state unconditionally after power_on during probe. > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/imx214.c#n1008 Actually I didn't, I found the "bug" manually. Thanks for your reminder and sorry for the false alarm. Zheyu Ma
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 83c1737abeec..61eeaefd4298 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -1076,6 +1076,7 @@ static int imx214_probe(struct i2c_client *client) mutex_destroy(&imx214->mutex); v4l2_ctrl_handler_free(&imx214->ctrls); pm_runtime_disable(imx214->dev); + regulator_bulk_disable(IMX214_NUM_SUPPLIES, imx214->supplies); return ret; }
The driver should disable regulators when fails to probe. Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> --- drivers/media/i2c/imx214.c | 1 + 1 file changed, 1 insertion(+)