| Message ID | 20220504183131.52728-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | leds: is31fl32xx: Improve error reporting in .remove() | expand |
Hi! > Returning an error value in an i2c remove callback results in a generic > error message being emitted by the i2c core, but otherwise it doesn't make > a difference. The device goes away anyhow and the devm cleanups are > called. > > So instead of triggering the generic i2c error message, emit a more helpful > message if a problem occurs and return 0 to suppress the generic message. > > This patch is a preparation for making i2c remove callbacks return void. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thank you, applied. Pavel
diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 22c092a4394a..fc63fce38c19 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -460,8 +460,14 @@ static int is31fl32xx_probe(struct i2c_client *client, static int is31fl32xx_remove(struct i2c_client *client) { struct is31fl32xx_priv *priv = i2c_get_clientdata(client); + int ret; - return is31fl32xx_reset_regs(priv); + ret = is31fl32xx_reset_regs(priv); + if (ret) + dev_err(&client->dev, "Failed to reset registers on removal (%pe)\n", + ERR_PTR(ret)); + + return 0; } /*
Returning an error value in an i2c remove callback results in a generic error message being emitted by the i2c core, but otherwise it doesn't make a difference. The device goes away anyhow and the devm cleanups are called. So instead of triggering the generic i2c error message, emit a more helpful message if a problem occurs and return 0 to suppress the generic message. This patch is a preparation for making i2c remove callbacks return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/leds/leds-is31fl32xx.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) base-commit: 3123109284176b1532874591f7c81f3837bbdc17