diff mbox series

KVM: selftests: riscv: Remove unneeded semicolon

Message ID 20220506094512.116729-1-jiapeng.chong@linux.alibaba.com
State Accepted
Commit dba90d6fb8b0657d45516bfe1eb8fe83d9e425f8
Headers show
Series KVM: selftests: riscv: Remove unneeded semicolon | expand

Commit Message

Jiapeng Chong May 6, 2022, 9:45 a.m. UTC
Fix the following coccicheck warnings:

./tools/testing/selftests/kvm/lib/riscv/processor.c:353:3-4: Unneeded
semicolon.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 tools/testing/selftests/kvm/lib/riscv/processor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anup Patel May 9, 2022, 5:07 a.m. UTC | #1
On Fri, May 6, 2022 at 3:15 PM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./tools/testing/selftests/kvm/lib/riscv/processor.c:353:3-4: Unneeded
> semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

In future, please CC kvm-riscv@lists.infradead.org for KVM RISC-V related
patches.

I have queued this patch for 5.19

Thanks,
Anup

> ---
>  tools/testing/selftests/kvm/lib/riscv/processor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/riscv/processor.c b/tools/testing/selftests/kvm/lib/riscv/processor.c
> index 3961487a4870..e17333518af2 100644
> --- a/tools/testing/selftests/kvm/lib/riscv/processor.c
> +++ b/tools/testing/selftests/kvm/lib/riscv/processor.c
> @@ -350,7 +350,7 @@ void vcpu_args_set(struct kvm_vm *vm, uint32_t vcpuid, unsigned int num, ...)
>                 case 7:
>                         id = RISCV_CORE_REG(regs.a7);
>                         break;
> -               };
> +               }
>                 set_reg(vm, vcpuid, id, va_arg(ap, uint64_t));
>         }
>
> --
> 2.20.1.7.g153144c
>
Joe Perches May 9, 2022, 5:36 a.m. UTC | #2
On Mon, 2022-05-09 at 10:37 +0530, Anup Patel wrote:
> On Fri, May 6, 2022 at 3:15 PM Jiapeng Chong
> <jiapeng.chong@linux.alibaba.com> wrote:
> > 
> > Fix the following coccicheck warnings:
> > 
> > ./tools/testing/selftests/kvm/lib/riscv/processor.c:353:3-4: Unneeded
> > semicolon.
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> 
> In future, please CC kvm-riscv@lists.infradead.org for KVM RISC-V related
> patches.

Perhaps add or update some MAINTAINERS entry as this list is not
currently specified by:

$ ./scripts/get_maintainer.pl -f tools/testing/selftests/kvm/lib/riscv/processor.c --nogit --nogit-fallback
Paolo Bonzini <pbonzini@redhat.com> (supporter:KERNEL VIRTUAL MACHINE (KVM))
Shuah Khan <shuah@kernel.org> (maintainer:KERNEL SELFTEST FRAMEWORK)
Paul Walmsley <paul.walmsley@sifive.com> (supporter:RISC-V ARCHITECTURE)
Palmer Dabbelt <palmer@dabbelt.com> (supporter:RISC-V ARCHITECTURE)
Albert Ou <aou@eecs.berkeley.edu> (supporter:RISC-V ARCHITECTURE)
kvm@vger.kernel.org (open list:KERNEL VIRTUAL MACHINE (KVM))
linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK)
linux-riscv@lists.infradead.org (open list:RISC-V ARCHITECTURE)
linux-kernel@vger.kernel.org (open list)
$
Anup Patel May 9, 2022, 5:47 a.m. UTC | #3
On Mon, May 9, 2022 at 11:06 AM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2022-05-09 at 10:37 +0530, Anup Patel wrote:
> > On Fri, May 6, 2022 at 3:15 PM Jiapeng Chong
> > <jiapeng.chong@linux.alibaba.com> wrote:
> > >
> > > Fix the following coccicheck warnings:
> > >
> > > ./tools/testing/selftests/kvm/lib/riscv/processor.c:353:3-4: Unneeded
> > > semicolon.
> > >
> > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> >
> > In future, please CC kvm-riscv@lists.infradead.org for KVM RISC-V related
> > patches.
>
> Perhaps add or update some MAINTAINERS entry as this list is not
> currently specified by:
>
> $ ./scripts/get_maintainer.pl -f tools/testing/selftests/kvm/lib/riscv/processor.c --nogit --nogit-fallback
> Paolo Bonzini <pbonzini@redhat.com> (supporter:KERNEL VIRTUAL MACHINE (KVM))
> Shuah Khan <shuah@kernel.org> (maintainer:KERNEL SELFTEST FRAMEWORK)
> Paul Walmsley <paul.walmsley@sifive.com> (supporter:RISC-V ARCHITECTURE)
> Palmer Dabbelt <palmer@dabbelt.com> (supporter:RISC-V ARCHITECTURE)
> Albert Ou <aou@eecs.berkeley.edu> (supporter:RISC-V ARCHITECTURE)
> kvm@vger.kernel.org (open list:KERNEL VIRTUAL MACHINE (KVM))
> linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK)
> linux-riscv@lists.infradead.org (open list:RISC-V ARCHITECTURE)
> linux-kernel@vger.kernel.org (open list)
> $

Ahh, I see. I will certainly update the MAINTAINERS entry for
KVM RISC-V selftests.

Thanks,
Anup

>
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/kvm/lib/riscv/processor.c b/tools/testing/selftests/kvm/lib/riscv/processor.c
index 3961487a4870..e17333518af2 100644
--- a/tools/testing/selftests/kvm/lib/riscv/processor.c
+++ b/tools/testing/selftests/kvm/lib/riscv/processor.c
@@ -350,7 +350,7 @@  void vcpu_args_set(struct kvm_vm *vm, uint32_t vcpuid, unsigned int num, ...)
 		case 7:
 			id = RISCV_CORE_REG(regs.a7);
 			break;
-		};
+		}
 		set_reg(vm, vcpuid, id, va_arg(ap, uint64_t));
 	}