mbox series

[v7,0/2] Make AUX gpio pin optional for ktd2692

Message ID 20220504193439.15938-1-markuss.broks@gmail.com
Headers show
Series Make AUX gpio pin optional for ktd2692 | expand

Message

Markuss Broks May 4, 2022, 7:34 p.m. UTC 
Some appliances of ktd2692 don't have the AUX pin connected to
a GPIO. Specifically, Samsung Galaxy J5 (2015), which uses ktd2692
for driving the front flash LED, has the pin not connected anywhere on
schematics. Make specifying the AUX pin optional, since it is additional
functionality and only affects amount of current going through the LED.

Also convert the txt device-tree bindings to yaml and pick up maintenance
over the yaml binding and the driver itself.

v2:
- fix the dt_binding_check
v3:
- set the aux_gpio to NULL to avoid passing ERR_PTR as a gpio
v4:
- maintainership -> maintenance (description)
- remove the if (led->aux_gpio)
- use devm_gpiod_get_optional for aux gpio
v5:
- use ret to pass a correct error return code (Christophe)
v6:
- use PTR_ERR properly (when IS_ERR is true) (Christophe)
v6-a:
- ended up being a mess, corrected-v2 should have proper tags now
v7:
- drop the MAINTAINERS part

Markuss Broks (2):
  dt-bindings: leds: convert ktd2692 bindings to yaml
  leds: ktd2692: Make aux-gpios optional

 .../bindings/leds/kinetic,ktd2692.yaml        | 87 +++++++++++++++++++
 .../devicetree/bindings/leds/leds-ktd2692.txt | 50 -----------
 MAINTAINERS                                   |  6 ++
 drivers/leds/flash/leds-ktd2692.c             | 18 ++--
 4 files changed, 103 insertions(+), 58 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml
 delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt

Comments

Markuss Broks May 4, 2022, 7:50 p.m. UTC | #1 
Hi Andy,

On 5/4/22 22:44, Andy Shevchenko wrote:
> On Wed, May 4, 2022 at 9:35 PM Markuss Broks <markuss.broks@gmail.com> wrote:
>> Some appliances of ktd2692 don't have the AUX pin connected to
>> a GPIO. Specifically, Samsung Galaxy J5 (2015), which uses ktd2692
>> for driving the front flash LED, has the pin not connected anywhere on
>> schematics. Make specifying the AUX pin optional, since it is additional
>> functionality and only affects amount of current going through the LED.
> the amount
>
>> Also convert the txt device-tree bindings to yaml and pick up maintenance
>> over the yaml binding and the driver itself.
> ...
>
>> v7:
>> - drop the MAINTAINERS part
> I'm not sure why it happened.
Pavel asked me to drop the MAINTAINERS part for now.
>
> What I mentioned is to create a series out of 4 (four) patches:
> 1) fix the potential issue with the repetitive message;
Bummer, totally forgot about that, thank you for a reminder!
> 2) update DT;
> 3) switch to optional GPIO;
> 4) update MAINTAINERS.
>
>
- Markuss
Andy Shevchenko May 4, 2022, 7:55 p.m. UTC | #2 
On Wed, May 4, 2022 at 9:50 PM Pavel Machek <pavel@ucw.cz> wrote:
> > > v7:
> > > - drop the MAINTAINERS part
> >
> > I'm not sure why it happened.
> >
> > 4) update MAINTAINERS.
>
> I asked for that one.
>
> If there's no other problem, I can take the series.

Ah, thanks for clarification.
As I mentioned before, it would be really nice to have a fix-patch
prepending this series. That said, this series needs to be rebased on
it.