mbox series

[v3,00/12] initial clock support for exynosauto v9 SoC

Message ID 20220504075154.58819-1-chanho61.park@samsung.com
Headers show
Series initial clock support for exynosauto v9 SoC | expand

Message

Chanho Park May 4, 2022, 7:51 a.m. UTC 
This patchset adds initial clock driver support for Exynos Auto v9 SoC.
This driver is highly inspired from exynos850 clock driver. Like
exynos850, this does not use Q-channel control & Hardware automatic
clock gating. So, all the gate clocks will be controlled by CCF & CMU
driver.

Below CMU blocks are supported in this patchset and remains will be
implemented later.

- CMU_TOP
- CMU_BUSMC
- CMU_CORE
- CMU_FSYS2
- CMU_PERIC0
- CMU_PERIC1
- CMU_PERIS

Changes from v2:
- Correct include file path of dt-binding and use full-path
- Reorder clock nodes by unit address

Changes from v1:
- Adjust patch order to avoid dt-binding check bot's build warning
- Rename exynosautov9.h to samsung,exynosautov9.h (Suggested by
  Krzystof)
- clock nodes of exynosautov9.dtsi are aligned by unit address order.
- Each clock items are listed to every own line.
- Added Krzystof RB tags.

Chanho Park (12):
  dt-bindings: clock: add clock binding definitions for Exynos Auto v9
  dt-bindings: clock: add Exynos Auto v9 SoC CMU bindings
  clk: samsung: add top clock support for Exynos Auto v9 SoC
  clk: samsung: exynosautov9: add cmu_core clock support
  clk: samsung: exynosautov9: add cmu_peris clock support
  clk: samsung: exynosautov9: add cmu_busmc clock support
  clk: samsung: exynosautov9: add cmu_fsys2 clock support
  clk: samsung: exynosautov9: add cmu_peric0 clock support
  clk: samsung: exynosautov9: add cmu_peric1 clock support
  arm64: dts: exynosautov9: add initial cmu clock nodes
  arm64: dts: exynosautov9: switch usi clocks
  arm64: dts: exynosautov9: switch ufs clock node

 .../clock/samsung,exynosautov9-clock.yaml     |  219 +++
 arch/arm64/boot/dts/exynos/exynosautov9.dtsi  |  115 +-
 drivers/clk/samsung/Makefile                  |    1 +
 drivers/clk/samsung/clk-exynosautov9.c        | 1733 +++++++++++++++++
 .../dt-bindings/clock/samsung,exynosautov9.h  |  299 +++
 5 files changed, 2342 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
 create mode 100644 drivers/clk/samsung/clk-exynosautov9.c
 create mode 100644 include/dt-bindings/clock/samsung,exynosautov9.h

Comments

Chanwoo Choi May 4, 2022, 1:05 p.m. UTC | #1 
Hi Chanho,

On 22. 5. 4. 16:51, Chanho Park wrote:
> Add device tree clock binding definitions for below CMU blocks.
> 
> - CMU_TOP
> - CMU_BUSMC
> - CMU_CORE
> - CMU_FYS2
> - CMU_PERIC0 / C1
> - CMU_PERIS
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>   .../dt-bindings/clock/samsung,exynosautov9.h  | 299 ++++++++++++++++++
>   1 file changed, 299 insertions(+)
>   create mode 100644 include/dt-bindings/clock/samsung,exynosautov9.h
> 

(snip)

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Krzysztof Kozlowski May 4, 2022, 2:36 p.m. UTC | #2 
On 04/05/2022 09:51, Chanho Park wrote:
> Add device tree clock binding definitions for below CMU blocks.
> 
> - CMU_TOP
> - CMU_BUSMC
> - CMU_CORE
> - CMU_FYS2
> - CMU_PERIC0 / C1
> - CMU_PERIS
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>  .../dt-bindings/clock/samsung,exynosautov9.h  | 299 ++++++++++++++++++

Hi Sylwester,

If I am to apply the DTS, which uses this header, I would need to take
it via my tree and send you a pull request with it.

Otherwise the DTS would need to be modified to have workaround-defines
for missing header.

Best regards,
Krzysztof
Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics May 4, 2022, 3:11 p.m. UTC | #3 
Hi,

On 04.05.2022 16:36, Krzysztof Kozlowski wrote:
> On 04/05/2022 09:51, Chanho Park wrote:
>> Add device tree clock binding definitions for below CMU blocks.
>>
>> - CMU_TOP
>> - CMU_BUSMC
>> - CMU_CORE
>> - CMU_FYS2
>> - CMU_PERIC0 / C1
>> - CMU_PERIS
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>> ---
>>  .../dt-bindings/clock/samsung,exynosautov9.h  | 299 ++++++++++++++++++
> 
> Hi Sylwester,
> 
> If I am to apply the DTS, which uses this header, I would need to take
> it via my tree and send you a pull request with it.

Let's do it that way, please provide a pull request with the header.


Regards,
Sylwester
Chanwoo Choi May 4, 2022, 5:32 p.m. UTC | #4 
On 22. 5. 4. 16:51, Chanho Park wrote:
> This adds support for CMU_TOP which generates clocks for all the
> function blocks such as CORE, FSYS0/1/2, PERIC0/1 and so on. For
> CMU_TOP, PLL_SHARED0,1,2,3 and 4 will be the sources of this block
> and they will generate bus clocks.
> 
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>   drivers/clk/samsung/Makefile           |   1 +
>   drivers/clk/samsung/clk-exynosautov9.c | 958 +++++++++++++++++++++++++
>   2 files changed, 959 insertions(+)
>   create mode 100644 drivers/clk/samsung/clk-exynosautov9.c
> 

(snip)

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Chanwoo Choi May 4, 2022, 5:33 p.m. UTC | #5 
On 22. 5. 4. 16:51, Chanho Park wrote:
> Like CMU_PERIC0, this provides clocks for USI06 ~ USI11 and USI_I2C.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>   drivers/clk/samsung/clk-exynosautov9.c | 254 +++++++++++++++++++++++++
>   1 file changed, 254 insertions(+)
> 

(snip)

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Krzysztof Kozlowski May 5, 2022, 6:59 a.m. UTC | #6 
On Wed, 4 May 2022 16:51:43 +0900, Chanho Park wrote:
> Add device tree clock binding definitions for below CMU blocks.
> 
> - CMU_TOP
> - CMU_BUSMC
> - CMU_CORE
> - CMU_FYS2
> - CMU_PERIC0 / C1
> - CMU_PERIS
> 
> [...]

Applied, thanks!

[01/12] dt-bindings: clock: add clock binding definitions for Exynos Auto v9
        commit: 680e1c8370a2ed7aff4f99ce3cebf79873d68f59

Best regards,
Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics May 10, 2022, 6:07 p.m. UTC | #7 
On 04.05.2022 09:51, Chanho Park wrote:
> This patchset adds initial clock driver support for Exynos Auto v9 SoC.

Thanks, I have applied patches 04...09/12.

Regards,
Sylwester