| Message ID | 20220423125618.1916005-1-trix@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | fbcon: change fbcon_*registered_fb variables to static | expand |
On Sat, Apr 23, 2022 at 08:56:18AM -0400, Tom Rix wrote: > Sparse reports these issues > fbcon.c:106:16: warning: symbol 'fbcon_registered_fb' was not declared. Should it be static? > fbcon.c:107:5: warning: symbol 'fbcon_num_registered_fb' was not declared. Should it be static? > > These variables are only used in fbcon.c. Single file use variables should > be static, so change their storage-class specifiers to static. > > Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> > --- > drivers/video/fbdev/core/fbcon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > index c4e91715ef00..225ac0fe0143 100644 > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -103,8 +103,8 @@ enum { > > static struct fbcon_display fb_display[MAX_NR_CONSOLES]; > > -struct fb_info *fbcon_registered_fb[FB_MAX]; > -int fbcon_num_registered_fb; > +static struct fb_info *fbcon_registered_fb[FB_MAX]; > +static int fbcon_num_registered_fb; > > #define fbcon_for_each_registered_fb(i) \ > for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \ > -- > 2.27.0
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index c4e91715ef00..225ac0fe0143 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -103,8 +103,8 @@ enum { static struct fbcon_display fb_display[MAX_NR_CONSOLES]; -struct fb_info *fbcon_registered_fb[FB_MAX]; -int fbcon_num_registered_fb; +static struct fb_info *fbcon_registered_fb[FB_MAX]; +static int fbcon_num_registered_fb; #define fbcon_for_each_registered_fb(i) \ for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \
Sparse reports these issues fbcon.c:106:16: warning: symbol 'fbcon_registered_fb' was not declared. Should it be static? fbcon.c:107:5: warning: symbol 'fbcon_num_registered_fb' was not declared. Should it be static? These variables are only used in fbcon.c. Single file use variables should be static, so change their storage-class specifiers to static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/video/fbdev/core/fbcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)