| Message ID | 20220422192355.2597523-1-robh@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible | expand |
On 22/04/2022 21:23, Rob Herring wrote: > The samsung,s524ad0xd1 compatible is in use, but not documented. According > to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible > with the 24c128. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > The compatible - without 24c128 fallback - is used also in arch/arm/boot/dts/exynos5250-smdk5250.dts and Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml, so these files should be fixed as well. Best regards, Krzysztof
On Sat, Apr 23, 2022 at 08:44:21PM +0200, Krzysztof Kozlowski wrote: > On 22/04/2022 21:23, Rob Herring wrote: > > The samsung,s524ad0xd1 compatible is in use, but not documented. According > > to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible > > with the 24c128. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > The compatible - without 24c128 fallback - is used also in > arch/arm/boot/dts/exynos5250-smdk5250.dts and > Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml, so these > files should be fixed as well. The dts file I was aware of and I leave that to the Exynos maintainers/users. :) For some reason samsung,s3c2410-i2c.yaml is not getting a warning. I'll have to investigate. Rob
diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml index 6b61a8cf6137..d14e0accbda8 100644 --- a/Documentation/devicetree/bindings/eeprom/at24.yaml +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml @@ -120,7 +120,9 @@ properties: - const: giantec,gt24c32a - const: atmel,24c32 - items: - - const: renesas,r1ex24128 + - enum: + - renesas,r1ex24128 + - samsung,s524ad0xd1 - const: atmel,24c128 label:
The samsung,s524ad0xd1 compatible is in use, but not documented. According to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible with the 24c128. Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)