| Message ID | 20220422133803.989256-1-chris.obbard@collabora.com |
|---|---|
| Headers | show |
| Series | Rockchip RK3328 VDEC support | expand |
On 23/04/2022 13:10, Krzysztof Kozlowski wrote: > On 22/04/2022 15:38, Christopher Obbard wrote: >> Document the RK3328 compatible for rockchip-vdec. >> >> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com> >> --- >> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 + >> 1 file changed, 1 insertion(+) > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> I acked this but Johan pointed out that your intention was different and missing patch context is quite important here. Please explain what exactly you wanted in the patch? Now it looks actually wrong, so my ack is not correct. Best regards, Krzysztof
On 23/04/2022 18:31, Krzysztof Kozlowski wrote: > On 23/04/2022 13:10, Krzysztof Kozlowski wrote: >> On 22/04/2022 15:38, Christopher Obbard wrote: >>> Document the RK3328 compatible for rockchip-vdec. >>> >>> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com> >>> --- >>> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 + >>> 1 file changed, 1 insertion(+) >> >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > I acked this but Johan pointed out that your intention was different and > missing patch context is quite important here. Please explain what > exactly you wanted in the patch? Now it looks actually wrong, so my ack > is not correct. Wow - I think i was in weekend mode and forgot to run dtbs_check ;-). It will be solved in v2. I have now added the check to my "pre send-patch" review checklist. Just out of interest, I didn't get a mail from Johan and I can't seem to find it the archive either. Is that message in public as I'd like to address any other concerns at the same time ? Cheers! Chris
On 25/04/2022 11:53, Christopher Obbard wrote: >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> I acked this but Johan pointed out that your intention was different and >> missing patch context is quite important here. Please explain what >> exactly you wanted in the patch? Now it looks actually wrong, so my ack >> is not correct. > > Wow - I think i was in weekend mode and forgot to run dtbs_check ;-). > It will be solved in v2. I have now added the check to my "pre > send-patch" review checklist. > > Just out of interest, I didn't get a mail from Johan and I can't seem to > find it the archive either. Is that message in public as I'd like to > address any other concerns at the same time ? No, it wasn't public. :( Best regards, Krzysztof
This series adds VDEC support for the Rockchip RK3328 SoC which uses the staging rkvdec driver. Testing was performed using both v4l-compliance and (mainline) gstreamer using the fluster framework. I can include full test results if that would be useful. $ v4l2-compliance -m0 v4l2-compliance 1.22.1, 64 bits, 64-bit time_t ... Grand Total for rkvdec device /dev/media0: 54, Succeeded: 54, Failed: 0, Warnings: 0 $ python3 fluster.py run -j1 -ts JVT-AVC_V1 -d GStreamer-H.264-V4L2SL-Gst1.0 ... Ran 111/135 tests successfully in 392.885 secs $ python3 fluster.py run -j1 -ts VP9-TEST-VECTORS -d GStreamer-VP9-V4L2SL-Gst1.0 ... Ran 206/303 tests successfully in 1170.120 secs Cheers, Chris Christopher Obbard (3): media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible arm64: dts: rockchip: Rename vdec_mmu node for RK3328 arm64: dts: rockchip: Add vdec support for RK3328 .../bindings/media/rockchip,vdec.yaml | 1 + arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 +++++++++++++++++-- 2 files changed, 26 insertions(+), 2 deletions(-)