diff mbox series

[v2,1/3] dt-bindings: net: qcom,ipa: fix example for upcomming smp2p conversion

Message ID 20220424131522.14185-1-david@ixit.cz
State New
Headers show
Series [v2,1/3] dt-bindings: net: qcom,ipa: fix example for upcomming smp2p conversion | expand

Commit Message

David Heidelberg April 24, 2022, 1:15 p.m. UTC
Example of mpss was missing required properties.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/net/qcom,ipa.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski April 24, 2022, 2:43 p.m. UTC | #1
On 24/04/2022 15:15, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
> 
> Misc: adjusted examples properties formatting from dtsi.

I don't get the "misc:" comment. What is it about?

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
David Heidelberg April 25, 2022, 7:51 a.m. UTC | #2
On 24/04/2022 16:43, Krzysztof Kozlowski wrote:
> On 24/04/2022 15:15, David Heidelberg wrote:
>> These missing required properties are needed for
>> smp2p binding reference checks.
>>
>> Misc: adjusted examples properties formatting from dtsi.
> I don't get the "misc:" comment. What is it about?
I used same formatting as in dtsi where the node is used (cosmetic change).
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks
>
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index 58ecc62adfaa..852658b4d05c 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -182,6 +182,11 @@  examples:
 
         smp2p-mpss {
                 compatible = "qcom,smp2p";
+                mboxes = <&apss_shared 14>;
+                qcom,smem = <435>, <428>;
+                qcom,local-pid = <0>;
+                qcom,remote-pid = <1>;
+
                 ipa_smp2p_out: ipa-ap-to-modem {
                         qcom,entry-name = "ipa";
                         #qcom,smem-state-cells = <1>;