| Message ID | 20220422141029.968212-1-daniel.lezcano@linaro.org |
|---|---|
| State | Accepted |
| Commit | 5a42ac43d0c900ade2a5c0337b2ea52d994bdec8 |
| Headers | show |
| Series | [1/2] Revert "thermal/core: Deprecate changing cooling device state from userspace" | expand |
On Fri, Apr 22, 2022 at 4:11 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > This reverts commit a67a46af4ad6342378e332b7420c1d1a2818c53f. > > It has been reported the warning is annoying as the cooling device > state is still needed on some production system. > > Meanwhile we provide a way to consolidate the thermal framework to > prevent multiple actors acting on the cooling devices with conflicting > decisions, let's revert this warning. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/thermal/thermal_sysfs.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c > index f154bada2906..1c4aac8464a7 100644 > --- a/drivers/thermal/thermal_sysfs.c > +++ b/drivers/thermal/thermal_sysfs.c > @@ -610,9 +610,6 @@ cur_state_store(struct device *dev, struct device_attribute *attr, > unsigned long state; > int result; > > - dev_warn_once(&cdev->device, > - "Setting cooling device state is deprecated\n"); > - > if (sscanf(buf, "%ld\n", &state) != 1) > return -EINVAL; > > -- Applied along with the [2/2] as 5.18-rc material, thanks!
diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c index f154bada2906..1c4aac8464a7 100644 --- a/drivers/thermal/thermal_sysfs.c +++ b/drivers/thermal/thermal_sysfs.c @@ -610,9 +610,6 @@ cur_state_store(struct device *dev, struct device_attribute *attr, unsigned long state; int result; - dev_warn_once(&cdev->device, - "Setting cooling device state is deprecated\n"); - if (sscanf(buf, "%ld\n", &state) != 1) return -EINVAL;
This reverts commit a67a46af4ad6342378e332b7420c1d1a2818c53f. It has been reported the warning is annoying as the cooling device state is still needed on some production system. Meanwhile we provide a way to consolidate the thermal framework to prevent multiple actors acting on the cooling devices with conflicting decisions, let's revert this warning. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/thermal/thermal_sysfs.c | 3 --- 1 file changed, 3 deletions(-)