| Message ID | 20220418082738.11301-6-ychuang3@nuvoton.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/5] dt-bindings: clock: add binding for MA35D1 clock controller | expand |
On 2022/4/18 下午 08:11, Krzysztof Kozlowski wrote: > On 18/04/2022 10:27, Jacky Huang wrote: >> +properties: >> + $nodename: >> + const: '/' >> + compatible: >> + items: >> + - enum: >> + - nuvoton,ma35d1 >> + - nuvoton,ma35d1-evb >> + - nuvoton,ma35d1-iot >> + - nuvoton,ma35d1-som512 >> + - nuvoton,ma35d1-som1g > This does not match your DTS and does not look reasonable (SoC > compatible should not be part of this enum). Check some other board > bindings for examples. > > > Best regards, > Krzysztof I would like to modify it as follows: description: | Boards with an ARMv8 based Nuvoton SoC shall have the following properties. properties: $nodename: const: '/' compatible: oneOf: - description: MA35D1 evaluation board items: - const: nuvoton,ma35d1-evb - const: nuvoton,ma35d1 - description: MA35D1 IoT board items: - const: nuvoton,ma35d1-iot - const: nuvoton,ma35d1 - description: MA35D1 SOM board with 512MB DDR items: - const: nuvoton,ma35d1-som512 - const: nuvoton,ma35d1 - description: MA35D1 SOM board with 1GB DDR items: - const: nuvoton,ma35d1-som1g - const: nuvoton,ma35d1 additionalProperties: true Thank you very much. Jacky Huang
On 2022/4/21 下午 02:56, Krzysztof Kozlowski wrote: > On 21/04/2022 08:39, Jacky Huang wrote: >> >> On 2022/4/18 下午 08:11, Krzysztof Kozlowski wrote: >>> On 18/04/2022 10:27, Jacky Huang wrote: >>>> +properties: >>>> + $nodename: >>>> + const: '/' >>>> + compatible: >>>> + items: >>>> + - enum: >>>> + - nuvoton,ma35d1 >>>> + - nuvoton,ma35d1-evb >>>> + - nuvoton,ma35d1-iot >>>> + - nuvoton,ma35d1-som512 >>>> + - nuvoton,ma35d1-som1g >>> This does not match your DTS and does not look reasonable (SoC >>> compatible should not be part of this enum). Check some other board >>> bindings for examples. >>> >>> >>> Best regards, >>> Krzysztof >> I would like to modify it as follows: >> >> description: | >> Boards with an ARMv8 based Nuvoton SoC shall have the following >> properties. >> >> properties: >> $nodename: >> const: '/' >> compatible: >> oneOf: >> >> - description: MA35D1 evaluation board >> items: >> - const: nuvoton,ma35d1-evb >> - const: nuvoton,ma35d1 >> >> - description: MA35D1 IoT board >> items: >> - const: nuvoton,ma35d1-iot > Instead just enum with all board compatibles. How about to modify it as the follows: compatible: oneOf: - description: MA35D1 evaluation board items: - enum: - nuvoton,ma35d1-evb - const: nuvoton,ma35d1 - description: MA35D1 IoT board items: - enum: - nuvoton,ma35d1-iot - const: nuvoton,ma35d1 - description: MA35D1 SOM board items: - enum: - nuvoton,ma35d1-som512 - nuvoton,ma35d1-som1g - const: nuvoton,ma35d1 >> Thank you very much. >> Jacky Huang >> > > Best regards, > Krzysztof Sincerely, Jacky Huang
On 21/04/2022 10:13, Jacky Huang wrote: > OK, I got it. Like this, > > compatible: > oneOf: > > - description: MA35D1 based boards > items: > - enum: > - nuvoton,ma35d1-evb > - nuvoton,ma35d1-iot > - nuvoton,ma35d1-som512 > - nuvoton,ma35d1-som1g > - const: nuvoton,ma35d1 Yes, exactly. Thank you. Best regards, Krzysztof
On Thu, Apr 21, 2022 at 04:13:20PM +0800, Jacky Huang wrote: > > > On 2022/4/21 下午 04:05, Krzysztof Kozlowski wrote: > > On 21/04/2022 10:04, Jacky Huang wrote: > > > > > > On 2022/4/21 下午 02:56, Krzysztof Kozlowski wrote: > > > > On 21/04/2022 08:39, Jacky Huang wrote: > > > > > On 2022/4/18 下午 08:11, Krzysztof Kozlowski wrote: > > > > > > On 18/04/2022 10:27, Jacky Huang wrote: > > > > > > > +properties: > > > > > > > + $nodename: > > > > > > > + const: '/' > > > > > > > + compatible: > > > > > > > + items: > > > > > > > + - enum: > > > > > > > + - nuvoton,ma35d1 > > > > > > > + - nuvoton,ma35d1-evb > > > > > > > + - nuvoton,ma35d1-iot > > > > > > > + - nuvoton,ma35d1-som512 > > > > > > > + - nuvoton,ma35d1-som1g > > > > > > This does not match your DTS and does not look reasonable (SoC > > > > > > compatible should not be part of this enum). Check some other board > > > > > > bindings for examples. > > > > > > > > > > > > > > > > > > Best regards, > > > > > > Krzysztof > > > > > I would like to modify it as follows: > > > > > > > > > > description: | > > > > > Boards with an ARMv8 based Nuvoton SoC shall have the following > > > > > properties. > > > > > > > > > > properties: > > > > > $nodename: > > > > > const: '/' > > > > > compatible: > > > > > oneOf: > > > > > > > > > > - description: MA35D1 evaluation board > > > > > items: > > > > > - const: nuvoton,ma35d1-evb > > > > > - const: nuvoton,ma35d1 > > > > > > > > > > - description: MA35D1 IoT board > > > > > items: > > > > > - const: nuvoton,ma35d1-iot > > > > Instead just enum with all board compatibles. > > > How about to modify it as the follows: > > > > > > compatible: > > > oneOf: > > > > > > - description: MA35D1 evaluation board > > > items: > > > - enum: > > > - nuvoton,ma35d1-evb > > > - const: nuvoton,ma35d1 > > > > > > - description: MA35D1 IoT board > > > items: > > > - enum: > > > - nuvoton,ma35d1-iot > > > - const: nuvoton,ma35d1 > > > > > > - description: MA35D1 SOM board > > > items: > > > - enum: > > > - nuvoton,ma35d1-som512 > > > - nuvoton,ma35d1-som1g > > > - const: nuvoton,ma35d1 > > > > > It's still almost the same. All boards together. You can add a comment > > next to the compatible if you want some user-friendly name. > > > > > > Best regards, > > Krzysztof > > OK, I got it. Like this, > > compatible: > oneOf: > > - description: MA35D1 based boards > items: > - enum: > - nuvoton,ma35d1-evb > - nuvoton,ma35d1-iot > - nuvoton,ma35d1-som512 > - nuvoton,ma35d1-som1g The memory node distinguishes how much memory. Is the board different for the SoM? If not, combine these to 1. > - const: nuvoton,ma35d1 > > Sincerely, > Jacky Huang > > >
On 2022/4/26 上午 08:19, Rob Herring wrote: > On Thu, Apr 21, 2022 at 04:13:20PM +0800, Jacky Huang wrote: >> >> On 2022/4/21 下午 04:05, Krzysztof Kozlowski wrote: >>> On 21/04/2022 10:04, Jacky Huang wrote: >>>> On 2022/4/21 下午 02:56, Krzysztof Kozlowski wrote: >>>>> On 21/04/2022 08:39, Jacky Huang wrote: >>>>>> On 2022/4/18 下午 08:11, Krzysztof Kozlowski wrote: >>>>>>> On 18/04/2022 10:27, Jacky Huang wrote: >>>>>>>> +properties: >>>>>>>> + $nodename: >>>>>>>> + const: '/' >>>>>>>> + compatible: >>>>>>>> + items: >>>>>>>> + - enum: >>>>>>>> + - nuvoton,ma35d1 >>>>>>>> + - nuvoton,ma35d1-evb >>>>>>>> + - nuvoton,ma35d1-iot >>>>>>>> + - nuvoton,ma35d1-som512 >>>>>>>> + - nuvoton,ma35d1-som1g >>>>>>> This does not match your DTS and does not look reasonable (SoC >>>>>>> compatible should not be part of this enum). Check some other board >>>>>>> bindings for examples. >>>>>>> >>>>>>> >>>>>>> Best regards, >>>>>>> Krzysztof >>>>>> I would like to modify it as follows: >>>>>> >>>>>> description: | >>>>>> Boards with an ARMv8 based Nuvoton SoC shall have the following >>>>>> properties. >>>>>> >>>>>> properties: >>>>>> $nodename: >>>>>> const: '/' >>>>>> compatible: >>>>>> oneOf: >>>>>> >>>>>> - description: MA35D1 evaluation board >>>>>> items: >>>>>> - const: nuvoton,ma35d1-evb >>>>>> - const: nuvoton,ma35d1 >>>>>> >>>>>> - description: MA35D1 IoT board >>>>>> items: >>>>>> - const: nuvoton,ma35d1-iot >>>>> Instead just enum with all board compatibles. >>>> How about to modify it as the follows: >>>> >>>> compatible: >>>> oneOf: >>>> >>>> - description: MA35D1 evaluation board >>>> items: >>>> - enum: >>>> - nuvoton,ma35d1-evb >>>> - const: nuvoton,ma35d1 >>>> >>>> - description: MA35D1 IoT board >>>> items: >>>> - enum: >>>> - nuvoton,ma35d1-iot >>>> - const: nuvoton,ma35d1 >>>> >>>> - description: MA35D1 SOM board >>>> items: >>>> - enum: >>>> - nuvoton,ma35d1-som512 >>>> - nuvoton,ma35d1-som1g >>>> - const: nuvoton,ma35d1 >>>> >>> It's still almost the same. All boards together. You can add a comment >>> next to the compatible if you want some user-friendly name. >>> >>> >>> Best regards, >>> Krzysztof >> OK, I got it. Like this, >> >> compatible: >> oneOf: >> >> - description: MA35D1 based boards >> items: >> - enum: >> - nuvoton,ma35d1-evb >> - nuvoton,ma35d1-iot >> - nuvoton,ma35d1-som512 >> - nuvoton,ma35d1-som1g > The memory node distinguishes how much memory. Is the board different > for the SoM? If not, combine these to 1. Yes, I can make two dts files (som512 and som1g) with binding to the same som board. I will modify it as a single nuvoton,ma35d1-som board. Thank you. >> - const: nuvoton,ma35d1 >> >> Sincerely, >> Jacky Huang >> >> >> Sincerely, Jacky Huang
diff --git a/Documentation/devicetree/bindings/arm/nuvoton.yaml b/Documentation/devicetree/bindings/arm/nuvoton.yaml new file mode 100644 index 000000000000..2b8444c2f7ed --- /dev/null +++ b/Documentation/devicetree/bindings/arm/nuvoton.yaml @@ -0,0 +1,27 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/nuvoton.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton Platforms Device Tree Bindings + +maintainers: + - Jacky Huang <ychuang3@nuvoton.com> + +description: |+ + Bindings for Nuvoton ARMv8 based platform boards. + +properties: + $nodename: + const: '/' + compatible: + items: + - enum: + - nuvoton,ma35d1 + - nuvoton,ma35d1-evb + - nuvoton,ma35d1-iot + - nuvoton,ma35d1-som512 + - nuvoton,ma35d1-som1g + +additionalProperties: true
Add binding for ARMv8 based Nuvotn SoCs and platform boards. Add initial bindings for MA35D1 series development boards. Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> --- .../devicetree/bindings/arm/nuvoton.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/nuvoton.yaml