diff mbox series

scsi: increase max device queue_depth to 4096

Message ID 20220414103601.140687-1-sumit.saxena@broadcom.com
State New
Headers show
Series scsi: increase max device queue_depth to 4096 | expand

Commit Message

Sumit Saxena April 14, 2022, 10:36 a.m. UTC
Maximum SCSI device queue depth limited to 1024 is not sufficient
for RAID volumes configured behind Broadcom RAID controllers.
For a 16 drives RAID volume with 1024 device QD, per drive
64 IOs(1024/16) can be issued which is not good enough to achieve
performance target.

Cc: Ming Lei <ming.lei@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Sumanesh Samanta <sumanesh.samanta@broadcom.com>
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
---
 drivers/scsi/scsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen April 19, 2022, 3:03 a.m. UTC | #1
Sumit,

> Maximum SCSI device queue depth limited to 1024 is not sufficient for
> RAID volumes configured behind Broadcom RAID controllers.  For a 16
> drives RAID volume with 1024 device QD, per drive 64 IOs(1024/16) can
> be issued which is not good enough to achieve performance target.

Applied to 5.19/scsi-staging, thanks!
Martin K. Petersen April 26, 2022, 4 a.m. UTC | #2
On Thu, 14 Apr 2022 06:36:01 -0400, Sumit Saxena wrote:

> Maximum SCSI device queue depth limited to 1024 is not sufficient
> for RAID volumes configured behind Broadcom RAID controllers.
> For a 16 drives RAID volume with 1024 device QD, per drive
> 64 IOs(1024/16) can be issued which is not good enough to achieve
> performance target.
> 
> 
> [...]

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: increase max device queue_depth to 4096
      https://git.kernel.org/mkp/scsi/c/f9bdac31cf4b
diff mbox series

Patch

diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 211aace69c22..735b6c862b46 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -200,11 +200,11 @@  void scsi_finish_command(struct scsi_cmnd *cmd)
 
 
 /*
- * 1024 is big enough for saturating fast SCSI LUNs.
+ * 4096 is big enough for saturating fast SCSI LUNs.
  */
 int scsi_device_max_queue_depth(struct scsi_device *sdev)
 {
-	return min_t(int, sdev->host->can_queue, 1024);
+	return min_t(int, sdev->host->can_queue, 4096);
 }
 
 /**