| Message ID | 20220412195423.104511-1-stefan.wahren@i2se.com |
|---|---|
| State | Accepted |
| Commit | 106e0121e243de4da7d634338089a68a8da2abe9 |
| Headers | show |
| Series | thermal: bcm2711_thermal: Don't clamp temperature at zero | expand |
On 4/12/2022 12:54 PM, Stefan Wahren wrote: > The thermal sensor on BCM2711 is capable of negative temperatures, so don't > clamp the measurements at zero. Since this was the only use for variable t, > drop it. > > This change based on a patch by Dom Cobley, who also tested the fix. > > Fixes: 59b781352dc4 ("thermal: Add BCM2711 thermal driver") > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On 12/04/2022 21:54, Stefan Wahren wrote: > The thermal sensor on BCM2711 is capable of negative temperatures, so don't > clamp the measurements at zero. Since this was the only use for variable t, > drop it. > > This change based on a patch by Dom Cobley, who also tested the fix. > > Fixes: 59b781352dc4 ("thermal: Add BCM2711 thermal driver") > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Applied, thanks
diff --git a/drivers/thermal/broadcom/bcm2711_thermal.c b/drivers/thermal/broadcom/bcm2711_thermal.c index 1ec57d9ecf53..e9bef5c3414b 100644 --- a/drivers/thermal/broadcom/bcm2711_thermal.c +++ b/drivers/thermal/broadcom/bcm2711_thermal.c @@ -38,7 +38,6 @@ static int bcm2711_get_temp(void *data, int *temp) int offset = thermal_zone_get_offset(priv->thermal); u32 val; int ret; - long t; ret = regmap_read(priv->regmap, AVS_RO_TEMP_STATUS, &val); if (ret) @@ -50,9 +49,7 @@ static int bcm2711_get_temp(void *data, int *temp) val &= AVS_RO_TEMP_STATUS_DATA_MSK; /* Convert a HW code to a temperature reading (millidegree celsius) */ - t = slope * val + offset; - - *temp = t < 0 ? 0 : t; + *temp = slope * val + offset; return 0; }
The thermal sensor on BCM2711 is capable of negative temperatures, so don't clamp the measurements at zero. Since this was the only use for variable t, drop it. This change based on a patch by Dom Cobley, who also tested the fix. Fixes: 59b781352dc4 ("thermal: Add BCM2711 thermal driver") Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- drivers/thermal/broadcom/bcm2711_thermal.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)