| Message ID | 20220412220033.1273607-1-swboyd@chromium.org |
|---|---|
| Headers | show |
| Series | interconnect: qcom: Remove IP0 resource | expand |
On Tue 12 Apr 15:00 PDT 2022, Stephen Boyd wrote: > These two patches remove the IP0 interconnect used for IPA because > they're also present in the clk-rpmh driver. I see there are some more > IP0 usages in the interconnect drivers, but I don't see a corresponding > IPA clk in clk-rpmh, so I left these out. We can remove all of them if > desired, but the sc7180 patch is most important to me as it fixes > boot on my trogdor lazor device. > > Stephen Boyd (2): > interconnect: qcom: sc7180: Drop IP0 interconnects > interconnect: qcom: sdx55: Drop IP0 interconnects > > drivers/interconnect/qcom/sc7180.c | 21 --------------------- > drivers/interconnect/qcom/sdx55.c | 21 --------------------- > 2 files changed, 42 deletions(-) > > Cc: Alex Elder <elder@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Taniya Das <quic_tdas@quicinc.com> > Cc: Mike Tipton <quic_mdtipton@quicinc.com> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > base-commit: 3123109284176b1532874591f7c81f3837bbdc17 > -- > https://chromeos.dev >
On 4/14/22 7:58 PM, Stephen Boyd wrote: > This device node is unused now that we've removed the driver that > consumed it in the kernel. Drop the unused node to save some space. > > Cc: Alex Elder <elder@linaro.org> > Cc: Taniya Das <quic_tdas@quicinc.com> > Cc: Mike Tipton <quic_mdtipton@quicinc.com> > Cc: Georgi Djakov <djakov@kernel.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> Looks good to me. Reviewed-by: Alex Elder <elder@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index e1c46b80f14a..1ff96ef30e3f 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1421,13 +1421,6 @@ mmss_noc: interconnect@1740000 { > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > - ipa_virt: interconnect@1e00000 { > - compatible = "qcom,sc7180-ipa-virt"; > - reg = <0 0x01e00000 0 0x1000>; > - #interconnect-cells = <2>; > - qcom,bcm-voters = <&apps_bcm_voter>; > - }; > - > ipa: ipa@1e40000 { > compatible = "qcom,sc7180-ipa"; >
On 4/14/22 7:58 PM, Stephen Boyd wrote: > These interconnects are modeled as clks, not interconnects, therefore > remove the compatibles from the binding as they're unused. > > Cc: Alex Elder <elder@linaro.org> > Cc: Taniya Das <quic_tdas@quicinc.com> > Cc: Mike Tipton <quic_mdtipton@quicinc.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> What's the proper thing to do for properties that stop being used? Do we delete them, like this, or deprecate them somehow? Old DTBs might define the values that are deleted here. Shouldn't devicetree@vger.kernel.org be copied on this and the other DTS patches? -Alex > --- > > I don't know who should apply this. Probably whoever takes the dtsi > patches, Bjorn?, because otherwise dt_bindings_check will fail. > > Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > index 5a911be0c2ea..ab859150c7f7 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > @@ -31,7 +31,6 @@ properties: > - qcom,sc7180-config-noc > - qcom,sc7180-dc-noc > - qcom,sc7180-gem-noc > - - qcom,sc7180-ipa-virt > - qcom,sc7180-mc-virt > - qcom,sc7180-mmss-noc > - qcom,sc7180-npu-noc > @@ -68,7 +67,6 @@ properties: > - qcom,sdm845-mem-noc > - qcom,sdm845-mmss-noc > - qcom,sdm845-system-noc > - - qcom,sdx55-ipa-virt > - qcom,sdx55-mc-virt > - qcom,sdx55-mem-noc > - qcom,sdx55-system-noc
Quoting Alex Elder (2022-04-15 13:15:21) > On 4/14/22 7:58 PM, Stephen Boyd wrote: > > These interconnects are modeled as clks, not interconnects, therefore > > remove the compatibles from the binding as they're unused. > > > > Cc: Alex Elder <elder@linaro.org> > > Cc: Taniya Das <quic_tdas@quicinc.com> > > Cc: Mike Tipton <quic_mdtipton@quicinc.com> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > What's the proper thing to do for properties that stop being > used? Do we delete them, like this, or deprecate them somehow? > Old DTBs might define the values that are deleted here. I think we leave them around until the last dts user stops using them. > > Shouldn't devicetree@vger.kernel.org > be copied on this and > the other DTS patches? Sure. I added it now. Thanks. > > > --- > > > > I don't know who should apply this. Probably whoever takes the dtsi > > patches, Bjorn?, because otherwise dt_bindings_check will fail. > > > > Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > index 5a911be0c2ea..ab859150c7f7 100644 > > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > @@ -31,7 +31,6 @@ properties: > > - qcom,sc7180-config-noc > > - qcom,sc7180-dc-noc > > - qcom,sc7180-gem-noc > > - - qcom,sc7180-ipa-virt > > - qcom,sc7180-mc-virt > > - qcom,sc7180-mmss-noc > > - qcom,sc7180-npu-noc > > @@ -68,7 +67,6 @@ properties: > > - qcom,sdm845-mem-noc > > - qcom,sdm845-mmss-noc > > - qcom,sdm845-system-noc > > - - qcom,sdx55-ipa-virt > > - qcom,sdx55-mc-virt > > - qcom,sdx55-mem-noc > > - qcom,sdx55-system-noc >