mbox series

[v5,0/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support

Message ID 20220412101409.7980-1-j-keerthy@ti.com
Headers show
Series thermal: k3_j72xx_bandgap: Add the bandgap driver support | expand

Message

J, KEERTHY April 12, 2022, 10:14 a.m. UTC
Add VTM thermal support. In the Voltage Thermal Management
Module(VTM), K3 J72XX supplies a voltage reference and a temperature
sensor feature that are gathered in the band gap voltage and
temperature sensor (VBGAPTS) module. The band gap provides current and
voltage reference for its internal circuits and other analog IP
blocks. The analog-to-digital converter (ADC) produces an output value
that is proportional to the silicon temperature.

Currently reading temperatures only is supported.  There are no
active/passive cooling agent supported.

J721e SoCs have errata i2128: https://www.ti.com/lit/pdf/sprz455

The series also incorporates workaround for Errata i2128.

Daniel,

Apologies for the long silence on this!

- Keerthy

Changes in v5:

  * Fixed all the comments on v4.
  * Simplified the computation of the table.
  * Removed unnecessary members in the structures.

Changes in v4:

  * Fixed compilation warning with W=1.

Changes in v3:

  * Removed static look up tables & added functions to dynamically generate them.

Changes in v2:

  * Fixed DT binding errors.

Keerthy (4):
  dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation
  arm64: dts: ti: j721e: Add VTM node
  arm64: dts: ti: j7200: Add VTM node
  thermal: k3_j72xx_bandgap: Add the bandgap driver support

 .../bindings/thermal/ti,j72xx-thermal.yaml    |  62 ++
 .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi      |   9 +
 arch/arm64/boot/dts/ti/k3-j7200-thermal.dtsi  |  45 ++
 arch/arm64/boot/dts/ti/k3-j7200.dtsi          |   4 +
 .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi      |   9 +
 arch/arm64/boot/dts/ti/k3-j721e-thermal.dtsi  |  73 ++
 arch/arm64/boot/dts/ti/k3-j721e.dtsi          |   4 +
 drivers/thermal/Makefile                      |   2 +-
 drivers/thermal/k3_j72xx_bandgap.c            | 623 ++++++++++++++++++
 9 files changed, 830 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
 create mode 100644 arch/arm64/boot/dts/ti/k3-j7200-thermal.dtsi
 create mode 100644 arch/arm64/boot/dts/ti/k3-j721e-thermal.dtsi
 create mode 100644 drivers/thermal/k3_j72xx_bandgap.c

Comments

J, KEERTHY April 13, 2022, 12:04 p.m. UTC | #1
On 4/13/2022 3:43 PM, Krzysztof Kozlowski wrote:
> On 12/04/2022 12:14, Keerthy wrote:
>> Add VTM bindings documentation. In the Voltage Thermal
>> Management Module(VTM), K3 J72XX supplies a voltage
>> reference and a temperature sensor feature that are gathered in the band
>> gap voltage and temperature sensor (VBGAPTS) module. The band
>> gap provides current and voltage reference for its internal
>> circuits and other analog IP blocks. The analog-to-digital
>> converter (ADC) produces an output value that is proportional
>> to the silicon temperature.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>   .../bindings/thermal/ti,j72xx-thermal.yaml    | 62 +++++++++++++++++++
>>   1 file changed, 62 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
>> new file mode 100644
>> index 000000000000..8483c495cb9a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
>> @@ -0,0 +1,62 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments J72XX VTM (DTS) binding
>> +
>> +maintainers:
>> +  - Keerthy <j-keerthy@ti.com>
>> +
>> +properties:
>> +  compatible:
>> +    const: ti,j721e-vtm
>> +    oneOf:
>> +      - enum:
>> +          - ti,j721e-vtm
>> +          - ti,j7200-vtm
> 
> It seems you resent this ignoring all of Rob's comments. In changelog of
> cover letter you wrote "Fixed all the comments on v4" but it's not true.
> Maybe you sent us old patch?
> 
> Anyway, you need to follow Rob's comments.

Krzysztof,

Apologies. Some issues with my mailbox. Rob's response didn't reach me 
for some reason.

I am now seeing them on the web: 
https://lore.kernel.org/lkml/YY7HvCyJ90Ge8mr7@robh.at.kernel.org/

It wasn't deliberate to ignore comments. Apologies.

I will fix them in v6.

Thanks for the quick feedback.

- Keerthy


> 
> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski April 13, 2022, 12:25 p.m. UTC | #2
On 13/04/2022 14:04, J, KEERTHY wrote:
> Apologies. Some issues with my mailbox. Rob's response didn't reach me 
> for some reason.
> 
> I am now seeing them on the web: 
> https://lore.kernel.org/lkml/YY7HvCyJ90Ge8mr7@robh.at.kernel.org/
> 
> It wasn't deliberate to ignore comments. Apologies.
> 
> I will fix them in v6.

Sure :)


Best regards,
Krzysztof
Rob Herring April 14, 2022, 3:57 p.m. UTC | #3
On Wed, Apr 13, 2022 at 05:34:20PM +0530, J, KEERTHY wrote:
> 
> 
> On 4/13/2022 3:43 PM, Krzysztof Kozlowski wrote:
> > On 12/04/2022 12:14, Keerthy wrote:
> > > Add VTM bindings documentation. In the Voltage Thermal
> > > Management Module(VTM), K3 J72XX supplies a voltage
> > > reference and a temperature sensor feature that are gathered in the band
> > > gap voltage and temperature sensor (VBGAPTS) module. The band
> > > gap provides current and voltage reference for its internal
> > > circuits and other analog IP blocks. The analog-to-digital
> > > converter (ADC) produces an output value that is proportional
> > > to the silicon temperature.
> > > 
> > > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > > ---
> > >   .../bindings/thermal/ti,j72xx-thermal.yaml    | 62 +++++++++++++++++++
> > >   1 file changed, 62 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> > > new file mode 100644
> > > index 000000000000..8483c495cb9a
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> > > @@ -0,0 +1,62 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Texas Instruments J72XX VTM (DTS) binding
> > > +
> > > +maintainers:
> > > +  - Keerthy <j-keerthy@ti.com>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: ti,j721e-vtm
> > > +    oneOf:
> > > +      - enum:
> > > +          - ti,j721e-vtm
> > > +          - ti,j7200-vtm
> > 
> > It seems you resent this ignoring all of Rob's comments. In changelog of
> > cover letter you wrote "Fixed all the comments on v4" but it's not true.
> > Maybe you sent us old patch?
> > 
> > Anyway, you need to follow Rob's comments.
> 
> Krzysztof,
> 
> Apologies. Some issues with my mailbox. Rob's response didn't reach me for
> some reason.

Maybe because I'm still banned by TI. Just had another bounce a few days 
ago.

Rob