| Message ID | 20220401190233.329360-1-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr | expand |
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com> On 4/1/22 21:02, Richard Henderson wrote: > Coverity reports out-of-bound accesses here. This should be a > false positive due to how the index is decoded from MemOpIdx. > > Fixes: Coverity CID 1487201 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > plugins/api.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/plugins/api.c b/plugins/api.c > index 7bf71b189d..2078b16edb 100644 > --- a/plugins/api.c > +++ b/plugins/api.c > @@ -289,6 +289,8 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info, > enum qemu_plugin_mem_rw rw = get_plugin_meminfo_rw(info); > hwaddr_info.is_store = (rw & QEMU_PLUGIN_MEM_W) != 0; > > + assert(mmu_idx < NB_MMU_MODES); > + > if (!tlb_plugin_lookup(cpu, vaddr, mmu_idx, > hwaddr_info.is_store, &hwaddr_info)) { > error_report("invalid use of qemu_plugin_get_hwaddr");
Richard Henderson <richard.henderson@linaro.org> writes: > Coverity reports out-of-bound accesses here. This should be a > false positive due to how the index is decoded from MemOpIdx. > > Fixes: Coverity CID 1487201 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Queued to plugins/next, thanks.
diff --git a/plugins/api.c b/plugins/api.c index 7bf71b189d..2078b16edb 100644 --- a/plugins/api.c +++ b/plugins/api.c @@ -289,6 +289,8 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info, enum qemu_plugin_mem_rw rw = get_plugin_meminfo_rw(info); hwaddr_info.is_store = (rw & QEMU_PLUGIN_MEM_W) != 0; + assert(mmu_idx < NB_MMU_MODES); + if (!tlb_plugin_lookup(cpu, vaddr, mmu_idx, hwaddr_info.is_store, &hwaddr_info)) { error_report("invalid use of qemu_plugin_get_hwaddr");
Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx. Fixes: Coverity CID 1487201 Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- plugins/api.c | 2 ++ 1 file changed, 2 insertions(+)