mbox series

[v2,0/2] ASoC: meson: aiu: fix duplicate debugfs directory error

Message ID 51953618-79b6-0df7-2d28-d5dce4dc86c7@gmail.com
Headers show
Series ASoC: meson: aiu: fix duplicate debugfs directory error | expand

Message

Heiner Kallweit March 9, 2022, 8:20 p.m. UTC 
On a S905W-based system I get the following error:
debugfs: Directory 'c1105400.audio-controller' with parent 'P230-Q200' already present!

Turned out that multiple components having the same name triggers this
error in soc_init_component_debugfs(). The proposed solution allows
other drivers to adopt the same approach with minimal effort.
With the patch the error is gone and that's the debugfs entries.

/sys/kernel/debug/asoc/P230-Q200/acodec:c1105400.audio-controller
/sys/kernel/debug/asoc/P230-Q200/hdmi:c1105400.audio-controller
/sys/kernel/debug/asoc/P230-Q200/cpu:c1105400.audio-controller

v2:
- Reworked approach based on [0]

[0] https://www.spinics.net/lists/arm-kernel/msg960881.html

Heiner Kallweit (2):
  ASoC: soc-core: add debugfs_prefix member to snd_soc_component_driver
  ASoC: meson: aiu: fix duplicate debugfs directory error

 include/sound/soc-component.h     | 4 ++++
 sound/soc/meson/aiu-acodec-ctrl.c | 3 +++
 sound/soc/meson/aiu-codec-ctrl.c  | 3 +++
 sound/soc/meson/aiu.c             | 3 +++
 sound/soc/soc-core.c              | 5 +++++
 5 files changed, 18 insertions(+)

Comments

Heiner Kallweit March 31, 2022, 5:56 a.m. UTC | #1 
On 09.03.2022 21:20, Heiner Kallweit wrote:
> On a S905W-based system I get the following error:
> debugfs: Directory 'c1105400.audio-controller' with parent 'P230-Q200' already present!
> 
> Turned out that multiple components having the same name triggers this
> error in soc_init_component_debugfs(). The proposed solution allows
> other drivers to adopt the same approach with minimal effort.
> With the patch the error is gone and that's the debugfs entries.
> 
> /sys/kernel/debug/asoc/P230-Q200/acodec:c1105400.audio-controller
> /sys/kernel/debug/asoc/P230-Q200/hdmi:c1105400.audio-controller
> /sys/kernel/debug/asoc/P230-Q200/cpu:c1105400.audio-controller
> 
> v2:
> - Reworked approach based on [0]
> 
> [0] https://www.spinics.net/lists/arm-kernel/msg960881.html
> 
> Heiner Kallweit (2):
>   ASoC: soc-core: add debugfs_prefix member to snd_soc_component_driver
>   ASoC: meson: aiu: fix duplicate debugfs directory error
> 
>  include/sound/soc-component.h     | 4 ++++
>  sound/soc/meson/aiu-acodec-ctrl.c | 3 +++
>  sound/soc/meson/aiu-codec-ctrl.c  | 3 +++
>  sound/soc/meson/aiu.c             | 3 +++
>  sound/soc/soc-core.c              | 5 +++++
>  5 files changed, 18 insertions(+)
> 

Any feedback here?