| Message ID | 20220325232709.2358965-1-kuba@kernel.org |
|---|---|
| State | Accepted |
| Commit | 5c7e49be96ea24776a5b5a07c732c477294add00 |
| Headers | show |
| Series | [net] selftests: tls: skip cmsg_to_pipe tests with TLS=n | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 25 Mar 2022 16:27:09 -0700 you wrote: > These are negative tests, testing TLS code rejects certain > operations. They won't pass without TLS enabled, pure TCP > accepts those operations. > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > Fixes: d87d67fd61ef ("selftests: tls: test splicing cmsgs") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > > [...] Here is the summary with links: - [net] selftests: tls: skip cmsg_to_pipe tests with TLS=n https://git.kernel.org/netdev/net/c/5c7e49be96ea You are awesome, thank you!
diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c index 6e468e0f42f7..5d70b04c482c 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -683,6 +683,9 @@ TEST_F(tls, splice_cmsg_to_pipe) char buf[10]; int p[2]; + if (self->notls) + SKIP(return, "no TLS support"); + ASSERT_GE(pipe(p), 0); EXPECT_EQ(tls_send_cmsg(self->fd, 100, test_str, send_len, 0), 10); EXPECT_EQ(splice(self->cfd, NULL, p[1], NULL, send_len, 0), -1); @@ -703,6 +706,9 @@ TEST_F(tls, splice_dec_cmsg_to_pipe) char buf[10]; int p[2]; + if (self->notls) + SKIP(return, "no TLS support"); + ASSERT_GE(pipe(p), 0); EXPECT_EQ(tls_send_cmsg(self->fd, 100, test_str, send_len, 0), 10); EXPECT_EQ(recv(self->cfd, buf, send_len, 0), -1);
These are negative tests, testing TLS code rejects certain operations. They won't pass without TLS enabled, pure TCP accepts those operations. Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> Fixes: d87d67fd61ef ("selftests: tls: test splicing cmsgs") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- tools/testing/selftests/net/tls.c | 6 ++++++ 1 file changed, 6 insertions(+)