| Message ID | 20220318165119.12191-3-sakari.ailus@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | c1b77f25247fa19aa738cfda14f4525583a1f32a |
| Headers | show |
| Series | dw9807 binding and driver compatible changes | expand |
On 18/03/2022 17:51, Sakari Ailus wrote: > There is firmware out there that uses "dongwoon,dw9807" compatible string > that never made it to upstream as-is. Add it to the driver to make it load > on such systems. > > The chip also has an EEPROM part which is AT24 compatible (for reading > purposes) on a separate I²C address. Adding possible support for this in > the future is not affected by this change. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/media/i2c/dw9807-vcm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/i2c/dw9807-vcm.c b/drivers/media/i2c/dw9807-vcm.c > index 95e06f13bc9ed..ada8e467a0450 100644 > --- a/drivers/media/i2c/dw9807-vcm.c > +++ b/drivers/media/i2c/dw9807-vcm.c > @@ -295,6 +295,8 @@ static int __maybe_unused dw9807_vcm_resume(struct device *dev) > > static const struct of_device_id dw9807_of_table[] = { > { .compatible = "dongwoon,dw9807-vcm" }, > + /* Compatibility for older firmware */ > + { .compatible = "dongwoon,dw9807" }, You need to add it to the bindings as well. Best regards, Krzysztof
diff --git a/drivers/media/i2c/dw9807-vcm.c b/drivers/media/i2c/dw9807-vcm.c index 95e06f13bc9ed..ada8e467a0450 100644 --- a/drivers/media/i2c/dw9807-vcm.c +++ b/drivers/media/i2c/dw9807-vcm.c @@ -295,6 +295,8 @@ static int __maybe_unused dw9807_vcm_resume(struct device *dev) static const struct of_device_id dw9807_of_table[] = { { .compatible = "dongwoon,dw9807-vcm" }, + /* Compatibility for older firmware */ + { .compatible = "dongwoon,dw9807" }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, dw9807_of_table);
There is firmware out there that uses "dongwoon,dw9807" compatible string that never made it to upstream as-is. Add it to the driver to make it load on such systems. The chip also has an EEPROM part which is AT24 compatible (for reading purposes) on a separate I²C address. Adding possible support for this in the future is not affected by this change. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/i2c/dw9807-vcm.c | 2 ++ 1 file changed, 2 insertions(+)