diff mbox series

[1/5] ARM: dts: exynos: align EHCI/OHCI nodes with dtschema on Exynos4

Message ID 20220314181948.246434-1-krzysztof.kozlowski@canonical.com
State New
Headers show
Series [1/5] ARM: dts: exynos: align EHCI/OHCI nodes with dtschema on Exynos4 | expand

Commit Message

Krzysztof Kozlowski March 14, 2022, 6:19 p.m. UTC
The node names should be generic and USB DT schema expects "usb" names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/exynos4.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Alim Akhtar March 15, 2022, 5:01 p.m. UTC | #1
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Monday, March 14, 2022 11:50 PM
>To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
><robh+dt@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Alim
>Akhtar <alim.akhtar@samsung.com>; linux-usb@vger.kernel.org;
>devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>Subject: [PATCH 2/5] ARM: dts: s5pv210: align EHCI/OHCI nodes with
>dtschema
>
>The node names should be generic and USB DT schema expects "usb" names.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
Probably you can squash this with the 1/5 patch

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> arch/arm/boot/dts/s5pv210.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm/boot/dts/s5pv210.dtsi
b/arch/arm/boot/dts/s5pv210.dtsi
>index 353ba7b09a0c..a7aca54832d9 100644
>--- a/arch/arm/boot/dts/s5pv210.dtsi
>+++ b/arch/arm/boot/dts/s5pv210.dtsi
>@@ -427,7 +427,7 @@ usbphy: usbphy@ec100000 {
> 			status = "disabled";
> 		};
>
>-		ehci: ehci@ec200000 {
>+		ehci: usb@ec200000 {
> 			compatible = "samsung,exynos4210-ehci";
> 			reg = <0xec200000 0x100>;
> 			interrupts = <23>;
>@@ -444,7 +444,7 @@ port@0 {
> 			};
> 		};
>
>-		ohci: ohci@ec300000 {
>+		ohci: usb@ec300000 {
> 			compatible = "samsung,exynos4210-ohci";
> 			reg = <0xec300000 0x100>;
> 			interrupts = <23>;
>--
>2.32.0
Alim Akhtar March 15, 2022, 5:02 p.m. UTC | #2
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Monday, March 14, 2022 11:50 PM
>To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
><robh+dt@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Alim
>Akhtar <alim.akhtar@samsung.com>; linux-usb@vger.kernel.org;
>devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>Subject: [PATCH 1/5] ARM: dts: exynos: align EHCI/OHCI nodes with dtschema
>on Exynos4
>
>The node names should be generic and USB DT schema expects "usb" names.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


> arch/arm/boot/dts/exynos4.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm/boot/dts/exynos4.dtsi
>b/arch/arm/boot/dts/exynos4.dtsi index e81b3ee4e0f7..5fd17bc52321 100644
>--- a/arch/arm/boot/dts/exynos4.dtsi
>+++ b/arch/arm/boot/dts/exynos4.dtsi
>@@ -373,7 +373,7 @@ hsotg: hsotg@12480000 {
> 			status = "disabled";
> 		};
>
>-		ehci: ehci@12580000 {
>+		ehci: usb@12580000 {
> 			compatible = "samsung,exynos4210-ehci";
> 			reg = <0x12580000 0x100>;
> 			interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
>@@ -384,7 +384,7 @@ ehci: ehci@12580000 {
> 			phy-names = "host", "hsic0", "hsic1";
> 		};
>
>-		ohci: ohci@12590000 {
>+		ohci: usb@12590000 {
> 			compatible = "samsung,exynos4210-ohci";
> 			reg = <0x12590000 0x100>;
> 			interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
>--
>2.32.0
Krzysztof Kozlowski April 4, 2022, 5:01 p.m. UTC | #3
On Mon, 14 Mar 2022 19:19:44 +0100, Krzysztof Kozlowski wrote:
> The node names should be generic and USB DT schema expects "usb" names.
> 
> 

Applied, thanks!

[1/5] ARM: dts: exynos: align EHCI/OHCI nodes with dtschema on Exynos4
      commit: b412be7d3c0a248db0de4b7b53ee6ad44d49c71b

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index e81b3ee4e0f7..5fd17bc52321 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -373,7 +373,7 @@  hsotg: hsotg@12480000 {
 			status = "disabled";
 		};
 
-		ehci: ehci@12580000 {
+		ehci: usb@12580000 {
 			compatible = "samsung,exynos4210-ehci";
 			reg = <0x12580000 0x100>;
 			interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
@@ -384,7 +384,7 @@  ehci: ehci@12580000 {
 			phy-names = "host", "hsic0", "hsic1";
 		};
 
-		ohci: ohci@12590000 {
+		ohci: usb@12590000 {
 			compatible = "samsung,exynos4210-ohci";
 			reg = <0x12590000 0x100>;
 			interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;