diff mbox series

[4/6,v2] scsi: lpfc: use kcalloc

Message ID 20220313141847.109804-1-Julia.Lawall@inria.fr
State New
Headers show
Series None | expand

Commit Message

Julia Lawall March 13, 2022, 2:18 p.m. UTC 
Use kcalloc instead of kmalloc + memset.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---

v2: Use kcalloc instead of kzalloc

 drivers/scsi/lpfc/lpfc_debugfs.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Martin K. Petersen March 15, 2022, 4:54 a.m. UTC | #1 
Julia,

> Use kcalloc instead of kmalloc + memset.

Applied to 5.18/scsi-staging, thanks!
Martin K. Petersen March 19, 2022, 3:56 a.m. UTC | #2 
On Sun, 13 Mar 2022 15:18:47 +0100, Julia Lawall wrote:

> Use kcalloc instead of kmalloc + memset.
> 
> 

Applied to 5.18/scsi-queue, thanks!

[4/6] scsi: lpfc: use kcalloc
      https://git.kernel.org/mkp/scsi/c/dc2646417d54
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index 30fac2f6fb06..7b24c932e812 100644
--- a/drivers/scsi/lpfc/lpfc_debugfs.c
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -6272,9 +6272,9 @@  lpfc_debugfs_initialize(struct lpfc_vport *vport)
 				 phba->hba_debugfs_root,
 				 phba, &lpfc_debugfs_op_slow_ring_trc);
 		if (!phba->slow_ring_trc) {
-			phba->slow_ring_trc = kmalloc(
-				(sizeof(struct lpfc_debugfs_trc) *
-				lpfc_debugfs_max_slow_ring_trc),
+			phba->slow_ring_trc = kcalloc(
+				lpfc_debugfs_max_slow_ring_trc,
+				sizeof(struct lpfc_debugfs_trc),
 				GFP_KERNEL);
 			if (!phba->slow_ring_trc) {
 				lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT,
@@ -6283,9 +6283,6 @@  lpfc_debugfs_initialize(struct lpfc_vport *vport)
 				goto debug_failed;
 			}
 			atomic_set(&phba->slow_ring_trc_cnt, 0);
-			memset(phba->slow_ring_trc, 0,
-				(sizeof(struct lpfc_debugfs_trc) *
-				lpfc_debugfs_max_slow_ring_trc));
 		}
 
 		snprintf(name, sizeof(name), "nvmeio_trc");