| Message ID | 20220309020750.65399-1-ilkka@os.amperecomputing.com |
|---|---|
| Headers | show |
| Series | ACPI: Arm Generic Diagnostic Dump and Reset device | expand |
Hi Rafael, On Wed, 9 Mar 2022, Rafael J. Wysocki wrote: > On Wed, Mar 9, 2022 at 3:08 AM Ilkka Koskinen > <ilkka@os.amperecomputing.com> wrote: >> >> Add AGDI to the list of known ACPI table signatures to allow the >> kernel to recognize it when upgrading tables via initrd. >> >> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com> >> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> >> --- >> drivers/acpi/tables.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c >> index 369eb998c3d1..ceee808f7f2a 100644 >> --- a/drivers/acpi/tables.c >> +++ b/drivers/acpi/tables.c >> @@ -545,7 +545,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = { >> ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, >> ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, >> ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT, >> - ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT }; >> + ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI }; >> >> #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header) > > I'm noticing that this depends on the linux-next-only commit > 783dedf41b79ac7a3a68b51cf6f88cbfd6dc3292, so it is probably better if > I apply it and the other patch in the series can be routed via ARM64. Sounds good to me, thanks. The other patch needs commit dc4e8c07e9e2 ("ACPI: APEI: explicit init of HEST and GHES in apci_init()") in your bleeding edge branch to work but it hasn't been acked yet anyway. Cheers, Ilkka
On Wed, Mar 09, 2022 at 12:41:27PM -0800, Ilkka Koskinen wrote: > > Hi Rafael, > > On Wed, 9 Mar 2022, Rafael J. Wysocki wrote: > > On Wed, Mar 9, 2022 at 3:08 AM Ilkka Koskinen > > <ilkka@os.amperecomputing.com> wrote: > > > > > > Add AGDI to the list of known ACPI table signatures to allow the > > > kernel to recognize it when upgrading tables via initrd. > > > > > > Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com> > > > Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > --- > > > drivers/acpi/tables.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > > > index 369eb998c3d1..ceee808f7f2a 100644 > > > --- a/drivers/acpi/tables.c > > > +++ b/drivers/acpi/tables.c > > > @@ -545,7 +545,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = { > > > ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, > > > ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, > > > ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT, > > > - ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT }; > > > + ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI }; > > > > > > #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header) > > > > I'm noticing that this depends on the linux-next-only commit > > 783dedf41b79ac7a3a68b51cf6f88cbfd6dc3292, so it is probably better if > > I apply it and the other patch in the series can be routed via ARM64. > > Sounds good to me, thanks. The other patch needs commit dc4e8c07e9e2 ("ACPI: > APEI: explicit init of HEST and GHES in apci_init()") in your bleeding edge > branch to work but it hasn't been acked yet anyway. It is best for both patches to go via Rafael's tree, given the dependency above. I acked patch (2). Thanks, Lorenzo
Arm Generic Diagnostic Dump and Reset device enables a maintainer to request OS to perform a diagnostic dump and reset a system via SDEI event or an interrupt. This patchset adds support for the SDEI path. I do have a patch to enable the interrupt path as well but I'm holding it back since AGDI table is missing interrupt configuration fields (trigger type etc.). The recently published specification is available at https://developer.arm.com/documentation/den0093/latest The patchset was tested on Ampere Altra/Mt. Jade. The patchset applies on top of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm bleeding-edge (dd54258fbf6c) Requires commit 27e932a31496 ("ACPI: APEI: rename ghes_init() with an "acpi_" prefix")