| Message ID | 20220308072435.22460-3-trevor.wu@mediatek.com |
|---|---|
| State | Accepted |
| Commit | ee7f79a81a27c47088fe0af95788621644826d91 |
| Headers | show |
| Series | ASoC: mediatek: Add support for MT8195 sound card with max98390 and rt5682 | expand |
On Tue, Mar 08, 2022 at 03:24:32PM +0800, Trevor Wu wrote: > Add required properties "resets" and "reset_names", which are used to > specify audiosys hw reset for mt8195 afe driver. The subject needs to be more specific and indicate this applies to ASoC and mt8195-afe-pcm. Try to write subjects that could only ever appear once as you can never make the same change twice. Rob
On Thu, 2022-03-10 at 16:12 -0600, Rob Herring wrote: > On Tue, Mar 08, 2022 at 03:24:32PM +0800, Trevor Wu wrote: > > Add required properties "resets" and "reset_names", which are used > > to > > specify audiosys hw reset for mt8195 afe driver. > > The subject needs to be more specific and indicate this applies to > ASoC > and mt8195-afe-pcm. Try to write subjects that could only ever > appear > once as you can never make the same change twice. > > Rob Hi Rob, Thanks for your suggestion. I will revise the subject to "ASoC: dt-bindings: mediatek: mt8195-afe- pcm: add reset property" in v2. Thanks, Trevor
diff --git a/Documentation/devicetree/bindings/sound/mt8195-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8195-afe-pcm.yaml index 6d0975b33d15..4452a4070eff 100644 --- a/Documentation/devicetree/bindings/sound/mt8195-afe-pcm.yaml +++ b/Documentation/devicetree/bindings/sound/mt8195-afe-pcm.yaml @@ -19,6 +19,12 @@ properties: interrupts: maxItems: 1 + resets: + maxItems: 1 + + reset-names: + const: audiosys + memory-region: maxItems: 1 description: | @@ -127,6 +133,8 @@ required: - compatible - reg - interrupts + - resets + - reset-names - mediatek,topckgen - power-domains - clocks @@ -144,6 +152,8 @@ examples: compatible = "mediatek,mt8195-audio"; reg = <0x10890000 0x10000>; interrupts = <GIC_SPI 822 IRQ_TYPE_LEVEL_HIGH 0>; + resets = <&watchdog 14>; + reset-names = "audiosys"; mediatek,topckgen = <&topckgen>; power-domains = <&spm 7>; //MT8195_POWER_DOMAIN_AUDIO memory-region = <&snd_dma_mem_reserved>;
Add required properties "resets" and "reset_names", which are used to specify audiosys hw reset for mt8195 afe driver. Signed-off-by: Trevor Wu <trevor.wu@mediatek.com> --- .../devicetree/bindings/sound/mt8195-afe-pcm.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)