| Message ID | 20220306111125.116455-1-krzysztof.kozlowski@canonical.com |
|---|---|
| Headers | show |
| Series | dt-bindings: ufs: add common platform bindings + fixes | expand |
On Sun, 06 Mar 2022 12:11:16 +0100, Krzysztof Kozlowski wrote: > Convert the Cadence Universal Flash Storage (UFS) Controlle to DT schema > format. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/ufs/cdns,ufshc.txt | 32 --------- > .../devicetree/bindings/ufs/cdns,ufshc.yaml | 68 +++++++++++++++++++ > .../devicetree/bindings/ufs/ti,j721e-ufs.yaml | 7 +- > 3 files changed, 71 insertions(+), 36 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.txt > create mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/ufs/cdns,ufshc.example.dt.yaml: ufs@fd030000: freq-table-hz: 'anyOf' conditional failed, one must be fixed: [[0, 0], [0, 0]] is too long [0, 0] is too long From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/property-units.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1601674 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 07/03/2022 04:24, Rob Herring wrote: > On Sun, 06 Mar 2022 12:11:16 +0100, Krzysztof Kozlowski wrote: >> Convert the Cadence Universal Flash Storage (UFS) Controlle to DT schema >> format. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- >> .../devicetree/bindings/ufs/cdns,ufshc.txt | 32 --------- >> .../devicetree/bindings/ufs/cdns,ufshc.yaml | 68 +++++++++++++++++++ >> .../devicetree/bindings/ufs/ti,j721e-ufs.yaml | 7 +- >> 3 files changed, 71 insertions(+), 36 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.txt >> create mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/ufs/cdns,ufshc.example.dt.yaml: ufs@fd030000: freq-table-hz: 'anyOf' conditional failed, one must be fixed: > [[0, 0], [0, 0]] is too long > [0, 0] is too long > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/property-units.yaml > This will be fixed with my dtschema patch: https://github.com/devicetree-org/dt-schema/pull/69 Best regards, Krzysztof
>-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Sunday, March 6, 2022 4:41 PM >To: Alim Akhtar <alim.akhtar@samsung.com>; Avri Altman ><avri.altman@wdc.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof >Kozlowski <krzysztof.kozlowski@canonical.com>; Andy Gross ><agross@kernel.org>; Bjorn Andersson <bjorn.andersson@linaro.org>; Wei >Xu <xuwei5@hisilicon.com>; Matthias Brugger <matthias.bgg@gmail.com>; >Jan Kotas <jank@cadence.com>; Li Wei <liwei213@huawei.com>; Stanley Chu ><stanley.chu@mediatek.com>; Vignesh Raghavendra <vigneshr@ti.com>; >linux-scsi@vger.kernel.org; devicetree@vger.kernel.org; linux- >kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux-arm- >kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- >mediatek@lists.infradead.org >Cc: Rob Herring <robh@kernel.org> >Subject: [PATCH v3 02/12] dt-bindings: ufs: samsung,exynos-ufs: use common >bindings > >Use common UFS bindings in Samsung Exynos UFS to cover generic/common >properties in DTS. > >Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >Reviewed-by: Rob Herring <robh@kernel.org> >--- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > .../devicetree/bindings/ufs/samsung,exynos-ufs.yaml | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > >diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos- >ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos- >ufs.yaml >index 95ac1c18334d..c949eb617313 100644 >--- a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml >+++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml >@@ -11,12 +11,11 @@ maintainers: > > description: | > Each Samsung UFS host controller instance should have its own node. >- This binding define Samsung specific binding other then what is used >- in the common ufshcd bindings >- [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > >-properties: >+allOf: >+ - $ref: ufs-common.yaml > >+properties: > compatible: > enum: > - samsung,exynos7-ufs >@@ -47,9 +46,6 @@ properties: > - const: core_clk > - const: sclk_unipro_main > >- interrupts: >- maxItems: 1 >- > phys: > maxItems: 1 > >@@ -67,13 +63,12 @@ properties: > required: > - compatible > - reg >- - interrupts > - phys > - phy-names > - clocks > - clock-names > >-additionalProperties: false >+unevaluatedProperties: false > > examples: > - | >-- >2.32.0
On Sun, Mar 06, 2022 at 12:11:13PM +0100, Krzysztof Kozlowski wrote: > Hi, > > Not tested on hardware, so please kindly test. > Bindings maintainers might need checking - taken from git log. > > Changes since v2 > ================ > 1. Do not deprecate freq-table-hz, but instead update dtschema to accept > uint32-matrix. See: > https://github.com/devicetree-org/dt-schema/pull/69 > 2. Drop patches and changes related to freq-table-hz -> freq-table conversion. > 3. Add tags. > 4. Change maintainer of qcom,ufs. > > Changes since v1 > ================ > 1. Make freq-table as matrix of tuples (Nishanth). > 2. New patches: convert all bindings and fix up DTS files. > 3. Several minor fixes in UFS bindings. > > Dependencies > ============ > None dependencies. The DTS patches can go independently via respective > maintainers. The dt-bindings patches could go via UFS tree. > > Best regards, > Krzysztof > > Krzysztof Kozlowski (12): > dt-bindings: ufs: add common platform bindings > dt-bindings: ufs: samsung,exynos-ufs: use common bindings > dt-bindings: ufs: cdns,ufshc: convert to dtschema > dt-bindings: ufs: drop unused/old ufs-qcom PHY bindings > dt-bindings: ufs: qcom,ufs: convert to dtschema > dt-bindings: ufs: hisilicon,ufs: convert to dtschema > dt-bindings: ufs: mediatek,ufs: convert to dtschema > dt-bindings: ufs: snps,tc-dwc-g210: convert to dtschema Patches 1-8 applied. Rob > arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS > arm64: dts: qcom: msm8996: drop unsupported UFS > vddp-ref-clk-max-microamp > arm64: dts: qcom: msm8996: correct UFS compatible > arm64: dts: qcom: sm8350: drop duplicated ref_clk in UFS > > .../devicetree/bindings/ufs/cdns,ufshc.txt | 32 --- > .../devicetree/bindings/ufs/cdns,ufshc.yaml | 68 +++++ > .../bindings/ufs/hisilicon,ufs.yaml | 90 +++++++ > .../devicetree/bindings/ufs/mediatek,ufs.yaml | 67 +++++ > .../devicetree/bindings/ufs/qcom,ufs.yaml | 242 ++++++++++++++++++ > .../bindings/ufs/samsung,exynos-ufs.yaml | 13 +- > .../bindings/ufs/snps,tc-dwc-g210.yaml | 51 ++++ > .../bindings/ufs/tc-dwc-g210-pltfrm.txt | 26 -- > .../devicetree/bindings/ufs/ti,j721e-ufs.yaml | 7 +- > .../devicetree/bindings/ufs/ufs-common.yaml | 82 ++++++ > .../devicetree/bindings/ufs/ufs-hisi.txt | 42 --- > .../devicetree/bindings/ufs/ufs-mediatek.txt | 45 ---- > .../devicetree/bindings/ufs/ufs-qcom.txt | 63 ----- > .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 90 ------- > MAINTAINERS | 1 + > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 4 +- > arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 4 +- > .../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 1 - > arch/arm64/boot/dts/qcom/msm8996.dtsi | 3 +- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 3 - > 20 files changed, 614 insertions(+), 320 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.txt > create mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml > create mode 100644 Documentation/devicetree/bindings/ufs/hisilicon,ufs.yaml > create mode 100644 Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml > create mode 100644 Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > create mode 100644 Documentation/devicetree/bindings/ufs/snps,tc-dwc-g210.yaml > delete mode 100644 Documentation/devicetree/bindings/ufs/tc-dwc-g210-pltfrm.txt > create mode 100644 Documentation/devicetree/bindings/ufs/ufs-common.yaml > delete mode 100644 Documentation/devicetree/bindings/ufs/ufs-hisi.txt > delete mode 100644 Documentation/devicetree/bindings/ufs/ufs-mediatek.txt > delete mode 100644 Documentation/devicetree/bindings/ufs/ufs-qcom.txt > delete mode 100644 Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > > -- > 2.32.0 > >
Hello: This series was applied to qcom/linux.git (for-next) by Bjorn Andersson <bjorn.andersson@linaro.org>: On Sun, 6 Mar 2022 12:11:13 +0100 you wrote: > Hi, > > Not tested on hardware, so please kindly test. > Bindings maintainers might need checking - taken from git log. > > Changes since v2 > ================ > 1. Do not deprecate freq-table-hz, but instead update dtschema to accept > uint32-matrix. See: > https://github.com/devicetree-org/dt-schema/pull/69 > 2. Drop patches and changes related to freq-table-hz -> freq-table conversion. > 3. Add tags. > 4. Change maintainer of qcom,ufs. > > [...] Here is the summary with links: - [v3,01/12] dt-bindings: ufs: add common platform bindings (no matching commit) - [v3,02/12] dt-bindings: ufs: samsung,exynos-ufs: use common bindings (no matching commit) - [v3,03/12] dt-bindings: ufs: cdns,ufshc: convert to dtschema (no matching commit) - [v3,04/12] dt-bindings: ufs: drop unused/old ufs-qcom PHY bindings (no matching commit) - [v3,05/12] dt-bindings: ufs: qcom,ufs: convert to dtschema (no matching commit) - [v3,06/12] dt-bindings: ufs: hisilicon,ufs: convert to dtschema (no matching commit) - [v3,07/12] dt-bindings: ufs: mediatek,ufs: convert to dtschema (no matching commit) - [v3,08/12] dt-bindings: ufs: snps,tc-dwc-g210: convert to dtschema (no matching commit) - [v3,09/12] arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS (no matching commit) - [v3,10/12] arm64: dts: qcom: msm8996: drop unsupported UFS vddp-ref-clk-max-microamp https://git.kernel.org/qcom/c/b32846a38fc2 - [v3,11/12] arm64: dts: qcom: msm8996: correct UFS compatible https://git.kernel.org/qcom/c/64ff69842443 - [v3,12/12] arm64: dts: qcom: sm8350: drop duplicated ref_clk in UFS https://git.kernel.org/qcom/c/7ba57d11e5bb You are awesome, thank you!
Hi, Not tested on hardware, so please kindly test. Bindings maintainers might need checking - taken from git log. Changes since v2 ================ 1. Do not deprecate freq-table-hz, but instead update dtschema to accept uint32-matrix. See: https://github.com/devicetree-org/dt-schema/pull/69 2. Drop patches and changes related to freq-table-hz -> freq-table conversion. 3. Add tags. 4. Change maintainer of qcom,ufs. Changes since v1 ================ 1. Make freq-table as matrix of tuples (Nishanth). 2. New patches: convert all bindings and fix up DTS files. 3. Several minor fixes in UFS bindings. Dependencies ============ None dependencies. The DTS patches can go independently via respective maintainers. The dt-bindings patches could go via UFS tree. Best regards, Krzysztof Krzysztof Kozlowski (12): dt-bindings: ufs: add common platform bindings dt-bindings: ufs: samsung,exynos-ufs: use common bindings dt-bindings: ufs: cdns,ufshc: convert to dtschema dt-bindings: ufs: drop unused/old ufs-qcom PHY bindings dt-bindings: ufs: qcom,ufs: convert to dtschema dt-bindings: ufs: hisilicon,ufs: convert to dtschema dt-bindings: ufs: mediatek,ufs: convert to dtschema dt-bindings: ufs: snps,tc-dwc-g210: convert to dtschema arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS arm64: dts: qcom: msm8996: drop unsupported UFS vddp-ref-clk-max-microamp arm64: dts: qcom: msm8996: correct UFS compatible arm64: dts: qcom: sm8350: drop duplicated ref_clk in UFS .../devicetree/bindings/ufs/cdns,ufshc.txt | 32 --- .../devicetree/bindings/ufs/cdns,ufshc.yaml | 68 +++++ .../bindings/ufs/hisilicon,ufs.yaml | 90 +++++++ .../devicetree/bindings/ufs/mediatek,ufs.yaml | 67 +++++ .../devicetree/bindings/ufs/qcom,ufs.yaml | 242 ++++++++++++++++++ .../bindings/ufs/samsung,exynos-ufs.yaml | 13 +- .../bindings/ufs/snps,tc-dwc-g210.yaml | 51 ++++ .../bindings/ufs/tc-dwc-g210-pltfrm.txt | 26 -- .../devicetree/bindings/ufs/ti,j721e-ufs.yaml | 7 +- .../devicetree/bindings/ufs/ufs-common.yaml | 82 ++++++ .../devicetree/bindings/ufs/ufs-hisi.txt | 42 --- .../devicetree/bindings/ufs/ufs-mediatek.txt | 45 ---- .../devicetree/bindings/ufs/ufs-qcom.txt | 63 ----- .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 90 ------- MAINTAINERS | 1 + arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 4 +- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 4 +- .../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 1 - arch/arm64/boot/dts/qcom/msm8996.dtsi | 3 +- arch/arm64/boot/dts/qcom/sm8350.dtsi | 3 - 20 files changed, 614 insertions(+), 320 deletions(-) delete mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.txt create mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml create mode 100644 Documentation/devicetree/bindings/ufs/hisilicon,ufs.yaml create mode 100644 Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml create mode 100644 Documentation/devicetree/bindings/ufs/qcom,ufs.yaml create mode 100644 Documentation/devicetree/bindings/ufs/snps,tc-dwc-g210.yaml delete mode 100644 Documentation/devicetree/bindings/ufs/tc-dwc-g210-pltfrm.txt create mode 100644 Documentation/devicetree/bindings/ufs/ufs-common.yaml delete mode 100644 Documentation/devicetree/bindings/ufs/ufs-hisi.txt delete mode 100644 Documentation/devicetree/bindings/ufs/ufs-mediatek.txt delete mode 100644 Documentation/devicetree/bindings/ufs/ufs-qcom.txt delete mode 100644 Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt