| Message ID | 365d32c63c2fe080866be60c32dddd0f3634d19d.1645705789.git.geert@linux-m68k.org |
|---|---|
| State | Accepted |
| Commit | 36c11fee4fb5e5b4bf320d65957bbc21da9cd6d3 |
| Headers | show |
| Series | dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items | expand |
On 24/02/2022 12:31, Geert Uytterhoeven wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > make dt_binding_check: > > Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Hey Geert, I've run dt_binding_check locally but I dont get a warning, is there something I am missing? Thanks, Conor. > > Fixes: f1bd6661946b20d1 ("dt-bindings: i2c: add bindings for microchip mpfs i2c") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml > index c8e605fbb8a6b3d0..7bad4b946a349c8b 100644 > --- a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml > @@ -16,8 +16,8 @@ properties: > compatible: > oneOf: > - items: > - - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs > - - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core > + - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs > + - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core > - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core > > reg: > -- > 2.25.1 >
Hi Conor, On Thu, Feb 24, 2022 at 2:15 PM <Conor.Dooley@microchip.com> wrote: > On 24/02/2022 12:58, Geert Uytterhoeven wrote: > > On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote: > >> On 24/02/2022 12:31, Geert Uytterhoeven wrote: > >>> make dt_binding_check: > >>> > >>> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation) > >> > >> Hey Geert, > >> I've run dt_binding_check locally but I dont get a warning, is there > >> something I am missing? > > > > Interesting. Are you using the latest dtschema? > > https://github.com/devicetree-org/dt-schema.git > > I was on v2021.12, but have now tried v2022.01 & master > (2022.2.dev1+gf677c85). > > Is there something other than running "make dt_binding_check" in a fresh > checkout that I need to do? You did update your installation after the fresh[1] checkout? $ cd dt-schema $ pip3 install -e . [1] What about "git pull"? ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Feb 24, 2022 at 01:31:21PM +0100, Geert Uytterhoeven wrote: > make dt_binding_check: > > Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation) > > Fixes: f1bd6661946b20d1 ("dt-bindings: i2c: add bindings for microchip mpfs i2c") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
On 24/02/2022 13:43, Rob Herring wrote: > On Thu, Feb 24, 2022 at 02:34:18PM +0100, Geert Uytterhoeven wrote: >> Hi Conor, >> >> On Thu, Feb 24, 2022 at 2:15 PM <Conor.Dooley@microchip.com> wrote: >>> On 24/02/2022 12:58, Geert Uytterhoeven wrote: >>>> On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote: >>>>> On 24/02/2022 12:31, Geert Uytterhoeven wrote: >>>>>> make dt_binding_check: >>>>>> >>>>>> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation) >>>>> >>>>> Hey Geert, >>>>> I've run dt_binding_check locally but I dont get a warning, is there >>>>> something I am missing? >>>> >>>> Interesting. Are you using the latest dtschema? >>>> https://github.com/devicetree-org/dt-schema.git >>> >>> I was on v2021.12, but have now tried v2022.01 & master >>> (2022.2.dev1+gf677c85). >>> >>> Is there something other than running "make dt_binding_check" in a fresh >>> checkout that I need to do? >> >> You did update your installation after the fresh[1] checkout? >> >> $ cd dt-schema >> $ pip3 install -e . >> >> [1] What about "git pull"? ;-) > > yamllint is not installed. It's optional from the kbuild perspective. Safe to say I won't forget yamllint next time I do an os reinstall.. Thanks.
On 24/02/2022 12:31, Geert Uytterhoeven wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > make dt_binding_check: > > Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation) > > Fixes: f1bd6661946b20d1 ("dt-bindings: i2c: add bindings for microchip mpfs i2c") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> I assume its not required given Rob's, but FWIW: Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml > index c8e605fbb8a6b3d0..7bad4b946a349c8b 100644 > --- a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml > @@ -16,8 +16,8 @@ properties: > compatible: > oneOf: > - items: > - - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs > - - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core > + - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs > + - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core > - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core > > reg: > -- > 2.25.1 >
On Thu, Feb 24, 2022 at 01:31:21PM +0100, Geert Uytterhoeven wrote: > make dt_binding_check: > > Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation) > > Fixes: f1bd6661946b20d1 ("dt-bindings: i2c: add bindings for microchip mpfs i2c") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Applied to for-next, thanks!
diff --git a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml index c8e605fbb8a6b3d0..7bad4b946a349c8b 100644 --- a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml +++ b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml @@ -16,8 +16,8 @@ properties: compatible: oneOf: - items: - - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs - - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core + - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs + - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core reg:
make dt_binding_check: Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Fixes: f1bd6661946b20d1 ("dt-bindings: i2c: add bindings for microchip mpfs i2c") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)