diff mbox series

thermal: brcmstb_thermal: Interrupt is optional

Message ID 20210426213647.704823-1-f.fainelli@gmail.com
State Superseded
Headers show
Series thermal: brcmstb_thermal: Interrupt is optional | expand

Commit Message

Florian Fainelli April 26, 2021, 9:36 p.m. UTC
Utilize platform_get_irq_optional() to silence these messages:

brcmstb_thermal a581500.thermal: IRQ index 0 not found

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/thermal/broadcom/brcmstb_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli Sept. 16, 2021, 12:05 a.m. UTC | #1
On 4/26/2021 2:36 PM, Florian Fainelli wrote:
> Utilize platform_get_irq_optional() to silence these messages:

> 

> brcmstb_thermal a581500.thermal: IRQ index 0 not found

> 

> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>


This patch was never picked up and still applies. Daniel, can you pick 
it up?

Thanks!

> ---

>   drivers/thermal/broadcom/brcmstb_thermal.c | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c

> index 8df5edef1ded..0cedb8b4f00a 100644

> --- a/drivers/thermal/broadcom/brcmstb_thermal.c

> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c

> @@ -351,7 +351,7 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)

>   

>   	priv->thermal = thermal;

>   

> -	irq = platform_get_irq(pdev, 0);

> +	irq = platform_get_irq_optional(pdev, 0);

>   	if (irq >= 0) {

>   		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,

>   						brcmstb_tmon_irq_thread,

> 


-- 
Florian
Daniel Lezcano Sept. 17, 2021, 7:51 a.m. UTC | #2
Applied, thanks

On 16/09/2021 02:05, Florian Fainelli wrote:
> 

> 

> On 4/26/2021 2:36 PM, Florian Fainelli wrote:

>> Utilize platform_get_irq_optional() to silence these messages:

>>

>> brcmstb_thermal a581500.thermal: IRQ index 0 not found

>>

>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

> 

> This patch was never picked up and still applies. Daniel, can you pick

> it up?

> 

> Thanks!

> 

>> ---

>>   drivers/thermal/broadcom/brcmstb_thermal.c | 2 +-

>>   1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c

>> b/drivers/thermal/broadcom/brcmstb_thermal.c

>> index 8df5edef1ded..0cedb8b4f00a 100644

>> --- a/drivers/thermal/broadcom/brcmstb_thermal.c

>> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c

>> @@ -351,7 +351,7 @@ static int brcmstb_thermal_probe(struct

>> platform_device *pdev)

>>         priv->thermal = thermal;

>>   -    irq = platform_get_irq(pdev, 0);

>> +    irq = platform_get_irq_optional(pdev, 0);

>>       if (irq >= 0) {

>>           ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,

>>                           brcmstb_tmon_irq_thread,

>>

> 



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Florian Fainelli March 1, 2022, 6:05 p.m. UTC | #3
On 9/17/2021 12:51 AM, Daniel Lezcano wrote:
> 
> Applied, thanks

Was it applied? I still cannot find it in linux-next or Linus' tree.
Daniel Lezcano March 1, 2022, 8:47 p.m. UTC | #4
On 01/03/2022 19:05, Florian Fainelli wrote:
> 
> 
> On 9/17/2021 12:51 AM, Daniel Lezcano wrote:
>>
>> Applied, thanks
> 
> Was it applied? I still cannot find it in linux-next or Linus' tree.
I thought it was :/
Florian Fainelli March 1, 2022, 9:20 p.m. UTC | #5
On 3/1/2022 12:47 PM, Daniel Lezcano wrote:
> On 01/03/2022 19:05, Florian Fainelli wrote:
>>
>>
>> On 9/17/2021 12:51 AM, Daniel Lezcano wrote:
>>>
>>> Applied, thanks
>>
>> Was it applied? I still cannot find it in linux-next or Linus' tree.
> I thought it was :/

No worries, I just resent it:

https://lore.kernel.org/lkml/20220301181412.2008044-1-f.fainelli@gmail.com/
diff mbox series

Patch

diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
index 8df5edef1ded..0cedb8b4f00a 100644
--- a/drivers/thermal/broadcom/brcmstb_thermal.c
+++ b/drivers/thermal/broadcom/brcmstb_thermal.c
@@ -351,7 +351,7 @@  static int brcmstb_thermal_probe(struct platform_device *pdev)
 
 	priv->thermal = thermal;
 
-	irq = platform_get_irq(pdev, 0);
+	irq = platform_get_irq_optional(pdev, 0);
 	if (irq >= 0) {
 		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
 						brcmstb_tmon_irq_thread,