mbox series

[RESEND,v2,0/2] Introduces bypass charge type property

Message ID 20220210154108.641369-1-rriveram@opensource.cirrus.com
Headers show
Series Introduces bypass charge type property | expand

Message

Ricardo Rivera-Matos Feb. 10, 2022, 3:41 p.m. UTC 
Hello,

This patch series introduces a new POWER_SUPPLY_CHARGE_TYPE for bypass charging
operation.

In fast charging ICs, the bypass operation is used to bypass the charging path
around the charging IC's integrated power converter to its load. This allows
for "smart" wall adaptors (such as USB PPS standard power adaptors) to handle
the power conversion and heat dissipation externally.

Best Regards,
Ricardo

Ricardo Rivera-Matos (2):
  power: supply: Introduces bypass charging property
  power: supply: bq25980: Implements POWER_SUPPLY_CHARGE_TYPE_BYPASS

 drivers/power/supply/bq25980_charger.c    | 2 +-
 drivers/power/supply/power_supply_sysfs.c | 1 +
 include/linux/power_supply.h              | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

Comments

Ricardo Rivera-Matos Feb. 11, 2022, 9:46 p.m. UTC | #1 
Sebastian,

> On Feb 11, 2022, at 2:43 PM, Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
> 
> Hi,
> 
> On Thu, Feb 10, 2022 at 09:41:07AM -0600, Ricardo Rivera-Matos wrote:
>> Adds a POWER_SUPPLY_CHARGE_TYPE_BYPASS option to the POWER_SUPPLY_PROP_CHARGE_TYPE
>> property to facilitate bypass charging operation.
>> 
>> In bypass charging operation, the charger bypasses the charging path around the
>> integrated converter allowing for a "smart" wall adaptor to perform the power
>> conversion externally.
>> 
>> This operational mode is critical for the USB PPS standard of power adaptors and is
>> becoming a common feature in modern charging ICs such as:
>> 
>> - BQ25980
>> - BQ25975
>> - BQ25960
>> - LN8000
>> - LN8410
>> 
>> Signed-off-by: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
>> ---
> 
> Sorry for the wait. This needs to update the sysfs ABI documentation:
> 
> Documentation/ABI/testing/sysfs-class-power

Ack
> 
> I think your patch description is a good explanation for that file.
> Also I obviously missed to point this out for the "Long Life" charge
> type, so please also add a sentence for that so that the property
> is properly documented.

As I understand it “Long Life” means the charger reduces its charging rate in order to prolong the battery health.

Is this a fit explanation?
> 
> (Otherwise the patchset looks fine to me)
> 
> Thanks,
> 
> -- Sebastian

Best Regards,
Ricardo

<snip>
Sebastian Reichel Feb. 12, 2022, 3:44 a.m. UTC | #2 
Hi,

On Fri, Feb 11, 2022 at 03:46:52PM -0600, Rivera-Matos, Ricardo wrote:
> > I think your patch description is a good explanation for that file.
> > Also I obviously missed to point this out for the "Long Life" charge
> > type, so please also add a sentence for that so that the property
> > is properly documented.
> 
> As I understand it “Long Life” means the charger reduces its
> charging rate in order to prolong the battery health.
> 
> Is this a fit explanation?

Yes, thanks for taking care of it.

-- Sebastian
Ricardo Rivera-Matos Feb. 21, 2022, 5:50 p.m. UTC | #3 
Hello,

> On Feb 11, 2022, at 9:44 PM, Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
> 
> Hi,
> 
> On Fri, Feb 11, 2022 at 03:46:52PM -0600, Rivera-Matos, Ricardo wrote:
>>> I think your patch description is a good explanation for that file.
>>> Also I obviously missed to point this out for the "Long Life" charge
>>> type, so please also add a sentence for that so that the property
>>> is properly documented.
>> 
>> As I understand it “Long Life” means the charger reduces its
>> charging rate in order to prolong the battery health.
>> 
>> Is this a fit explanation?
> 
> Yes, thanks for taking care of it.

Ack.
> 
> -- Sebastian

Ricardo