| Message ID | 9a2f9da9fdc1893863f70b4294c7011bf739dd92.1645168567.git.quic_schowdhu@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Revert device tree changes for EUD | expand |
On Fri, Feb 18, 2022 at 01:21:35PM +0530, Souradeep Chowdhury wrote: > Revert the change to set the dr_mode for usb2 in case > of Embedded USB Debugger(EUD). > --- > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > index f40eaa5..9b991ba 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > @@ -61,10 +61,6 @@ > modem-init; > }; > > -&usb_2_dwc3 { > - dr_mode = "otg"; > -}; > - > &pmk8350_rtc { > status = "okay"; > }; > -- > 2.7.4 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On Fri, Feb 18, 2022 at 01:21:35PM +0530, Souradeep Chowdhury wrote: > Revert the change to set the dr_mode for usb2 in case > of Embedded USB Debugger(EUD). > --- > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ---- > 1 file changed, 4 deletions(-) Also, please use the normal format for reverting a change with the git id and the like. This is an odd style :( greg k-h
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts index f40eaa5..9b991ba 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts @@ -61,10 +61,6 @@ modem-init; }; -&usb_2_dwc3 { - dr_mode = "otg"; -}; - &pmk8350_rtc { status = "okay"; };