| Message ID | 20220216093112.92469-1-Jerome.Pouiller@silabs.com |
|---|---|
| Headers | show |
| Series | staging: wfx: apply SDIO suggestions | expand |
On Wednesday 16 February 2022 10:31:11 Jerome Pouiller wrote: > From: Jérôme Pouiller <jerome.pouiller@silabs.com> > > Some may think that SDIO_VENDOR_ID_SILABS / SDIO_DEVICE_ID_SILABS_WF200 > are official SDIO IDs. However, it is not the case, the values used by > WF200 are not official (BTW, the driver rely on the DT rather than on > the SDIO IDs to probe the device). > > To avoid any confusion, remove the definitions SDIO_*_ID_SILABS* and use > raw values. > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> Reviewed-by: Pali Rohár <pali@kernel.org> > --- > drivers/staging/wfx/bus_sdio.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c > index bc3df85a05b6..312d2d391a24 100644 > --- a/drivers/staging/wfx/bus_sdio.c > +++ b/drivers/staging/wfx/bus_sdio.c > @@ -257,10 +257,9 @@ static void wfx_sdio_remove(struct sdio_func *func) > sdio_release_host(func); > } > > -#define SDIO_VENDOR_ID_SILABS 0x0000 > -#define SDIO_DEVICE_ID_SILABS_WF200 0x1000 > static const struct sdio_device_id wfx_sdio_ids[] = { > - { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, > + /* WF200 does not have official VID/PID */ > + { SDIO_DEVICE(0x0000, 0x1000) }, > { }, > }; > MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > -- > 2.34.1 >
On Thursday 17 February 2022 16:04:51 CET Kalle Valo wrote: > Ulf Hansson <ulf.hansson@linaro.org> writes: > > On Thu, 17 Feb 2022 at 10:59, Kalle Valo <kvalo@kernel.org> wrote: > >> Jerome Pouiller <Jerome.Pouiller@silabs.com> writes: > >> > From: Jérôme Pouiller <jerome.pouiller@silabs.com> > >> > > >> > Until now, the SDIO quirks are applied directly from the driver. > >> > However, it is better to apply the quirks before driver probing. So, > >> > this patch relocate the quirks in the MMC framework. > >> > >> It would be good to know how this is better, what's the concrete > >> advantage? > > > > The mmc core has a quirk interface for all types of cards > > (eMMC/SD/SDIO), which thus keeps these things from sprinkling to > > drivers. In some cases, the quirk needs to be applied already during > > card initialization, which is earlier than when probing an SDIO func > > driver or the MMC block device driver. > > > > Perhaps it's a good idea to explain a bit about this in the commit message. > > I would add the whole paragraph to the commit log :) Arf, Greg has just pulled this patch into staging-testing. I assume it is too late to change the commit message.
From: Jérôme Pouiller <jerome.pouiller@silabs.com> Hi Ulf, Greg, The second patch of this series touch to the staging tree and to the MMC framework. I don't know what is the rule for these cases, but I think it makes more sense to carry this patch with the staging tree. Jérôme Pouiller (2): staging: wfx: WF200 has no official SDIO IDs staging: wfx: apply the necessary SDIO quirks for the Silabs WF200 drivers/mmc/core/quirks.h | 5 +++++ drivers/staging/wfx/bus_sdio.c | 8 ++------ 2 files changed, 7 insertions(+), 6 deletions(-)