| Message ID | 20220119204345.3769662-1-mka@chromium.org |
|---|---|
| Headers | show |
| Series | usb: misc: Add onboard_usb_hub driver | expand |
On Wed, Jan 19, 2022 at 12:43:45PM -0800, Matthias Kaehlcke wrote: > Add nodes for the onboard USB hub on trogdor devices. Remove the > 'always-on' property from the hub regulator, since the regulator > is now managed by the onboard_usb_hub driver. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > --- No DT maintainer approval yet? :(
On Tue, Feb 08, 2022 at 11:57:20AM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 19, 2022 at 12:43:45PM -0800, Matthias Kaehlcke wrote: > > Add nodes for the onboard USB hub on trogdor devices. Remove the > > 'always-on' property from the hub regulator, since the regulator > > is now managed by the onboard_usb_hub driver. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > --- > > No DT maintainer approval yet? :( Bjorn usually just picks DT changes into the QCOM tree when they are ready, so I wouldn't interpret anything into the lack of an explicit Ack.
On 15/02/2022 19:55, Greg Kroah-Hartman wrote: > On Tue, Feb 15, 2022 at 09:54:54AM -0800, Doug Anderson wrote: >> Hi, >> >> On Tue, Feb 8, 2022 at 11:21 AM Matthias Kaehlcke <mka@chromium.org> wrote: >>> >>> On Tue, Feb 08, 2022 at 11:57:20AM +0100, Greg Kroah-Hartman wrote: >>>> On Wed, Jan 19, 2022 at 12:43:45PM -0800, Matthias Kaehlcke wrote: >>>>> Add nodes for the onboard USB hub on trogdor devices. Remove the >>>>> 'always-on' property from the hub regulator, since the regulator >>>>> is now managed by the onboard_usb_hub driver. >>>>> >>>>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org> >>>>> Reviewed-by: Stephen Boyd <swboyd@chromium.org> >>>>> Reviewed-by: Douglas Anderson <dianders@chromium.org> >>>>> --- >>>> >>>> No DT maintainer approval yet? :( >>> >>> Bjorn usually just picks DT changes into the QCOM tree when they are >>> ready, so I wouldn't interpret anything into the lack of an explicit >>> Ack. >> >> Right, so the expectation is that this patch wouldn't land through the >> USB tree but would instead land through the Qualcomm tree, probably a >> revision after the code lands in the USB tree to avoid dependency >> problems. > > But our tools pick up the whole series. I can't just do "i will pick > patches 1-4 only" easily, and neither can any other maintainer. I don't have problems picking individual patches - either b4 am on each patch or on entire series and dropping later unneeded commits. > > Why not just get their ack so that I know it can come through the USB > tree? That's what normally happens for other changes like this where a > driver change is required first. DTS is a description of the hardware and we take it via separate branches of SoC-fami0ly repositories. These are always separated from the driver changes. Always. For several reasons: 1. By convention, 2. To be sure there is no dependency on driver code thus an ABI break, 3. To have a nice and clean history of DTS changes, properly organized. What is more, if this was coming via my Samsung SoC tree towards SoC folks, I could not take it in one branch. I would need to physically split it, otherwise Arnd/Olof would bounce back my pull request saying I am mixing DTS with driver. Of course you do not have such requirement - I am just saying that splitting DTS is quite common and proper way. Best regards, Krzysztof
On Tue 15 Feb 12:55 CST 2022, Greg Kroah-Hartman wrote: > On Tue, Feb 15, 2022 at 09:54:54AM -0800, Doug Anderson wrote: > > Hi, > > > > On Tue, Feb 8, 2022 at 11:21 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > > > On Tue, Feb 08, 2022 at 11:57:20AM +0100, Greg Kroah-Hartman wrote: > > > > On Wed, Jan 19, 2022 at 12:43:45PM -0800, Matthias Kaehlcke wrote: > > > > > Add nodes for the onboard USB hub on trogdor devices. Remove the > > > > > 'always-on' property from the hub regulator, since the regulator > > > > > is now managed by the onboard_usb_hub driver. > > > > > > > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > > > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > > > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > > > > --- > > > > > > > > No DT maintainer approval yet? :( > > > > > > Bjorn usually just picks DT changes into the QCOM tree when they are > > > ready, so I wouldn't interpret anything into the lack of an explicit > > > Ack. > > > > Right, so the expectation is that this patch wouldn't land through the > > USB tree but would instead land through the Qualcomm tree, probably a > > revision after the code lands in the USB tree to avoid dependency > > problems. > > But our tools pick up the whole series. I can't just do "i will pick > patches 1-4 only" easily, and neither can any other maintainer. > Most other maintainers uses -P to selectively pick the patches that applies to their subsystem. That said, I really do recognize the inconvenience on your part and the number of patches being sent your way. > Why not just get their ack so that I know it can come through the USB > tree? That's what normally happens for other changes like this where a > driver change is required first. > Because while the change looks good I don't think it's fine to take it through the USB tree - the dts tree typically looks like a shotgun hit across the dts files. And you and I have already seen several times that dts changes do conflict when you take some of them in the USB tree. Unfortunately I see only two ways around this problem, either you start picking selectively or I manage to convince all contributors that they must split their series to keep dts changes separate (which isn't a bad idea in itself). Regards, Bjorn