diff mbox series

[v2,2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible

Message ID 20220207230638.56730-3-git@apitzsch.eu
State Superseded
Headers show
Series Add support for ocp8110 flash | expand

Commit Message

André Apitzsch Feb. 7, 2022, 11:06 p.m. UTC
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

André Apitzsch Feb. 12, 2022, 1:13 p.m. UTC | #1
Am Freitag, dem 11.02.2022 um 10:34 -0600 schrieb Rob Herring:
> On Tue, Feb 08, 2022 at 12:06:37AM +0100, André Apitzsch wrote:
> > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> 
> Commit msg? What's this h/w?
> 
Thanks for the feedback.

Would the following message be sufficient?

"""
dt-bindings: leds: sgm3140: Document ocp8110 compatible

Add devicetree binding for Orient Chip OCP8110 charge pump used for
camera flash LEDs.
"""

> > ---
> >  Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index f68259619488..1c345cf16d08 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -18,7 +18,9 @@ description: |
> >  
> >  properties:
> >    compatible:
> > -    const: sgmicro,sgm3140
> > +    enum:
> > +      - ocs,ocp8110
> > +      - sgmicro,sgm3140
> >  
> >    enable-gpios:
> >      maxItems: 1
> > -- 
> > 2.35.1
> > 
> >
Pavel Machek Feb. 12, 2022, 5:03 p.m. UTC | #2
On Sat 2022-02-12 14:13:32, André Apitzsch wrote:
> Am Freitag, dem 11.02.2022 um 10:34 -0600 schrieb Rob Herring:
> > On Tue, Feb 08, 2022 at 12:06:37AM +0100, André Apitzsch wrote:
> > > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> > 
> > Commit msg? What's this h/w?
> > 
> Thanks for the feedback.
> 
> Would the following message be sufficient?
> 
> """
> dt-bindings: leds: sgm3140: Document ocp8110 compatible
> 
> Add devicetree binding for Orient Chip OCP8110 charge pump used for
> camera flash LEDs.
> """

Sounds good to me.
							Pavel
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
index f68259619488..1c345cf16d08 100644
--- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
@@ -18,7 +18,9 @@  description: |
 
 properties:
   compatible:
-    const: sgmicro,sgm3140
+    enum:
+      - ocs,ocp8110
+      - sgmicro,sgm3140
 
   enable-gpios:
     maxItems: 1