| Message ID | 20220208172514.3481-9-bvanassche@acm.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Remove the SCSI pointer from struct scsi_cmnd | expand |
> On Feb 8, 2022, at 9:24 AM, Bart Van Assche <bvanassche@acm.org> wrote: > > None of the 53c700 drivers uses the SCSI pointer. Hence remove the code > from 53c700.c that clears two SCSI pointer fields. The 53c700 drivers are: > > $ git grep -nHE 'include.*53c700' > drivers/scsi/53c700.c:132:#include "53c700.h" > drivers/scsi/53c700.c:153:#include "53c700_d.h" > drivers/scsi/a4000t.c:22:#include "53c700.h" > drivers/scsi/bvme6000_scsi.c:23:#include "53c700.h" > drivers/scsi/lasi700.c:43:#include "53c700.h" > drivers/scsi/mvme16x_scsi.c:23:#include "53c700.h" > drivers/scsi/sim710.c:29:#include "53c700.h" > drivers/scsi/sni_53c710.c:38:#include "53c700.h" > drivers/scsi/zorro7xx.c:25:#include "53c700.h" > > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/53c700.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c > index ad4972c0fc53..e1e4f9d10887 100644 > --- a/drivers/scsi/53c700.c > +++ b/drivers/scsi/53c700.c > @@ -1791,8 +1791,6 @@ static int NCR_700_queuecommand_lck(struct scsi_cmnd *SCp) > slot->cmnd = SCp; > > SCp->host_scribble = (unsigned char *)slot; > - SCp->SCp.ptr = NULL; > - SCp->SCp.buffer = NULL; > > #ifdef NCR_700_DEBUG > printk("53c700: scsi%d, command ", SCp->device->host->host_no); Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> -- Himanshu Madhani Oracle Linux Engineering
On 2/8/22 18:24, Bart Van Assche wrote: > None of the 53c700 drivers uses the SCSI pointer. Hence remove the code > from 53c700.c that clears two SCSI pointer fields. The 53c700 drivers are: > > $ git grep -nHE 'include.*53c700' > drivers/scsi/53c700.c:132:#include "53c700.h" > drivers/scsi/53c700.c:153:#include "53c700_d.h" > drivers/scsi/a4000t.c:22:#include "53c700.h" > drivers/scsi/bvme6000_scsi.c:23:#include "53c700.h" > drivers/scsi/lasi700.c:43:#include "53c700.h" > drivers/scsi/mvme16x_scsi.c:23:#include "53c700.h" > drivers/scsi/sim710.c:29:#include "53c700.h" > drivers/scsi/sni_53c710.c:38:#include "53c700.h" > drivers/scsi/zorro7xx.c:25:#include "53c700.h" > > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/53c700.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c > index ad4972c0fc53..e1e4f9d10887 100644 > --- a/drivers/scsi/53c700.c > +++ b/drivers/scsi/53c700.c > @@ -1791,8 +1791,6 @@ static int NCR_700_queuecommand_lck(struct scsi_cmnd *SCp) > slot->cmnd = SCp; > > SCp->host_scribble = (unsigned char *)slot; > - SCp->SCp.ptr = NULL; > - SCp->SCp.buffer = NULL; > > #ifdef NCR_700_DEBUG > printk("53c700: scsi%d, command ", SCp->device->host->host_no); Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c index ad4972c0fc53..e1e4f9d10887 100644 --- a/drivers/scsi/53c700.c +++ b/drivers/scsi/53c700.c @@ -1791,8 +1791,6 @@ static int NCR_700_queuecommand_lck(struct scsi_cmnd *SCp) slot->cmnd = SCp; SCp->host_scribble = (unsigned char *)slot; - SCp->SCp.ptr = NULL; - SCp->SCp.buffer = NULL; #ifdef NCR_700_DEBUG printk("53c700: scsi%d, command ", SCp->device->host->host_no);