| Message ID | 20211211175951.30763-1-luca@lucaceresoli.net |
|---|---|
| Headers | show |
| Series | Add MAX77714 PMIC minimal driver (RTC and watchdog only) | expand |
Hi All, On 11/12/21 18:59, Luca Ceresoli wrote: > Hi, > > this series adds minimal drivers for the Maxim Semiconductor MAX77714 > (https://www.maximintegrated.com/en/products/power/power-management-ics/MAX77714.html). > Only RTC and watchdog are implemented by these patches. > > All implemented functionality is tested and working: RTC read/write, > watchdog start/stop/ping/set_timeout. > > Patches 1-3 + 6 are trivial cleanups to the max77686 drivers and Kconfig > indentation and can probably be applied easily. > > Patches 4, 5, 7, 8 and 9 add: dt bindings, mfd driver, watchdog driver and > rtc driver. A gentle ping about this series. It's at v5, all patches have at least one ack/review tag and most patches are unchanged since ~v2. It applies cleanly on current master. Is there anything I should do to help making progress? Regards,
Hi Lee, all, On 11/01/22 11:10, Luca Ceresoli wrote: > Hi All, > > On 11/12/21 18:59, Luca Ceresoli wrote: >> Hi, >> >> this series adds minimal drivers for the Maxim Semiconductor MAX77714 >> (https://www.maximintegrated.com/en/products/power/power-management-ics/MAX77714.html). >> Only RTC and watchdog are implemented by these patches. >> >> All implemented functionality is tested and working: RTC read/write, >> watchdog start/stop/ping/set_timeout. >> >> Patches 1-3 + 6 are trivial cleanups to the max77686 drivers and Kconfig >> indentation and can probably be applied easily. >> >> Patches 4, 5, 7, 8 and 9 add: dt bindings, mfd driver, watchdog driver and >> rtc driver. > > A gentle ping about this series. It's at v5, all patches have at least > one ack/review tag and most patches are unchanged since ~v2. It applies > cleanly on current master. > > Is there anything I should do to help making progress? Apologies for pinging again... but as I got no further comments about these patches I guess I can really do nothing at the moment. Lee, is this series completely in charge to you or should it be applied by the respective subsystem maintainers? Thanks.
On 1/29/22 00:40, Luca Ceresoli wrote: > Hi Lee, all, > > On 11/01/22 11:10, Luca Ceresoli wrote: >> Hi All, >> >> On 11/12/21 18:59, Luca Ceresoli wrote: >>> Hi, >>> >>> this series adds minimal drivers for the Maxim Semiconductor MAX77714 >>> (https://www.maximintegrated.com/en/products/power/power-management-ics/MAX77714.html). >>> Only RTC and watchdog are implemented by these patches. >>> >>> All implemented functionality is tested and working: RTC read/write, >>> watchdog start/stop/ping/set_timeout. >>> >>> Patches 1-3 + 6 are trivial cleanups to the max77686 drivers and Kconfig >>> indentation and can probably be applied easily. >>> >>> Patches 4, 5, 7, 8 and 9 add: dt bindings, mfd driver, watchdog driver and >>> rtc driver. >> >> A gentle ping about this series. It's at v5, all patches have at least >> one ack/review tag and most patches are unchanged since ~v2. It applies >> cleanly on current master. >> >> Is there anything I should do to help making progress? > > Apologies for pinging again... but as I got no further comments about > these patches I guess I can really do nothing at the moment. > > Lee, is this series completely in charge to you or should it be applied > by the respective subsystem maintainers? > I hesitated to take the watchdog patches because an earlier patch of the series introduces MFD_MAX77714 and the watchdog Kconfig entry lists it as dependency. I now added patch 7/9 and 8/9 to my watchdog-next tree anyway. If the mfd part doesn't make it we can still decide to take it out at some point. Note that patch 6/9 has already been applied. Guenter
Hi Guenter, On 30/01/22 02:48, Guenter Roeck wrote: > On 1/29/22 00:40, Luca Ceresoli wrote: >> Hi Lee, all, >> >> On 11/01/22 11:10, Luca Ceresoli wrote: >>> Hi All, >>> >>> On 11/12/21 18:59, Luca Ceresoli wrote: >>>> Hi, >>>> >>>> this series adds minimal drivers for the Maxim Semiconductor MAX77714 >>>> (https://www.maximintegrated.com/en/products/power/power-management-ics/MAX77714.html). >>>> >>>> Only RTC and watchdog are implemented by these patches. >>>> >>>> All implemented functionality is tested and working: RTC read/write, >>>> watchdog start/stop/ping/set_timeout. >>>> >>>> Patches 1-3 + 6 are trivial cleanups to the max77686 drivers and >>>> Kconfig >>>> indentation and can probably be applied easily. >>>> >>>> Patches 4, 5, 7, 8 and 9 add: dt bindings, mfd driver, watchdog >>>> driver and >>>> rtc driver. >>> >>> A gentle ping about this series. It's at v5, all patches have at least >>> one ack/review tag and most patches are unchanged since ~v2. It applies >>> cleanly on current master. >>> >>> Is there anything I should do to help making progress? >> >> Apologies for pinging again... but as I got no further comments about >> these patches I guess I can really do nothing at the moment. >> >> Lee, is this series completely in charge to you or should it be applied >> by the respective subsystem maintainers? >> > > I hesitated to take the watchdog patches because an earlier patch of the > series > introduces MFD_MAX77714 and the watchdog Kconfig entry lists it as > dependency. > I now added patch 7/9 and 8/9 to my watchdog-next tree anyway. If the > mfd part > doesn't make it we can still decide to take it out at some point. OK, thank you! In the meanwhile the kernel test robot also reported a build failure due to missing max77714.h file, which is added by patch 5. > Note that patch 6/9 has already been applied. Indeed, it's in Linus' master already. Regards.
On 1/30/22 04:45, Luca Ceresoli wrote: > Hi Guenter, > > On 30/01/22 02:48, Guenter Roeck wrote: >> On 1/29/22 00:40, Luca Ceresoli wrote: >>> Hi Lee, all, >>> >>> On 11/01/22 11:10, Luca Ceresoli wrote: >>>> Hi All, >>>> >>>> On 11/12/21 18:59, Luca Ceresoli wrote: >>>>> Hi, >>>>> >>>>> this series adds minimal drivers for the Maxim Semiconductor MAX77714 >>>>> (https://www.maximintegrated.com/en/products/power/power-management-ics/MAX77714.html). >>>>> >>>>> Only RTC and watchdog are implemented by these patches. >>>>> >>>>> All implemented functionality is tested and working: RTC read/write, >>>>> watchdog start/stop/ping/set_timeout. >>>>> >>>>> Patches 1-3 + 6 are trivial cleanups to the max77686 drivers and >>>>> Kconfig >>>>> indentation and can probably be applied easily. >>>>> >>>>> Patches 4, 5, 7, 8 and 9 add: dt bindings, mfd driver, watchdog >>>>> driver and >>>>> rtc driver. >>>> >>>> A gentle ping about this series. It's at v5, all patches have at least >>>> one ack/review tag and most patches are unchanged since ~v2. It applies >>>> cleanly on current master. >>>> >>>> Is there anything I should do to help making progress? >>> >>> Apologies for pinging again... but as I got no further comments about >>> these patches I guess I can really do nothing at the moment. >>> >>> Lee, is this series completely in charge to you or should it be applied >>> by the respective subsystem maintainers? >>> >> >> I hesitated to take the watchdog patches because an earlier patch of the >> series >> introduces MFD_MAX77714 and the watchdog Kconfig entry lists it as >> dependency. >> I now added patch 7/9 and 8/9 to my watchdog-next tree anyway. If the >> mfd part >> doesn't make it we can still decide to take it out at some point. > > OK, thank you! In the meanwhile the kernel test robot also reported a > build failure due to missing max77714.h file, which is added by patch 5. > Yes, I noticed. Which means I'll have to drop the patch again, and we'll have to wait for the mfd patch to land, sorry. Guenter >> Note that patch 6/9 has already been applied. > > Indeed, it's in Linus' master already. > > Regards.
Hi, this series adds minimal drivers for the Maxim Semiconductor MAX77714 (https://www.maximintegrated.com/en/products/power/power-management-ics/MAX77714.html). Only RTC and watchdog are implemented by these patches. All implemented functionality is tested and working: RTC read/write, watchdog start/stop/ping/set_timeout. Patches 1-3 + 6 are trivial cleanups to the max77686 drivers and Kconfig indentation and can probably be applied easily. Patches 4, 5, 7, 8 and 9 add: dt bindings, mfd driver, watchdog driver and rtc driver. Changes in v5: - patch 7: fix (and simplify) watchdog_info code - patch 8: remove amibguity in comment Changes in v4: - do not add a new wdog driver for MAX77714, extend the MAX77620 wdog driver; this means removing v3 patch 7, now replaced by patches 7+8 - added review tags Changes in v3: - fixed all issues reported on v1 patches - removed patch 1 of v2, already applied ("mfd: max77686: Correct tab-based alignment of register addresses") Changes in v2: - fixed all issues reported on v1 patches - added patch 7 ("watchdog: Kconfig: fix help text indentation") - additional minor improvements Luca Luca Ceresoli (9): rtc: max77686: convert comments to kernel-doc format rtc: max77686: rename day-of-month defines rtc: max77686: remove unused code to read in 12-hour mode dt-bindings: mfd: add Maxim MAX77714 PMIC mfd: max77714: Add driver for Maxim MAX77714 PMIC watchdog: Kconfig: fix help text indentation watchdog: max77620: add support for the max77714 variant watchdog: max77620: add comment to clarify set_timeout procedure rtc: max77686: add MAX77714 support .../bindings/mfd/maxim,max77714.yaml | 68 ++++++++ MAINTAINERS | 7 + drivers/mfd/Kconfig | 14 ++ drivers/mfd/Makefile | 1 + drivers/mfd/max77686.c | 2 +- drivers/mfd/max77714.c | 152 ++++++++++++++++++ drivers/rtc/Kconfig | 2 +- drivers/rtc/rtc-max77686.c | 75 +++++---- drivers/watchdog/Kconfig | 50 +++--- drivers/watchdog/max77620_wdt.c | 85 ++++++++-- include/linux/mfd/max77686-private.h | 4 +- include/linux/mfd/max77714.h | 60 +++++++ 12 files changed, 445 insertions(+), 75 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77714.yaml create mode 100644 drivers/mfd/max77714.c create mode 100644 include/linux/mfd/max77714.h