| Message ID | 20220127113303.3012207-4-bigeasy@linutronix.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Provide and use generic_handle_irq_safe() where appropriate. | expand |
Hi, On 1/27/22 12:32, Sebastian Andrzej Siewior wrote: > Instead of manually disabling interrupts before invoking use > generic_handle_irq() which can be invoked with enabled and disabled > interrupts. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/i2c/busses/i2c-cht-wc.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c > index 1cf68f85b2e11..8ccf0c928bb44 100644 > --- a/drivers/i2c/busses/i2c-cht-wc.c > +++ b/drivers/i2c/busses/i2c-cht-wc.c > @@ -99,15 +99,8 @@ static irqreturn_t cht_wc_i2c_adap_thread_handler(int id, void *data) > * interrupt handler as well, so running the client irq handler from > * this thread will cause things to lock up. > */ > - if (reg & CHT_WC_EXTCHGRIRQ_CLIENT_IRQ) { > - /* > - * generic_handle_irq expects local IRQs to be disabled > - * as normally it is called from interrupt context. > - */ > - local_irq_disable(); > - generic_handle_irq(adap->client_irq); > - local_irq_enable(); > - } > + if (reg & CHT_WC_EXTCHGRIRQ_CLIENT_IRQ) > + generic_handle_irq_safe(adap->client_irq); > > return IRQ_HANDLED; > } >
On 2022-01-27 18:16:53 [+0100], Wolfram Sang wrote: > On Thu, Jan 27, 2022 at 12:32:59PM +0100, Sebastian Andrzej Siewior wrote: > > Instead of manually disabling interrupts before invoking use > > generic_handle_irq() which can be invoked with enabled and disabled > > generic_handle_irq_safe() Yes, thank you. Sebastian
diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c index 1cf68f85b2e11..8ccf0c928bb44 100644 --- a/drivers/i2c/busses/i2c-cht-wc.c +++ b/drivers/i2c/busses/i2c-cht-wc.c @@ -99,15 +99,8 @@ static irqreturn_t cht_wc_i2c_adap_thread_handler(int id, void *data) * interrupt handler as well, so running the client irq handler from * this thread will cause things to lock up. */ - if (reg & CHT_WC_EXTCHGRIRQ_CLIENT_IRQ) { - /* - * generic_handle_irq expects local IRQs to be disabled - * as normally it is called from interrupt context. - */ - local_irq_disable(); - generic_handle_irq(adap->client_irq); - local_irq_enable(); - } + if (reg & CHT_WC_EXTCHGRIRQ_CLIENT_IRQ) + generic_handle_irq_safe(adap->client_irq); return IRQ_HANDLED; }
Instead of manually disabling interrupts before invoking use generic_handle_irq() which can be invoked with enabled and disabled interrupts. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/i2c/busses/i2c-cht-wc.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)