| Message ID | 57f831e4e1d45b7d81bc4cf4a94946db57360366.1396013927.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Friday, March 28, 2014 07:11:44 PM Viresh Kumar wrote: > .driver_data field is only required to be filled if drivers want to preserve > some data in there which they can use according to the value of .frequency > field. But this driver isn't using this field at all, but just setting it equal > to the index value. Which isn't required. Fix it. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> All four queued up for the next pull request, thanks! > --- > V1->V2: No Change > > Hi Rafael, > > To avoid confusion I am sending all related cpufreq patches again. > > drivers/cpufreq/ia64-acpi-cpufreq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c > index a22b5d1..beb191b 100644 > --- a/drivers/cpufreq/ia64-acpi-cpufreq.c > +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c > @@ -275,7 +275,6 @@ acpi_cpufreq_cpu_init ( > /* table init */ > for (i = 0; i <= data->acpi_data.state_count; i++) > { > - data->freq_table[i].driver_data = i; > if (i < data->acpi_data.state_count) { > data->freq_table[i].frequency = > data->acpi_data.states[i].core_frequency * 1000; >
diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c index a22b5d1..beb191b 100644 --- a/drivers/cpufreq/ia64-acpi-cpufreq.c +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c @@ -275,7 +275,6 @@ acpi_cpufreq_cpu_init ( /* table init */ for (i = 0; i <= data->acpi_data.state_count; i++) { - data->freq_table[i].driver_data = i; if (i < data->acpi_data.state_count) { data->freq_table[i].frequency = data->acpi_data.states[i].core_frequency * 1000;
.driver_data field is only required to be filled if drivers want to preserve some data in there which they can use according to the value of .frequency field. But this driver isn't using this field at all, but just setting it equal to the index value. Which isn't required. Fix it. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- V1->V2: No Change Hi Rafael, To avoid confusion I am sending all related cpufreq patches again. drivers/cpufreq/ia64-acpi-cpufreq.c | 1 - 1 file changed, 1 deletion(-)