| Message ID | 20211216224611.440397-1-iam@valdikss.org.ru |
|---|---|
| Headers | show |
| Series | HID: lenovo: ThinkPad TrackPoint Keyboard II support | expand |
On Fri, 17 Dec 2021, ValdikSS wrote: > This patchset adds support for Lenovo ThinkPad TrackPoint Keyboard II, > in both USB and Bluetooth modes. > > It brings additional functional keys mapping, native vertical and horizontal > scrolling, trackpoint sensitivity configuration and Fn-Lock sync. > > There is no code difference between the previous patchset, only minor > patch subject changes and code/comments split. > > ValdikSS (3): > HID: lenovo: Add support for ThinkPad TrackPoint Keyboard II > HID: lenovo: Sync Fn-lock state on button press for Compact and > TrackPoint II keyboards > HID: lenovo: Add note about different report numbers Thanks for the patches. Could you however, please, resubmit with your real name, as outlined in Documentation/process/submitting-patches.rst ?
On 22-01-21 16:24:37, Jiri Kosina wrote: >On Fri, 21 Jan 2022, Florian Klink wrote: > >> I tested the driver and it's a big improvement. I just sent a v3 with my >> name in the Signed-Off-By field. > >Thanks. Where did you send it to? :) I don't seem to have it in my inbox. Message-Id 20220121123206.36978-1-flokli@flokli.de and following, it's also visible on https://lore.kernel.org/all/20220121123206.36978-1-flokli@flokli.de/ Florian
>> >> I tested the driver and it's a big improvement. I just sent a v3 with my >> >> name in the Signed-Off-By field. >> > >> >Thanks. Where did you send it to? :) I don't seem to have it in my inbox. >> >> Message-Id 20220121123206.36978-1-flokli@flokli.de and following, it's >> also visible on >> https://lore.kernel.org/all/20220121123206.36978-1-flokli@flokli.de/ > >I see; please always CC the maintainers of the code directly as well, >otherwise the patch might fall in between cracks easily. Oops, I forgot to copy the CC list again while invoking git send-email. I now also bounced the three mails over to you manually. Let me know if there's anything else left to be done :-)
Hey ValdikSS, >This patchset adds support for Lenovo ThinkPad TrackPoint Keyboard II, >in both USB and Bluetooth modes. > >It brings additional functional keys mapping, native vertical and horizontal >scrolling, trackpoint sensitivity configuration and Fn-Lock sync. Quick follow-up question on this - did you do any tinkering with battery status? I realized there's a /sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb6/6-2/6-2:1.1/0003:17EF:60EE.001F/power_supply/hid-0003:17EF:60EE.001F-battery in my system, which knows about model_name, but things like "capacity" and "status" return a "No data available". Regards, Florian
On 24.01.2022 15:24, Florian Klink wrote: > Hey ValdikSS, > >> This patchset adds support for Lenovo ThinkPad TrackPoint Keyboard II, >> in both USB and Bluetooth modes. >> >> It brings additional functional keys mapping, native vertical and >> horizontal >> scrolling, trackpoint sensitivity configuration and Fn-Lock sync. > > Quick follow-up question on this - did you do any tinkering with battery > status? > > I realized there's a > /sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb6/6-2/6-2:1.1/0003:17EF:60EE.001F/power_supply/hid-0003:17EF:60EE.001F-battery > > in my system, which knows about model_name, but things like "capacity" > and "status" return a "No data available". > Hello, no, I didn't do anything. It works for me just fine, it shows battery status in KDE applet.
On 24.01.2022 16:07, ValdikSS wrote: > On 24.01.2022 15:24, Florian Klink wrote: >> Hey ValdikSS, >> >>> This patchset adds support for Lenovo ThinkPad TrackPoint Keyboard II, >>> in both USB and Bluetooth modes. >>> >>> It brings additional functional keys mapping, native vertical and >>> horizontal >>> scrolling, trackpoint sensitivity configuration and Fn-Lock sync. >> >> Quick follow-up question on this - did you do any tinkering with battery >> status? >> >> I realized there's a >> /sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb6/6-2/6-2:1.1/0003:17EF:60EE.001F/power_supply/hid-0003:17EF:60EE.001F-battery >> >> in my system, which knows about model_name, but things like "capacity" >> and "status" return a "No data available". >> > > Hello, no, I didn't do anything. It works for me just fine, it shows > battery status in KDE applet. Note: I'm using the keyboard over Bluetooth.
On 22-01-24 16:08:03, ValdikSS wrote: >On 24.01.2022 16:07, ValdikSS wrote: >>On 24.01.2022 15:24, Florian Klink wrote: >>>Hey ValdikSS, >>> >>>>This patchset adds support for Lenovo ThinkPad TrackPoint Keyboard II, >>>>in both USB and Bluetooth modes. >>>> >>>>It brings additional functional keys mapping, native vertical >>>>and horizontal >>>>scrolling, trackpoint sensitivity configuration and Fn-Lock sync. >>> >>>Quick follow-up question on this - did you do any tinkering with battery >>>status? >>> >>>I realized there's a >>>/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb6/6-2/6-2:1.1/0003:17EF:60EE.001F/power_supply/hid-0003:17EF:60EE.001F-battery >>> >>>in my system, which knows about model_name, but things like "capacity" >>>and "status" return a "No data available". >>> >> >>Hello, no, I didn't do anything. It works for me just fine, it shows >>battery status in KDE applet. > >Note: I'm using the keyboard over Bluetooth. Hm, over bluetooth, there's a `/sys/devices/virtual/misc/uhid/0005:17EF:60E1.0030/power_supply/hid-*-battery` directory with the same files, and they also have the same "No data available" thing. For now I'll just assume it's due to the controller internally still calibrating and not exposing anything - the keyboard is fairly new. Thanks for confirming it should work in theory :-)
>>>>Quick follow-up question on this - did you do any tinkering with battery >>>>status? >>>> >>>>I realized there's a >>>>/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb6/6-2/6-2:1.1/0003:17EF:60EE.001F/power_supply/hid-0003:17EF:60EE.001F-battery >>>> >>>>in my system, which knows about model_name, but things like "capacity" >>>>and "status" return a "No data available". >>>> >>> >>>Hello, no, I didn't do anything. It works for me just fine, it >>>shows battery status in KDE applet. >> >>Note: I'm using the keyboard over Bluetooth. > >Hm, over bluetooth, there's a `/sys/devices/virtual/misc/uhid/0005:17EF:60E1.0030/power_supply/hid-*-battery` directory with the same files, and they also have the same "No data available" thing. > >For now I'll just assume it's due to the controller internally still >calibrating and not exposing anything - the keyboard is fairly new. > >Thanks for confirming it should work in theory :-) Alright, I now also see battery levels (that also go down after continued use) - needed to enable upower on my system. Works like a charm! Florian
This patchset adds support for Lenovo ThinkPad TrackPoint Keyboard II, in both USB and Bluetooth modes. It brings additional functional keys mapping, native vertical and horizontal scrolling, trackpoint sensitivity configuration and Fn-Lock sync. There is no code difference between the previous patchset, only minor patch subject changes and code/comments split. ValdikSS (3): HID: lenovo: Add support for ThinkPad TrackPoint Keyboard II HID: lenovo: Sync Fn-lock state on button press for Compact and TrackPoint II keyboards HID: lenovo: Add note about different report numbers drivers/hid/hid-ids.h | 2 + drivers/hid/hid-lenovo.c | 174 +++++++++++++++++++++++++++++++++++++-- 2 files changed, 170 insertions(+), 6 deletions(-)