| Message ID | 20220120192438.25555-1-alim.akhtar@samsung.com |
|---|---|
| Headers | show |
| Series | Add FSD SPI support | expand |
On 20/01/2022 20:24, Alim Akhtar wrote: > Adds spi controller dt-binding compatible information for > Tesla Full Self-Driving (FSD) SoC. > > Cc: linux-fsd@tesla.com > Signed-off-by: Adithya K V <adithya.kv@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > Documentation/devicetree/bindings/spi/samsung,spi.yaml | 1 + > 1 file changed, 1 insertion(+) I think you forgot to mention - in cover letter - that this depends on my Samsung SPI bindings conversion to dtschema. I'll be sending v6 of it after merge window, with minor changes. > > diff --git a/Documentation/devicetree/bindings/spi/samsung,spi.yaml b/Documentation/devicetree/bindings/spi/samsung,spi.yaml > index 61c77088e8ee..bf9a76d931d2 100644 > --- a/Documentation/devicetree/bindings/spi/samsung,spi.yaml > +++ b/Documentation/devicetree/bindings/spi/samsung,spi.yaml > @@ -21,6 +21,7 @@ properties: > - samsung,s3c6410-spi > - samsung,s5pv210-spi # for S5PV210 and S5PC110 > - samsung,exynos5433-spi > + - tesla,fsd-spi > - const: samsung,exynos7-spi > deprecated: true > > Best regards, Krzysztof
On 20/01/2022 20:24, Alim Akhtar wrote: > Adds spi controller dt-binding compatible information for > Tesla Full Self-Driving (FSD) SoC. > > Cc: linux-fsd@tesla.com > Signed-off-by: Adithya K V <adithya.kv@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > Documentation/devicetree/bindings/spi/samsung,spi.yaml | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
Hi Krzysztof and Alim, On Fri, Jan 21, 2022 at 07:33:15PM +0100, Krzysztof Kozlowski wrote: > On 20/01/2022 20:24, Alim Akhtar wrote: > > Adds spi controller dt-binding compatible information for > > Tesla Full Self-Driving (FSD) SoC. > > > > Cc: linux-fsd@tesla.com > > Signed-off-by: Adithya K V <adithya.kv@samsung.com> > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > --- > > Documentation/devicetree/bindings/spi/samsung,spi.yaml | 1 + > > 1 file changed, 1 insertion(+) > > I think you forgot to mention - in cover letter - that this depends on > my Samsung SPI bindings conversion to dtschema. It's written in the cover letter: "Note: This series is depended on [1] patches which adds support of FSD SoC and on Krzysztof's v5 [2] of spi schema changes" Alim, you can also add: Reviewed-by: Andi Shyti <andi@etezian.org> Thank you, Andi
Thanks Andi for review >-----Original Message----- >From: Andi Shyti [mailto:andi@etezian.org] >Sent: Saturday, January 22, 2022 4:13 PM >To: Alim Akhtar <alim.akhtar@samsung.com> >Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; >devicetree@vger.kernel.org; linus.walleij@linaro.org; robh+dt@kernel.org; >krzysztof.kozlowski@canonical.com; linux-samsung-soc@vger.kernel.org; >pankaj.dubey@samsung.com; broonie@kernel.org; andi@etezian.org; linux- >spi@vger.kernel.org; Aswani Reddy <aswani.reddy@samsung.com>; linux- >fsd@tesla.com >Subject: Re: [PATCH v2 3/3] arm64: dts: fsd: Add SPI device nodes > >Hi Alim and Aswani, > >On Fri, Jan 21, 2022 at 12:54:38AM +0530, Alim Akhtar wrote: >> From: Aswani Reddy <aswani.reddy@samsung.com> >> >> Adds device tree node for SPI IPs >> >> Cc: linux-fsd@tesla.com >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> Signed-off-by: Aswani Reddy <aswani.reddy@samsung.com> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > >Reviewed-by: Andi Shyti <andi@etezian.org> > >Please, also allow me another nit-commnent for the next patches: >the tag section is in chronological order. I suppose that first Aswani wrote the >patch, then you sent it to the mailing list and at the end Krzysztof has >reviewed it, this means that the right order is: > > Signed-off-by: Aswani Reddy <aswani.reddy@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Sure, will update it in the next version of the patch set. >Thank you, >Andi
On Fri, 21 Jan 2022 00:54:35 +0530, Alim Akhtar wrote: > Adds support for SPI controller found in Tesla FSD SoC > > -Changes since v1 > * Splited SPI changes from a larger inital patch set > * Rebased on Krzysztof's latest (v5) SPI schema changes > * Added tag > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/3] spi: dt-bindings: samsung: Add fsd spi compatible commit: 363d3c51bc5b3243b5b035a1f50d6d994a1b203f [2/3] spi: s3c64xx: Add spi port configuration for Tesla FSD SoC commit: 4ebb15a15799da4954f1d4926fcd3263ea46e417 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark