mbox series

[v3,0/4] spi: dt-bindings: samsung: convert to dtschema

Message ID 20220112100046.68068-1-krzysztof.kozlowski@canonical.com
Headers show
Series spi: dt-bindings: samsung: convert to dtschema | expand

Message

Krzysztof Kozlowski Jan. 12, 2022, 10 a.m. UTC 
Hi,

Changes since v2
================
1. Patch 2: drop child device schema, as Rob suggested.

Changes since v1
================
1. Patch 2: describe devices matching compatible, correct issues pointed out by
   Rob, add reviewed-by tag.
2. New patches 3 and 4.

Best regards,
Krzysztof

Krzysztof Kozlowski (4):
  ARM: dts: exynos: split dmas into array of phandles in Exynos5250
  spi: dt-bindings: samsung: convert to dtschema
  spi: dt-bindings: samsung: allow controller-data to be optional
  spi: s3c64xx: allow controller-data to be optional

 .../spi/samsung,spi-peripheral-props.yaml     |  36 ++++
 .../devicetree/bindings/spi/samsung,spi.yaml  | 187 ++++++++++++++++++
 .../bindings/spi/spi-peripheral-props.yaml    |   1 +
 .../devicetree/bindings/spi/spi-samsung.txt   | 122 ------------
 MAINTAINERS                                   |   2 +-
 arch/arm/boot/dts/exynos5250.dtsi             |   9 +-
 drivers/spi/spi-s3c64xx.c                     |  14 +-
 7 files changed, 234 insertions(+), 137 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/spi/samsung,spi-peripheral-props.yaml
 create mode 100644 Documentation/devicetree/bindings/spi/samsung,spi.yaml
 delete mode 100644 Documentation/devicetree/bindings/spi/spi-samsung.txt

Comments

Alim Akhtar Jan. 16, 2022, 3:28 p.m. UTC | #1 
On Thu, Jan 13, 2022 at 4:19 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> "dmas" property should be rather an array of phandles, as dtschema
> points.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Andi Shyti <andi@etezian.org>
> ---

 Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 139778928b93..102bb57bf704 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -496,8 +496,7 @@ spi_0: spi@12d20000 {
>                         status = "disabled";
>                         reg = <0x12d20000 0x100>;
>                         interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
> -                       dmas = <&pdma0 5
> -                               &pdma0 4>;
> +                       dmas = <&pdma0 5>, <&pdma0 4>;
>                         dma-names = "tx", "rx";
>                         #address-cells = <1>;
>                         #size-cells = <0>;
> @@ -512,8 +511,7 @@ spi_1: spi@12d30000 {
>                         status = "disabled";
>                         reg = <0x12d30000 0x100>;
>                         interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
> -                       dmas = <&pdma1 5
> -                               &pdma1 4>;
> +                       dmas = <&pdma1 5>, <&pdma1 4>;
>                         dma-names = "tx", "rx";
>                         #address-cells = <1>;
>                         #size-cells = <0>;
> @@ -528,8 +526,7 @@ spi_2: spi@12d40000 {
>                         status = "disabled";
>                         reg = <0x12d40000 0x100>;
>                         interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
> -                       dmas = <&pdma0 7
> -                               &pdma0 6>;
> +                       dmas = <&pdma0 7>, <&pdma0 6>;
>                         dma-names = "tx", "rx";
>                         #address-cells = <1>;
>                         #size-cells = <0>;
> --
> 2.32.0
>