| Message ID | 20220116165035.437274-1-henrik@grimler.se |
|---|---|
| Headers | show |
| Series | Add initial support for exynos5420-chagall-wifi | expand |
Hi Alim, > >> > +/* External sdcard */ > >> > +&mmc_2 { > >> > + status = "okay"; > >> > + bus-width = <4>; > >> > + cap-sd-highspeed; > >> > + card-detect-delay = <200>; > >> > + pinctrl-0 = <&sd2_clk &sd2_cmd &mmc2_cd &sd2_bus1 &sd2_bus4>; > >> > + pinctrl-names = "default"; > >> > + samsung,dw-mshc-ciu-div = <3>; > >> > + samsung,dw-mshc-ddr-timing = <0 2>; > >> > + samsung,dw-mshc-sdr-timing = <0 4>; > >> > + sd-uhs-sdr50; > >> > + vmmc-supply = <&ldo19_reg>; > >> > + vqmmc-supply = <&ldo13_reg>; > >> > +}; > >> > + > >> > +&pinctrl_0 { > >> > + mmc2_cd: sd2-cd-pins { > >> > + samsung,pins = "gpx2-4"; > >> > >> Interesting... I looked at vendor sources to board-chagall and > >> standard pin gpc2-2 is mentioned as PULL down and not-connected > >comment. > >> > >> gpx2-4 seems not mentioned at all, unless other board files are > >> actually used. > > > >Gpio seems to be spread out. GPIO_T_FLASH_DETECT is defined as gpx2-4 in > >board-universal5420-mmc.c, and then used for card detection. > >(Looking at it now again I see that write protection through sd2_wp should > >also be supported for mmc_2, can add that in next patch set.) > > > Card detect pin is generally a special function (dedicated pin) pin, > directly connected from SoC to card external slot. > And for exynos5420 it is gpc2-2 as pointed by Krzysztof. gpio/pinctrl is still not my area of expertise so your feedback is greatly appreciated! gpc2-2 does not seem to be the card-detect pin for these tablets. If I add sd2_cd to pinctrl-0 above I am unable to use the sdcard at all, instead dmesg is filled with repeating messages like: [ 18.669050] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 300000Hz, actual 297619HZ div = 84) [ 18.703711] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 200000Hz, actual 200000HZ div = 125) [ 18.737167] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 100000Hz, actual 100000HZ div = 250) [ 19.058352] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 400000Hz, actual 396825HZ div = 63) [ 19.093037] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 300000Hz, actual 297619HZ div = 84) [ 19.127701] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 200000Hz, actual 200000HZ div = 125) [ 19.162380] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 100000Hz, actual 100000HZ div = 250) gpx2-4 on the other hand switches state when an sdcard is inserted or removed. After exporting relevant pins I have, with the card inserted: # grep -A 2 gpx2 /sys/kernel/debug/gpio gpiochip3: GPIOs 24-31, parent: platform/13400000.pinctrl, gpx2: gpio-26 ( |Power ) in hi IRQ ACTIVE LOW gpio-28 ( |sysfs ) in lo and when removed gpx2-4 changes to high: gpiochip3: GPIOs 24-31, parent: platform/13400000.pinctrl, gpx2: gpio-26 ( |Power ) in hi IRQ ACTIVE LOW gpio-28 ( |sysfs ) in hi All the gpc2 pins are low no matter if sdcard is inserted or removed: gpiochip7: GPIOs 56-62, parent: platform/13410000.pinctrl, gpc2: gpio-56 ( |sysfs ) in lo gpio-57 ( |sysfs ) in lo gpio-58 ( |sysfs ) in lo gpio-59 ( |sysfs ) in lo gpio-60 ( |sysfs ) in lo gpio-61 ( |sysfs ) in lo gpio-62 ( |sysfs ) in lo That being said, I am not sure if it is working properly: > Also PIN_FUNC_2 for gpx2-4 indicate that it is wakeup_int2 function. > Do you get a card detect interrupt when removing and inserting the card to > the card slot? (What is the best way to check this?) I don't get any irq related messages in dmesg, and I don't see any changes in /proc/interrupts if tracked with something like `watch -n1 "cat /proc/interrupts"` when card is removed or inserted, so seems likely that pin config is wrong. All I can find in vendor kernel for this device is that pull config is set to S3C_GPIO_PULL_NONE [1]. For some of the sibling tablets the pin is configured as {S3C_GPIO_INPUT, GPIO_LV_N, S3C_GPIO_PULL_NONE} [2] though, which I think should correspond to having: mmc2_cd: mmc2-cd-pins { samsung,pins = "gpx2-4"; samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>; samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; }; Changing to that does not seem to change anything though, I don't get any interrupt, or any messages in dmesg, when inserting or removing the sdcard. > Also to avoid confusion, probably you can change the node name as "mmc2_cd: > mmc2-cd-pins" > (as sd2-cd-pins is gpc2-2 for this SoC) Thanks, will fix in a v4 (after discussions here are settled). [1] https://github.com/exynos5420/android_kernel_samsung_exynos5420/blob/lineage-17.1/arch/arm/mach-exynos/board-universal5420-mmc.c#L388 [2] https://github.com/exynos5420/android_kernel_samsung_exynos5420/blob/lineage-17.1/arch/arm/mach-exynos/board-n1-gpio.c#L119 Best regards, Henrik Grimler
Samsung's tablet Galaxy Tab S 10.5" (wifi) has codename Chagall WiFi and is one of several tablets released in 2014 based on Exynos 5420. This initial devicetree adds support for accessing device over USB or UART, and allows using a rootfs in either the internal eMMC or an external sdcard. 4 out of 8 CPUs are brought up when device boots, which is the same as on the somewhat similar board exynos5420-arndale-octa. Patch 2 is necessary after a secure-firmware node is added, otherwise device hangs during the CPU1BOOT secure monitor call. Without the secure-firmware node we are not able to bring up any secondary CPUs. Changes since v2 ================ Addressing Krzysztof's feedback: * chagallwifi -> chagall-wifi and Chagall WiFi in messages and comments * Re-write commit message for patch 3, use commit hash and ("subject"), move hint about bootloader issue to galaxy-tab-common.dtsi * Fix s2mps11 regulator nodes, use &ldoXX_reg handle for device customisation * Re-add usbdrd supplies (works after fixing regulator nodes) * Remove unnecessary, duplicate, compatible in galaxy-tab-common.dtsi * Remove extra clocks xxti and xusbxti * Prefix key- to gpio-keys * Add pinctrl pins to mmc_2. card-detect pin is different than for other Exynos 5420 devices, so define and use mmc2_cd node under pinctrl_0 Additional changes: * Add/fix supplies of mmc_0 and mmc_2 (vmmc-supply for mmc0 is unknown) * Sort mmc_X properties alphabetically * Fix IRQ pin for s2mps11, it was wrong (gpx3-2 -> gpx3-0) * Mark LDO31 as varying between devices as well, it differs between WiFi and LTE tablet versions * Fix typo for LDO5 (regulato-name -> regulator-name) * Remove regulator-ramp-delay from buck regulators, based on exynos5420-arndale-octa there should be no need to set it Changes since v1 ================ Fix mmc_0 and usbdrd in patch 3: * Remove extra, non supported, options from mmc_0 node * Do not set usbdrd supplies. Usb networking does not work with them specified, but it works fine with dummy regulators Henrik Grimler (3): dt-bindings: arm: samsung: document Chagall WiFi board binding ARM: exynos: only do SMC_CMD_CPU1BOOT call on Exynos4 ARM: dts: Add support for Samsung Chagall WiFi .../bindings/arm/samsung/samsung-boards.yaml | 1 + arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/exynos5420-chagall-wifi.dts | 65 ++ .../dts/exynos5420-galaxy-tab-common.dtsi | 666 ++++++++++++++++++ arch/arm/mach-exynos/firmware.c | 4 +- 5 files changed, 736 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/exynos5420-chagall-wifi.dts create mode 100644 arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi