| Message ID | 20211213082751.745001-1-yangyingliang@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] Bluetooth: virtio_bt: fix error return code in virtbt_probe() | expand |
On Mon, Dec 13, 2021 at 04:27:51PM +0800, Yang Yingliang wrote: > Fix to return a negative error code from the error handling > case in virtbt_probe(). > > Fixes: 212a6e51a630 ("Bluetooth: virtio_bt: fix device removal") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> same patch was also posted by Dan Carpenter. > --- > drivers/bluetooth/virtio_bt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c > index 1dd734aef87b..f6d699fed139 100644 > --- a/drivers/bluetooth/virtio_bt.c > +++ b/drivers/bluetooth/virtio_bt.c > @@ -362,7 +362,8 @@ static int virtbt_probe(struct virtio_device *vdev) > } > > virtio_device_ready(vdev); > - if (virtbt_open_vdev(vbt)) > + err = virtbt_open_vdev(vbt); > + if (err) > goto open_failed; > > return 0; > -- > 2.25.1
diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c index 1dd734aef87b..f6d699fed139 100644 --- a/drivers/bluetooth/virtio_bt.c +++ b/drivers/bluetooth/virtio_bt.c @@ -362,7 +362,8 @@ static int virtbt_probe(struct virtio_device *vdev) } virtio_device_ready(vdev); - if (virtbt_open_vdev(vbt)) + err = virtbt_open_vdev(vbt); + if (err) goto open_failed; return 0;
Fix to return a negative error code from the error handling case in virtbt_probe(). Fixes: 212a6e51a630 ("Bluetooth: virtio_bt: fix device removal") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/bluetooth/virtio_bt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)